[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-03-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #9 from Lucas Gass  ---
doesnt apply clean to 19.05.x, no backport

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Joy Nelson  changed:

   What|Removed |Added

 Version(s)|20.05.00|20.05.00, 19.11.03
released in||
 CC||j...@bywatersolutions.com
 Status|Pushed to master|Pushed to stable

--- Comment #8 from Joy Nelson  ---
Pushed to 19.11.x branch for 19.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

--- Comment #7 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97585|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 98446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98446=edit
Bug 23844: Check if field defined in framework and specify 'Default' for
framework

To test:
1 - Go to Cataloguing
2 - New from Z3950
3 - Find an import a record
4 - Check the plack logs:
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 565.
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 580.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 711.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 715.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 734.
5 - Apply patch
6 - Repeat
7 - No new errors
8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates
no errors

Signed-off-by: Myka Kennedy Stephens 

Signed-off-by: Jonathan Druart 
Note: the template change does not seem necessary here but should not
hurt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-02-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-01-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

--- Comment #5 from Nick Clemens  ---
(In reply to Jonathan Druart from comment #4)
> Nick, I only get those:
> 
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 708.
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 712.
> Use of uninitialized value $frameworkcode in string eq at
> /kohadevbox/koha/cataloguing/addbiblio.pl line 731.
> 
> 
> Who did you end up with tab that is NULL?
> 
> I get:
> MariaDB [koha_kohadev]> select distinct(tab) from marc_subfield_structure;
> +--+
> | tab  |
> +--+
> |   -1 |
> |0 |
> |1 |
> |2 |
> |3 |
> |4 |
> |5 |
> |6 |
> |7 |
> |8 |
> |9 |
> |   10 |
> +--+
> 12 rows in set (0.03 sec)

I believe the issue here is when the imported record has fields that are not
defined in the frameworks - so we are trying to get the tab for a field that
has no tab defined.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-01-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #4 from Jonathan Druart  
---
Nick, I only get those:

Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 708.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 712.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 731.


Who did you end up with tab that is NULL?

I get:
MariaDB [koha_kohadev]> select distinct(tab) from marc_subfield_structure;
+--+
| tab  |
+--+
|   -1 |
|0 |
|1 |
|2 |
|3 |
|4 |
|5 |
|6 |
|7 |
|8 |
|9 |
|   10 |
+--+
12 rows in set (0.03 sec)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens  changed:

   What|Removed |Added

 CC||mkstephens@lancasterseminar
   ||y.edu

--- Comment #3 from Myka Kennedy Stephens  ---
Patch works as described for Cataloging > New from Z39.50 and Cataloging > New
from Z39.50 > Default framework.

I would like to point out that the $frameworkcode errors do still appear with
this patch applied when adding records using Catloging > New Record > Default
framework > Z39.50 search and also when using the New > New Record (then click
Z39.50 search button) option from within an existing record.

My plack logs showed the $frameworkcode errors on lines 708, 712, and 731, and
I'm seeing a lot more "uninitialized value in string ne" errors than in the
example provided.
I'm also seeing the following error regardless of method for adding records:
"Use of uninitialized value $searchid in concatenation (.) or string at
/kohadevbox/koha/cataloguing/addbiblio.pl line 860."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens  changed:

   What|Removed |Added

  Attachment #94416|0   |1
is obsolete||

--- Comment #2 from Myka Kennedy Stephens  ---
Created attachment 97585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97585=edit
Bug 23844: Check if field defined in framework and specify 'Default' for
framework

To test:
1 - Go to Cataloguing
2 - New from Z3950
3 - Find an import a record
4 - Check the plack logs:
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 565.
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 580.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 711.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 715.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 734.
5 - Apply patch
6 - Repeat
7 - No new errors
8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates
no errors

Signed-off-by: Myka Kennedy Stephens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2020-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Myka Kennedy Stephens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2019-12-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2019-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

Nick Clemens  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 23844] Noisy warns in addbiblio.pl when importing from Z3950

2019-10-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23844

--- Comment #1 from Nick Clemens  ---
Created attachment 94416
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94416=edit
Bug 23844: Check if field defined in framework and specify 'Default' for
framework

To test:
1 - Go to Cataloguing
2 - New from Z3950
3 - Find an import a record
4 - Check the plack logs:
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 565.
Use of uninitialized value in string ne at
/kohadevbox/koha/cataloguing/addbiblio.pl line 580.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 711.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 715.
Use of uninitialized value $frameworkcode in string eq at
/kohadevbox/koha/cataloguing/addbiblio.pl line 734.
5 - Apply patch
6 - Repeat
7 - No new errors
8 - Confirm selecting 'Default' from 'New from Z3950' dropdown also generates
no errors

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/