[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31137 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Documentation||Martin Renvoize contact|| Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #63 from Martin Renvoize --- Bugfix with not visual or workflow changes, no documentation updates required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|22.05.00,21.11.06 |22.05.00,21.11.06,21.05.16 released in|| Status|Pushed to stable|Pushed to oldstable CC||vic...@tuxayo.net --- Comment #62 from Victor Grousset/tuxayo --- Backported: Pushed to 21.05.x branch for 21.05.16 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com Version(s)|22.05.00|22.05.00,21.11.06 released in|| --- Comment #61 from Kyle M Hall --- Pushed to 21.11.x for 21.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #60 from Fridolin Somers --- Test suite was failing, like : https://jenkins.koha-community.org/view/master/job/Koha_Master_D10/624/testReport/ Fixed by changing expected values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #59 from Fridolin Somers --- Created attachment 134346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134346=edit Bug 24001: (follow-up) Fix t_Profile.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #58 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Attachment #134081|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 134125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134125=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Attachment #134080|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 134124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134124=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #55 from Katrin Fischer --- Agreeing with Martin, sorry, we overlapped! I filed 2 new bugs: Bug 30629 - in title of patron card creator template needs to be removed Bug 30631 - Show list of existing printer profiles when creating a new patron card template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30631 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Katrin Fischer changed: What|Removed |Added Attachment #134078|0 |1 is obsolete|| --- Comment #54 from Katrin Fischer --- Created attachment 134081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134081=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=30373 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Katrin Fischer changed: What|Removed |Added Attachment #134077|0 |1 is obsolete|| --- Comment #53 from Katrin Fischer --- Created attachment 134080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134080=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti Signed-off-by: David Nind Signed-off-by: Katrin Fischer https://bugs.koha-community.org/show_bug.cgi?id=30373 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #52 from Martin Renvoize --- Looking good and fixes the issue.. no QA script highlights so Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Attachment #134075|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize --- Created attachment 134078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134078=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added Attachment #134074|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 134077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134077=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti Signed-off-by: David Nind Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 David Nind changed: What|Removed |Added Text to go in the||This fixes errors that release notes||caused creating and editing ||patron card templates and ||printer profiles to fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 David Nind changed: What|Removed |Added Attachment #131495|0 |1 is obsolete|| --- Comment #49 from David Nind --- Created attachment 134075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134075=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 David Nind changed: What|Removed |Added Attachment #131494|0 |1 is obsolete|| --- Comment #48 from David Nind --- Created attachment 134074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134074=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #47 from The Minh Luong --- Created attachment 131495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131495=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 The Minh Luong changed: What|Removed |Added Attachment #109764|0 |1 is obsolete|| Attachment #131381|0 |1 is obsolete|| --- Comment #46 from The Minh Luong --- Created attachment 131494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131494=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #45 from Nick Clemens --- Created attachment 131381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131381=edit Bug 24001: Fix Card template/rpinter profile creation and edit This patch adjusts the template/profiles to use the default of '0' This should probably be NULL, and the columns foreign keys, this code could use a further rewrite, but this should fix a long standing bug To test: 1 - Using the fresh install, with all the sample data. 2 - Go to Home › Tools › Patron card creator › Templates 3 - New > Card template 4 - Save 5 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 6 - Edit an existing template 7 - Save 8 - Error: Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 9 - Create a new 'Printer profile' 10 - Save 11 - Error: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 12 - Apply the attached patch. 13 - Verify you can create a new 'Card template' and 'Printer profile' with no errors 14 - Verify you can edit and save both of the newly created objects above -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 The Minh Luong changed: What|Removed |Added CC||the-minh.lu...@inlibro.com --- Comment #44 from The Minh Luong --- Hi. I have followed the steps of comment 40 and I can't reproduce the problem. Here is what i did: After applying the patch: I attempt to create a new card template. The card template is created. However, I don't see any errors in my plack-intranet-error.log file. I also checked other logs and no error are displayed. I also tried to create a printer profile, as mentioned in the comment. The profile is created and I still can't see any of the errors in the log files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Blou changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |alexis.ripe...@inlibro.com |u | --- Comment #43 from Blou --- I suppose we could extend the patch to catch all cases where profile_id is set to '' instead of 0 The errors comes from save(), which seems called by label-edit-template.pl and patroncards/edit-template.pl which are very loose with their assignments of profile_id. But beside that, you'll have to be specific. We coded (and use) this patch in its simplest form, to avoid the problems. But we're not rearchitecturing the underlying issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #42 from Martin Renvoize --- Still able to work on this Blou? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #41 from Jonathan Druart --- *** Bug 27517 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||da...@davidnind.com --- Comment #40 from David Nind --- Apologies for the rather long comment, and for marking as "Failed QA". TLDR; - the patch works, however there is a problem with the printer profile drop down list - it takes you to the new printer profile page - you can't create a new printer profile (for both the patron card creator and the label creator tools) - this should possibly be another bug - it looks like this hasn't worked for several versions Before applying the patch = The card template is not created and you are returned to the list of currently available templates. These error messages are generated in /var/log/koha/kohadev/plack-intranet-error.log: 1 [2020/10/03 06:08:27] [WARN] DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 [for Statement "INSERT INTO creator_templates (`template_code`, `label_width`, `top_margin`, `col_gap`, `template_desc`, `row_gap`, `rows`, `page_width`, `cols`, `label_height`, `units`, `top_text_margin`, `left_margin`, `left_text_margin`, `profile_id`, `creator`, `page_height`) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);" with ParamValues: 0="A DEFAULT TEMPLATE", 1="0", 2="0", 3="0", 4="A Default descr iption", 5="0", 6="0", 7="0", 8="0", 9="0", 10="POINT", 11=0, 12="0", 13=0, 14='', 15='Patroncards', 16="0"] at /kohadevbox/koha/C4/ Creators/Template.pm line 199. 2 [2020/10/03 06:08:27] [WARN] Database returned the following error: Incorrect integer value: '' for column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm line 201. 3 [2020/10/03 06:08:28] [WARN] CGI::param called in list context from /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron cards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. If you try to create a printer profile (New > Printer profile) the printer profile is not created - you are returned to the list of current available templates. These error messages are generated in /var/log/koha/kohadev/plack-intranet-error.log: 4 [2020/10/03 06:10:57] [WARN] DBD::mysql::st execute failed: Incorrect integer value: '' for column 'template_id' at row 1 [for Statement "INSERT INTO printers_profile (creep_vert, offset_horz, units, printer_name, creator, template_id, offset_vert, paper_bin, creep_horz) VALUES (?,?,?,?,?,?,?,?,?);" with ParamValues: 0="0", 1="0", 2="POINT", 3="ABC", 4='Patroncards', 5='', 6="0", 7="2", 8="0"] at /kohadevbox/koha/C4/Creators/Profile.pm line 162. 5 [2020/10/03 06:10:57] [WARN] Database returned the following error on attempted INSERT: Incorrect integer value: '' for column 'template_id' at row 1 at /kohadevbox/koha/C4/Creators/Profile.pm line 164. After applying the patch After applying the patch and adding a card template the card template is created, so that fixes that issue! However, there is this error message in /var/log/koha/kohadev/plack-intranet-error.log: [2020/10/03 06:15:59] [WARN] CGI::param called in list context from /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patron cards-errors.inc line 57, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. On the create patron card template page if you click on "Click here to define a printer profile.", you are taken to the create printer profile screen. I'm not sure what is expected here, but I expect it should be a drop down list of printer profiles like for the label creator tool (as per Caroline's comment #37). If you try to create a printer profile you get the same behaviour as before the patch was applied. Other notes: - Tested using koha-testing-docker and started with ku. - Using the label creator tool, you get the same error message when you try to create a printer profile for the patron card creator. Error messages for Koha 20.05.x, Koha 19.11.x = You get these error messages in Koha 20.05.x, 19.11.x and 19.05.x Create a patron card template - error message in /var/log/koha/kohadev/plack-error.log: 7 DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 [for Statement "INSERT INTO creator_templates (`row_gap`, `units`, `template_code`, `page_height`, `left_text_margin`, `page_width`, `profile_id`, `top_text_margin`, `creator`, `label_width`, `template_desc`, `left_margin`, `rows`, `cols`, `top_margin`, `col_gap`, `label_height`)
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Alexis Ripetti changed: What|Removed |Added CC||alexis.ripe...@inlibro.com Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Alexis Ripetti changed: What|Removed |Added Attachment #106434|0 |1 is obsolete|| --- Comment #39 from Alexis Ripetti --- Created attachment 109764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109764=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. Signed-off-by: Alexis Ripetti -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Alexis Ripetti changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Blou changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Blou changed: What|Removed |Added CC||philippe.blo...@inlibro.com Attachment #95981|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Blou changed: What|Removed |Added Attachment #99164|0 |1 is obsolete|| --- Comment #38 from Blou --- Created attachment 106434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106434=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 This is caused by the profile dropdown offering invalid choices and is fixed by adding a filter to limit options to creator = 'Patroncards'. The UI already handles the case where no valid profile is avaiable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com --- Comment #37 from Caroline Cyr La Rose --- I tested the patchset and it works. When you edit a card template, there is no more error and the profile is set to No profile/NA. However, the drop-down menu for the profiles still gives me the possibility to choose a printer profile that is not part of the patron cards creator but the label creator. If I try to select that profile, it gives me an error, which is expected, but the choice should not be there in the first place. The drop down menu should be limited to printer profiles in the patron card creator (plus the No profile choice). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #36 from Rinrada Wongsaichua ---
(In reply to Jonathan Druart from comment #35)
> Hello Rinrada,
>
> I have attached a file that has the correct format (patch).
> However I am not sure this is the correct way to fix the issue.
>
> Chris, can we get your opinion on it?
Hi Jonathan,
every time I edit template of patroncards which has no profile_id attached to
template
Profile will display first printer name from the selector list even if
profile_id==0
Tested edit on template of labels that has no profile_id attached
(profile_id==0)
It will display 'Profile: No Profile/N/A' and able to save successfully no
error
Checked label-edit-template.pl and found this line
>> push @$profile_list, {paper_bin => 'N/A', profile_id => 0, printer_name =>
>> 'No Profile'};
which only exist in label-edit-template.pl but does not exist in
edit-template.pl
Checked database and noticed that both patroncards and labels stored Printer
profiles in the same table (printers_profile table) and identify by creator
field
Hopefully my investigation will help you guys on this case come how
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #35 from Jonathan Druart --- Hello Rinrada, I have attached a file that has the correct format (patch). However I am not sure this is the correct way to fix the issue. Chris, can we get your opinion on it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Attachment #98722|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 99164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99164=edit Bug 24001: Fix patron card template edition Error when saving Patron card Template: Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 Can be fixed by add this one line into /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #33 from Rinrada Wongsaichua --- Created attachment 98722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98722=edit [PATCH] Bug 24001: Cannot edit card template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #32 from Rinrada Wongsaichua --- okay I don't know how it works But I just wanted to share solution that work for me I've tested on my server and issue has been resolved -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Status|REOPENED|NEW --- Comment #31 from Jonathan Druart --- Please do not change the status to "resolved". It is marked resolved once we have a patch pushed into master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
Rinrada Wongsaichua changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #30 from Rinrada Wongsaichua ---
(In reply to Jonathan Druart from comment #29)
> (In reply to Rinrada Wongsaichua from comment #28)
> > Error when saving Patron card Template:
> > Can't bless non-reference value at
> > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
> >
> > Can be fixed by add this one line into
> > /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl
> >
> > 52$profile_list = get_all_profiles({ fields => [ qw( profile_id
> > printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]}
> > } );
> > +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0,
> > printer_name => 'No Profile'};
>
> Can you please provide a patch?
Sorry I'm new here(In reply to Jonathan Druart from comment #29)
> (In reply to Rinrada Wongsaichua from comment #28)
> > Error when saving Patron card Template:
> > Can't bless non-reference value at
> > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
> >
> > Can be fixed by add this one line into
> > /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl
> >
> > 52$profile_list = get_all_profiles({ fields => [ qw( profile_id
> > printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]}
> > } );
> > +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0,
> > printer_name => 'No Profile'};
>
> Can you please provide a patch?
I'm sorry I'm new for this site, really don't know how to attach patch or
create one
Basically you just need to add this line into edit-template.pl then issue
resolved
You'll now able to save patron card template without any error
--- /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl
on line 52$profile_list = get_all_profiles({ fields => [ qw( profile_id
printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} }
);
++push @$profile_list, {paper_bin => 'N/A', profile_id => 0,
printer_name => 'No Profile'};
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
Jonathan Druart changed:
What|Removed |Added
Resolution|FIXED |---
Status|RESOLVED|REOPENED
--- Comment #29 from Jonathan Druart
---
(In reply to Rinrada Wongsaichua from comment #28)
> Error when saving Patron card Template:
> Can't bless non-reference value at
> /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
>
> Can be fixed by add this one line into
> /usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl
>
> 52$profile_list = get_all_profiles({ fields => [ qw( profile_id
> printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]}
> } );
> +++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0,
> printer_name => 'No Profile'};
Can you please provide a patch?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Status|REOPENED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
Rinrada Wongsaichua changed:
What|Removed |Added
Resolution|--- |FIXED
CC||hlunli...@gmail.com
Status|Failed QA |RESOLVED
--- Comment #28 from Rinrada Wongsaichua ---
Error when saving Patron card Template:
Can't bless non-reference value at
/home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
Can be fixed by add this one line into
/usr/share/koha/intranet/cgi-bin/patroncards/edit-template.pl
52$profile_list = get_all_profiles({ fields => [ qw( profile_id
printer_name paper_bin ) ], filters => {template_id => [ $template_id, '' ]} }
);
+++ push @$profile_list, {paper_bin => 'N/A', profile_id => 0, printer_name
=> 'No Profile'};
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #27 from Jonathan Druart --- The patch fixes the creation with strict_sql_modes on (comment 1), but not the edition from comment 0 Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #26 from Chris Nighswonger --- This actually fixes both issues described in this bug. To test this, re-run the above procedure with strict_sql_modes set to the opposite value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #25 from Chris Nighswonger --- Test plan: 1. Using the fresh install, with all the sample data. 2. Go to Home › Tools › Patron card creator › Templates 3. New > Card template 4. Save 5. Edit 6. Save Note either of the two errors in the error log. Apply the attached patch. 1. Go to Home › Tools › Patron card creator › Templates 2. Select the previously created template 3. Delete it 4. New > Card template 5. Save 6. Edit 7. Save Note the absence of either of the two errors in error log. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #24 from Chris Nighswonger --- Created attachment 95981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95981=edit Bug 24001: Cannot edit card template Change hardcoded default value of profile_id to 0 rather than null. Signed-off-by: Chris Nighswonger -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Chris Nighswonger changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #23 from Chris Nighswonger --- I'm working on using Bywater's sandbox script to set up a test bed. Once that's up and running, I'll work through this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #22 from Jonathan Druart --- (In reply to Chris Nighswonger from comment #21) > What language sample data are you using on this test set? > > Side note: The sample data for labels/patroncards among various languages > appears to vary tremendously and probably erroneously. I am using a 'classic' install, 'en'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #21 from Chris Nighswonger --- What language sample data are you using on this test set? Side note: The sample data for labels/patroncards among various languages appears to vary tremendously and probably erroneously. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #20 from Jonathan Druart --- MariaDB [koha_kohadev]> SELECT template_id, profile_id, template_desc, creator FROM creator_templates; +-+++-+ | template_id | profile_id | template_desc | creator | +-+++-+ | 1 | 1 | 3 columns, 10 rows of labels | Labels | | 7 | 13 | 1" X 1.5" Spine Label | Setup for up to four lines of text | Labels | | 12 | 14 | 1" X 1.5" Spine Label | Setup for five lines of text | Labels | | 22 | 0 | Default description | Labels | | 23 | 16 | A template for home brewed patron card forms | Patroncards | | 24 | 0 | Default description | Patroncards | +-+++-+ 6 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #19 from Chris Nighswonger ---
(In reply to Jonathan Druart from comment #17)
> (In reply to Chris Nighswonger from comment #16)
> > Just to be clear: I think we are encountering different issues in the
> > description and comment #1.
>
> Yes of course, it is what I said in comment #1.
>
> If you have the strict_sql_modes turned on it explodes on creating the
> template.
>
Let's open a separate bug for the second issue you mention. The strict sql
issue.
>
> (In reply to Chris Nighswonger from comment #15)
> > (In reply to Jonathan Druart from comment #14)
> > > It has a printers_profile.profile_id = 22, but I think here we are talking
> > > about creator_templates.profile_id
> > >
> > > MySQL [koha_kohadev]> select template_id, profile_id from
> > > creator_templates;
> >
> > The error occurs on attempting to execute the following on your system in
> > the script:
> >
> > SELECT * FROM printers_profile WHERE profile_id = 22 AND creator =
> > 'Patroncards';
> >
> > What does that say in the client?
>
> 0. I am using the fresh install, with all the sample data.
> 1. Turning off strict_sql_modes
> 2. Go to Home › Tools › Patron card creator › Templates
> 3. New > Card template
> 4. Save
> 5. Edit
> 6. Save
>
> Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm
> line 89
>
> C4::Creators::Profile::retrieve('C4::Patroncards::Profile',
> 'profile_id', 22, 'creator', 'Patroncards') called at
> /kohadevbox/koha/C4/Patroncards/Profile.pm line 29
>
> C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator',
> 'Patroncards') called at /kohadevbox/koha/patroncards/edit-template.pl line
> 78
> eval {...} at /kohadevbox/koha/patroncards/edit-template.pl line 2
>
>
> MariaDB [koha_kohadev]> SELECT * FROM printers_profile WHERE profile_id = 22
> AND creator = 'Patroncards';
> Empty set (0.00 sec)
Forgive me as I do not have a test installation setup nor the time to get one
up and running:
What does 'SELECT template_id, profile_id, template_desc, creator FROM
creator_templates;' say?
I think I know what is causing this.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #18 from Jonathan Druart --- On "Edit" I am on /patroncards/edit-template.pl?op=edit_id=24 https://snipboard.io/Qhk87I.jpg "Library Laser/Tray 3" has a profile_id=22 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #17 from Jonathan Druart
---
(In reply to Chris Nighswonger from comment #16)
> Just to be clear: I think we are encountering different issues in the
> description and comment #1.
Yes of course, it is what I said in comment #1.
If you have the strict_sql_modes turned on it explodes on creating the
template.
(In reply to Chris Nighswonger from comment #15)
> (In reply to Jonathan Druart from comment #14)
> > It has a printers_profile.profile_id = 22, but I think here we are talking
> > about creator_templates.profile_id
> >
> > MySQL [koha_kohadev]> select template_id, profile_id from creator_templates;
>
> The error occurs on attempting to execute the following on your system in
> the script:
>
> SELECT * FROM printers_profile WHERE profile_id = 22 AND creator =
> 'Patroncards';
>
> What does that say in the client?
0. I am using the fresh install, with all the sample data.
1. Turning off strict_sql_modes
2. Go to Home › Tools › Patron card creator › Templates
3. New > Card template
4. Save
5. Edit
6. Save
Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line
89
C4::Creators::Profile::retrieve('C4::Patroncards::Profile',
'profile_id', 22, 'creator', 'Patroncards') called at
/kohadevbox/koha/C4/Patroncards/Profile.pm line 29
C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator',
'Patroncards') called at /kohadevbox/koha/patroncards/edit-template.pl line 78
eval {...} at /kohadevbox/koha/patroncards/edit-template.pl line 2
MariaDB [koha_kohadev]> SELECT * FROM printers_profile WHERE profile_id = 22
AND creator = 'Patroncards';
Empty set (0.00 sec)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #16 from Chris Nighswonger --- Just to be clear: I think we are encountering different issues in the description and comment #1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #15 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #14) > It has a printers_profile.profile_id = 22, but I think here we are talking > about creator_templates.profile_id > > MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; The error occurs on attempting to execute the following on your system in the script: SELECT * FROM printers_profile WHERE profile_id = 22 AND creator = 'Patroncards'; What does that say in the client? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #14 from Jonathan Druart --- It has a printers_profile.profile_id = 22, but I think here we are talking about creator_templates.profile_id MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; +-++ | template_id | profile_id | +-++ | 22 | 0 | | 24 | 0 | | 1 | 1 | | 7 | 13 | | 12 | 14 | | 23 | 16 | +-++ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #13 from Chris Nighswonger ---
(In reply to Jonathan Druart from comment #0)
> To recreate:
> - Go to Home › Tools › Patron card creator › Templates
> - New > Card template
> - Save
> - Edit
> - Save
>
> =>
> Can't bless non-reference value at
> /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89
> C4::Creators::Profile::retrieve('C4::Patroncards::Profile',
> 'profile_id', 22, 'creator', 'Patroncards') called at
> /home/vagrant/kohaclone/C4/Patroncards/Profile.pm line 29
> C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator',
> 'Patroncards') called at
> /home/vagrant/kohaclone/patroncards/edit-template.pl line 78
Just reading back over this: Does your installation have a profile with a
profile_id == 22?
It seems that the problem described in the first comment could be different
from the one described in the second second.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #12 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #9) > edit-template, sorry! > > So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new > displays: > https://snipboard.io/HCSgBE.jpg > > See the "Click here to define a printer profile", even if printer profiles > exist (this is IMO a bug). This could probably be fixed by doing something similar to this: http://tinyurl.com/rmhmmw8 in here: http://tinyurl.com/tshysa5 Adjusting the code for the fact that there is not yet a template_id, of course. I'll be away for a few hours now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #11 from Chris Nighswonger --- I would guess the same issue exists in labels: http://tinyurl.com/s2pj4cs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #10 from Chris Nighswonger ---
(In reply to Jonathan Druart from comment #9)
> edit-template, sorry!
>
> So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new
> displays:
> https://snipboard.io/HCSgBE.jpg
>
> See the "Click here to define a printer profile", even if printer profiles
> exist (this is IMO a bug).
I tend to agree.
>
> Then save => It's not saved and we get the SQL error.
>
> Given the code you pointed it to me, a profile is created if none is passed.
> Are we expecting it to be created with a profile_id=0?
> What on the second template we will add? We created another profile_id=0?
No.
When a new template is created with no profile_id passed along, the profile_id
is set to 0: http://tinyurl.com/smoh5g6
Ah ha! Here is the offending line: http://tinyurl.com/qurdjnc
It should be thus:
my @params = ( profile_id => scalar $cgi->param('profile_id') || 0,
Only we need to be sure that the value of profile_id is truly numeric and not
just null. Perhaps it may need to be quoted. Field constraints disallow null
values and '' is just that, of course.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #9 from Jonathan Druart --- edit-template, sorry! So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new displays: https://snipboard.io/HCSgBE.jpg See the "Click here to define a printer profile", even if printer profiles exist (this is IMO a bug). Then save => It's not saved and we get the SQL error. Given the code you pointed it to me, a profile is created if none is passed. Are we expecting it to be created with a profile_id=0? What on the second template we will add? We created another profile_id=0? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #8 from Chris Nighswonger ---
(In reply to Jonathan Druart from comment #7)
> (In reply to Chris Nighswonger from comment #5)
> > (In reply to Jonathan Druart from comment #4)
> > > There is no printers_profile.profile_id == 0 in DB, so I am expecting an
> > > error as well.
> > >
> > > Is there a good reason to not display the list of available profiles on
> > > adding?
> >
> > It should: http://tinyurl.com/rkfw9fx
>
> We are in patroncards/edit-profile.pl, which does not have this else{} part.
edit-profile.pl or edit-template.pl?
> This is even worst with strict_sql_modes turned on, the creation of a new
> template is impossible:
...
> There is a logic issue in the controller, the printer profile list is not
> passed to the template (only passed when editing).
http://tinyurl.com/t9zksc2
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #7 from Jonathan Druart
---
(In reply to Chris Nighswonger from comment #5)
> (In reply to Jonathan Druart from comment #4)
> > There is no printers_profile.profile_id == 0 in DB, so I am expecting an
> > error as well.
> >
> > Is there a good reason to not display the list of available profiles on
> > adding?
>
> It should: http://tinyurl.com/rkfw9fx
We are in patroncards/edit-profile.pl, which does not have this else{} part.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #6 from Chris Nighswonger --- (In reply to Chris Nighswonger from comment #5) > (In reply to Jonathan Druart from comment #4) > > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > > error as well. > > > > Is there a good reason to not display the list of available profiles on > > adding? > > It should: http://tinyurl.com/rkfw9fx > > And on further review of that code block, the profile_id should be set to 0 > there. > > Something else must be failing along the way. Maybe in your instance its > never dropping into that else block? If that's the case, I wonder where it > goes? What is $op in your instance? Better yet, what is the value of $template_id in your instance? Maybe there is some corrupted data that the script is choking on? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #5 from Chris Nighswonger --- (In reply to Jonathan Druart from comment #4) > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > error as well. > > Is there a good reason to not display the list of available profiles on > adding? It should: http://tinyurl.com/rkfw9fx And on further review of that code block, the profile_id should be set to 0 there. Something else must be failing along the way. Maybe in your instance its never dropping into that else block? If that's the case, I wonder where it goes? What is $op in your instance? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #3 from Jonathan Druart --- There is not printers_profile.profile_id in DB, so I am expecting an error as well. Is there a good reason to not display the list of available profiles on adding? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #4 from Jonathan Druart --- There is no printers_profile.profile_id == 0 in DB, so I am expecting an error as well. Is there a good reason to not display the list of available profiles on adding? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001
--- Comment #2 from Chris Nighswonger ---
(In reply to Jonathan Druart from comment #1)
> This is even worst with strict_sql_modes turned on, the creation of a new
> template is impossible:
>
> DBD::mysql::st execute failed: Incorrect integer value: '' for column
> 'profile_id' ... at
> /kohadevbox/koha/C4/Creators/Template.pm line 199.
> Database returned the following error: Incorrect integer value: '' for
> column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm
> line 201.
>
> There is a logic issue in the controller, the printer profile list is not
> passed to the template (only passed when editing).
The default profile_id should be 0: http://tinyurl.com/smoh5g6
Which is overwritten here: http://tinyurl.com/s2pj4cs
Probably changing
profile_id => scalar $cgi->param('profile_id'),
to
profile_id => scalar $cgi->param('profile_id') || 0,
would fix the acute pain.
I suspect that there are many such issues lurking in the label/patroncard code
unfortunately.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart changed: What|Removed |Added Blocks||17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24001] Cannot edit card template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #1 from Jonathan Druart --- This is even worst with strict_sql_modes turned on, the creation of a new template is impossible: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 [for Statement "INSERT INTO creator_templates (`creator`, `label_height`, `top_margin`, `units`, `col_gap`, `row_gap`, `left_text_margin`, `rows`, `page_height`, `template_code`, `top_text_margin`, `label_width`, `left_margin`, `cols`, `profile_id`, `page_width`, `template_desc`) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);" with ParamValues: 0='Patroncards', 1="0", 2="0", 3="POINT", 4="0", 5="0", 6=0, 7="0", 8="0", 9="DEFAULT TEMPLATE", 10=0, 11="0", 12="0", 13="0", 14='', 15="0", 16="Default description"] at /kohadevbox/koha/C4/Creators/Template.pm line 199. Database returned the following error: Incorrect integer value: '' for column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm line 201. There is a logic issue in the controller, the printer profile list is not passed to the template (only passed when editing). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
