[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Joy Nelson changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||j...@bywatersolutions.com Resolution|--- |FIXED --- Comment #19 from Joy Nelson --- Enhancement not backported to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #18 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_target|Manual, ||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #17 from Katrin Fischer --- I feel styling could be a little improved for the message in general, but that's outside of scope here. Works well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Attachment #97402|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 97605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97605=edit Bug 24008: Remove minus sign when displaying credit value Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Attachment #97401|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 97604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97604=edit Bug 24008: Display warnings in a list Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Attachment #97400|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 97603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97603=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #13 from Martin Renvoize --- Works well, signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Attachment #96142|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 97401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97401=edit Bug 24008: Display warnings in a list Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Attachment #96604|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 97402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97402=edit Bug 24008: Remove minus sign when displaying credit value Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Attachment #95924|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 97400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97400=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #9 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #8) > Note sure it is expected, but if you have a credit of 5 and a debit of 5, > the patron deletion is blocked. It is expected. Unless AccountAutoReconcile is set or reconcile_balance.pl run, this situations can happen. And credits need to be applied manually. So technically, there's credit on their account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #8 from Jonathan Druart --- Note sure it is expected, but if you have a credit of 5 and a debit of 5, the patron deletion is blocked. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #7 from Jonathan Druart --- Created attachment 96604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96604=edit Bug 24008: Remove minus sign when displaying credit value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #6 from Martin Renvoize --- I think it's clearer as a positive amount personally.. it's a 'credit' so it's already identified as such in the sentence rather than needing to state the sign. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #4 from Jonathan Druart --- Created attachment 96142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96142=edit Bug 24008: Display warnings in a list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #5 from Jonathan Druart --- (In reply to Katrin Fischer from comment #3) > Functionally this works well, but I wonder if we could improve the text a > bit: > > Patron has 1 hold(s). Deleting patron cancels all their holds. > > Are you sure you want to delete the patron Nicole Schneider? This cannot be > undone. > Patron has a -9.00 credit. > > So now we have one warning on top (holds) an done below. I think that's not > ideal for usability. It would be nicer to display them all together, maybe > as a list? Done. > Also, should we remove the minus? Maybe, no idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #3 from Katrin Fischer --- Functionally this works well, but I wonder if we could improve the text a bit: Patron has 1 hold(s). Deleting patron cancels all their holds. Are you sure you want to delete the patron Nicole Schneider? This cannot be undone. Patron has a -9.00 credit. So now we have one warning on top (holds) an done below. I think that's not ideal for usability. It would be nicer to display them all together, maybe as a list? Also, should we remove the minus? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #2 from Jonathan Druart --- Created attachment 95924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95924=edit Bug 24008: Display a warning message when deleting a patron with outstanding credits So far nothing is displayed if a librarian removes patron with outstanding credits. Note that outstanding debits blocks the deletion. Test plan: - Create a patron with outstanding credit - Create a patron with outstanding debits - Delete the 2 patrons => With credit - You get a warning but do not block the deletion => With debits - You get a warning message that blocks the deletion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer changed: What|Removed |Added Summary|Attempting to delete a |Attempting to delete a |patron with outstanding |patron with outstanding |credits should warn and |credits should warn and |block the deletion. |block the deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #1 from Katrin Fischer --- I think we should think if this should block or only warn - holds warn, fines block currently. I could see a credit warning, but not blocking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize changed: What|Removed |Added Summary|No warning is produced when |Attempting to delete a |trying to delete a patron |patron with outstanding |with credit (patron is not |credits should warn and |deleted)|block the deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
