[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What|Removed |Added Version(s)|19.11.00|19.11.00, 19.05.12 released in|| Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #14 from Victor Grousset/tuxayo --- Backported to 19.05.x branch for 19.05.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What|Removed |Added Status|Pushed to stable|Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to master|Pushed to stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Jonathan Druart changed: What|Removed |Added Blocks||25551 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #13 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||19.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #12 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #11) > Tric with the sub in gen_default has a slight hacky nature, but ok ;) I do not see it hacky but flexible however :) Any suggestions to improve it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #11 from Marcel de Rooy --- Tric with the sub in gen_default has a slight hacky nature, but ok ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy changed: What|Removed |Added Attachment #95541|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy changed: What|Removed |Added Attachment #95543|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 95550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95550&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy changed: What|Removed |Added Attachment #95542|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 95549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95549&action=edit Bug 24062: Fix the failing test Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #8 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize --- Nice fix, works as expected.. thanks Jonathan. Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Attachment #95526|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 95543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95543&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Keywords||rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Attachment #95524|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 95541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95541&action=edit Bug 24062: [DO NOT PUSH] Proof Only apply this patch and confirm the assumption is correct (test was failing because X was generated for the patron category's type) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize changed: What|Removed |Added Attachment #95525|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 95542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95542&action=edit Bug 24062: Fix the failing test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #1 from Jonathan Druart --- Created attachment 95524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95524&action=edit Bug 24062: [DO NOT PUSH] Proof Only apply this patch and confirm the assumption is correct (test was failing because X was generated for the patron category's type) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #2 from Jonathan Druart --- Created attachment 95525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95525&action=edit Bug 24062: Fix the failing test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #3 from Jonathan Druart --- Created attachment 95526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95526&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Jonathan Druart changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl, ||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
