[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #36 from Katrin Fischer  ---
Created attachment 116903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116903=edit
Bug 24108: (QA follow-up) Add staff detail page to syspref description

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #35 from Katrin Fischer  ---
Created attachment 116902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116902=edit
Bug 24108: (QA follow-up) Add missing comma in sysprefs.sql

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115359|0   |1
is obsolete||

--- Comment #34 from Katrin Fischer  ---
Created attachment 116901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116901=edit
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be
'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115358|0   |1
is obsolete||

--- Comment #33 from Katrin Fischer  ---
Created attachment 116900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116900=edit
Bug 24108: (QA follow-up) Adjust wording and use perl for update file

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115357|0   |1
is obsolete||

--- Comment #32 from Katrin Fischer  ---
Created attachment 116899
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116899=edit
Bug 24108: (follow-up) Fix typo with .xml extension

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #115356|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 116898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116898=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-02-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Trivial patch   |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

  Text to go in the|This enhancement lets you   |This enhancement lets you
  release notes|choose how a record is  |choose how a record is
   |named when saving it as a   |named when saving it as a
   |MARC or MARCXML file using  |MARC or MARCXML file using
   |the advanced cataloguing|the advanced cataloguing
   |editor. 
   |editor.
   |
   |
   |Using the new   |Using the new
   |system system preference|system system preference
   |"SaveRecordbyControlNumber" |"DefaultSaveRecordFileID"
   |you can choose:
|choose:
   |- the   |- the bibliographic
   |bibliographic record number |record number (the
   |(the default), or
  |default): the file is saved
   |- the   |as
   |control number (001 field). |bib-{biblionumber}.{format}
   |
   |, or
   |If the record does not yet  |- the control number
   |have a bibliographic record |(001 field): the file is
   |number, it is saved as  |saved as as
   |record.mrc or record.xml.   |record-{controlnumber}.{for
   ||mat}.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Attachment #115038|0   |1
is obsolete||

--- Comment #30 from David Nind  ---
Created attachment 115359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115359=edit
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be
'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Attachment #115035|0   |1
is obsolete||

--- Comment #29 from David Nind  ---
Created attachment 115358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115358=edit
Bug 24108: (QA follow-up) Adjust wording and use perl for update file

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Attachment #115034|0   |1
is obsolete||

--- Comment #28 from David Nind  ---
Created attachment 115357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115357=edit
Bug 24108: (follow-up) Fix typo with .xml extension

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Attachment #115033|0   |1
is obsolete||

--- Comment #27 from David Nind  ---
Created attachment 115356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115356=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Nick Clemens  changed:

   What|Removed |Added

 Attachment #115036|0   |1
is obsolete||

--- Comment #26 from Nick Clemens  ---
Created attachment 115038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115038=edit
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be
'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #25 from Nick Clemens  ---
I got a bit carried away here, I intended just to implement David's wording
changes, but I think we should be consistent when saving either in the editor
or on the details page - I also think the syspref could be a bit more explicit
in the naming and options.

Please either sign-off, or feel free to obsolete my patches and throw back for
another QA opinion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #24 from Nick Clemens  ---
Created attachment 115036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115036=edit
Bug 24108: Make export file names consistent

This patch renames the systempreference to be a bit clearer and uses
explicit options rather than a yes/no

Additionally it standardizes the export from the advanced cataloging editor
with that from the details page

To test:
 1 - Apply patches
 2 - Update database and restart all the things
 3 - Open a record in the advanced editor and save it as marc and xml
 4 - Note the file name is 'bib-{biblionumber.{format}'
 5 - Edit the syspref 'DefaultSaveRecordFileID' to be control number
 6 - Repeate 3-4 on a record with and without a control number
 7 - If control number present fiule name should be
'record-{controlnumber}.{format}'
 8 - Otherwise it should be as above
 9 - Repeat tests from the details page of a record
10 - Repeat tests from the opac details page of a record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #23 from Nick Clemens  ---
Created attachment 115035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115035=edit
Bug 24108: (QA follow-up) Adjust wording and use perl for update file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #22 from Nick Clemens  ---
Created attachment 115034
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115034=edit
Bug 24108: (follow-up) Fix typo with .xml extension

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Nick Clemens  changed:

   What|Removed |Added

 Attachment #114243|0   |1
is obsolete||
 Attachment #114244|0   |1
is obsolete||

--- Comment #21 from Nick Clemens  ---
Created attachment 115033
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115033=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2021-01-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement lets you
  release notes||choose how a record is
   ||named when saving it as a
   ||MARC or MARCXML file using
   ||the advanced cataloguing
   ||editor.
   ||
   ||Using the new
   ||system system preference
   ||"SaveRecordbyControlNumber"
   ||you can choose:
   ||- the
   ||bibliographic record number
   ||(the default), or
   ||- the
   ||control number (001 field).
   ||
   ||If the record does not yet
   ||have a bibliographic record
   ||number, it is saved as
   ||record.mrc or record.xml.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #20 from David Nind  ---
I've signed off, but I think the system preference description needs some
changes.

My suggestion for the system preference description:

When saving a record to a MARC or MARCXML file in the advanced cataloging
editor, use the [bibliographic record number|control number] in the file name.
The default is to use the bibliographic record number. 

Notes:
- An alternative could be to use 'record number', rather than 'bibliographic
record number' to make a bit shorter if desired.
- The system preference for enabling the advanced cataloguing editor doesn't
use Rancor, so I would removed that and use the same terminology used in 
EnableAdvancedCatalogingEditor.
- The drop down list for choosing the option should just be the text in lower
case, and not include the "Save by...".
- See the terminology list (don't use biblio, use bibliographic record):
https://wiki.koha-community.org/wiki/Terminology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #19 from David Nind  ---
Created attachment 114244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114244=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Fix typo with .xml extension

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Attachment #114081|0   |1
is obsolete||
 Attachment #114082|0   |1
is obsolete||

--- Comment #18 from David Nind  ---
Created attachment 114243
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114243=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #17 from Cori Lynn Arnold  ---
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Updates based on QA feedback:
1. If the biblionumber is not set (not yet in the system) default to save to
"record.mrc" and "record.xml", emulating the old behavior.
2. Lowercase "control number" and "biblionumber" in description.
3. Better system preference description.

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #114081|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #114081|0   |1
is obsolete||

--- Comment #16 from Cori Lynn Arnold  ---
Created attachment 114082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114082=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Fix typo with .xml extension

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #101384|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #101382|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Attachment #101381|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

--- Comment #15 from Cori Lynn Arnold  ---
Created attachment 114081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114081=edit
Bug 24108: Advanced editor: configure if biblionumber or control number is used
for saved files

Creates a new system preference "SaveRecordbyControlNumber" which is
initially set to 0 (off/no). By default saving .mrc (and .xml) will be
saved by the biblionumber. If the record does not yet have a biblionumber,
the record will be saved as record.mrc or record.xml

Test plan:
1)  Apply the patch, flush_memcached and restart_all
2)  Enable the "EnableAdvancedCatalogingEditor" system preference
4)  Save the record using the drop down box selecting "Save as MARC (.mrc)
file.
5)  Note that the file saved is the same as the biblionumber at the top of
the Advanced Editor interface.
6)  Repeat steps 3-5 for the .xml save option
7)  Update the new system preference "SaveRecordbyControlNumber" and
change to "Save by ControlNumber"
8)  Verify that there is not a 001 field in the record (delete it if
 there is)
9)  Repeat steps 3-5 for both .mrc and .xml options (the file should still
be saved as the biblionumber if there is no control field)
10) Add a 001 field to the record such as "001  abc00012345"
11) Repeat step 4 for both .mrc and .xml and verify that the files
saved are named abc00012345.mrc and abc00012345.xml
12) Sign off!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-12-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Cori Lynn Arnold  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #101069|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

Summary|Advanced Editor: Save .mrc  |Advanced editor: configure
   |save with a configurable|if biblionumber or control
   |value   |number is used for saved
   ||files
 CC||katrin.fisc...@bsz-bw.de

--- Comment #14 from Katrin Fischer  ---
Hi Cori,

i added 2 follow-ups:
- A fix for the capitalization in your pref description (this would be a QA
blocker)
- A suggestion for rephrasing it - I think it might be easier to understand
(hopefully).

There is still a blocker for me. If 001/biblionumer (for a new record) is
missing, we now get .mrc or .xml as file name. Before there was record.mrc
record.xml. I think we should keep this behaviour - a fallback for missing
values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24108] Advanced editor: configure if biblionumber or control number is used for saved files

2020-03-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/