[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Aude Charillon changed: What|Removed |Added Resolution|--- |FIXED Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/666 Status|Needs documenting |RESOLVED --- Comment #114 from Aude Charillon --- New system preferences and information about Bcrypt settings added to the manual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Aude Charillon changed: What|Removed |Added Status|CLOSED |Needs documenting Documentation||Aude Charillon contact|| CC||aude.charillon@ptfs-europe. ||com Resolution|FIXED |--- --- Comment #113 from Aude Charillon --- Re-opening just for documentation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32441 [Bug 32441] Localuse is recorded in statistics but not recreated in pseudonymized_transactions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32440 [Bug 32440] Allow selective deletion of statistics entries based on type by cleanup_database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32439 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32439 [Bug 32439] Allow selective deletion of statistics entries based on type by cleanup_database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||32438 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32438 [Bug 32438] Pseudonymized_transactions should include payments and writeoffs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Blocks||29341 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29341 [Bug 29341] If OpacRenewalBranch = opacrenew, pseudonymization process leads to "internal server error" when patrons renew the loans at OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Blocks||28912 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28912 [Bug 28912] Pseudonymization should display a nice error message when brcypt_settings are not defined -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Nick Clemens changed: What|Removed |Added Blocks||28911 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 [Bug 28911] Bcrypt settings are required for pseudonymization but are not set on upgrade -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Janet McGowan changed: What|Removed |Added CC||janet.mcgowan@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Katrin Fischer changed: What|Removed |Added Text to go in the|This new feature adds a way |This new feature adds a way release notes|to pseudonymize patron's|to pseudonymize patron |data, in a way they could |data, in a way that it will |not be personally |not be able to identify the |identifiable. |person |https://en.wikipedia.org/wi |(https://en.wikipedia.org/w |ki/Pseudonymization |iki/Pseudonymization) | | |There |There are different |are different existing way |existing ways to anonymize |to anonymize patron's |patron information in |information in |Koha, |Koha, but we|but by removing information |loose the ability to make |we loose the ability to |useful report. |make useful reports. |This| |development introduces two |This |new tables: |development introduces two | * 1 for |new tables: |transactions and patrons| * |data|pseudonymized_transactions |(pseudonymized_transactions |for transactions and patron |) |data | * 1 for patrons' | * |attributes |pseudonymized_borrower_attr |(pseudonymized_borrower_att |ibutesfor patron attributes |ributes) | |Entries to |Entries to |pseudonymized_transactions |pseudonymized_transactions |are added when a new|are added when a new |transaction (checkout, |transaction (checkout, |checkin, renew, on-site |checkin, renew, on-site |checkout) is done. |checkout) is done. |Also, |The |anonymized_borrower_attribu |table |tes is populated if |anonymized_borrower_attribu |patron's attributes are |tes is populated if patron |marked as "keep for |attributes are marked as |pseudonymization". |"keep for | |pseudonymization". |To make | |things configurable, three |To make |sysprefs have been added: |things configurable, three ||system preferences have |* syspref Pseudonymization |been added: |to turn on/off the whole| * |feature |Pseudonymization to turn | * syspref |on/off the whole feature |PseudonymizationPatronField | |s to list the informations |* |of the patrons to |PseudonymizationPatronField |synchronize |s to list the information | * syspref |of the patrons to |PseudonymizationTransaction |synchronize |Fields to list the | * |informations of the |PseudonymizationTransaction |transactions to copy|Fields to list the ||information of the ||transactions to copy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| Text to go in the||This new feature adds a way release notes||to pseudonymize patron's ||data, in a way they could ||not be personally ||identifiable. ||https://en.wikipedia.org/wi ||ki/Pseudonymization || ||There ||are different existing way ||to anonymize patron's ||information in ||Koha, but we ||loose the ability to make ||useful report. ||This ||development introduces two ||new tables: || * 1 for ||transactions and patrons ||data ||(pseudonymized_transactions ||) || * 1 for patrons' ||attributes ||(pseudonymized_borrower_att ||ributes) ||Entries to ||pseudonymized_transactions ||are added when a new ||transaction (checkout, ||checkin, renew, on-site ||checkout) is done. ||Also, ||anonymized_borrower_attribu ||tes is populated if ||patron's attributes are ||marked as "keep for ||pseudonymization". || ||To make ||things configurable, three ||sysprefs have been added: || ||* syspref Pseudonymization ||to turn on/off the whole ||feature || * syspref ||PseudonymizationPatronField ||s to list the informations ||of the patrons to ||synchronize || * syspref ||PseudonymizationTransaction ||Fields to list the ||informations of the ||transactions to copy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com --- Comment #112 from Arthur Suzuki --- *** Bug 26315 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #111 from Lucas Gass --- Not backporting enhancement to 20.05.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #110 from Jonathan Druart --- (In reply to Jonathan Druart from comment #109) > Created attachment 107225 [details] [review] > Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' I missed half of the job in the first patch! Pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #109 from Jonathan Druart --- Created attachment 107225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107225=edit Bug 24151: (follow-up) Rename the config key with 'bcrypt_settings' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #108 from Jonathan Druart --- Follow-up pushed to master for 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #107 from Jonathan Druart --- Created attachment 107127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107127=edit Bug 24151: Use fully qualified names for UpdateStats t/db_dependent/Koha/Account/Line.t .. 8/12 # Looks like you planned 16 tests but ran 3. # Failed test 'void() tests' # at t/db_dependent/Koha/Account/Line.t line 723. Undefined subroutine ::Account::UpdateStats called at /kohadevbox/koha/Koha/Account.pm line 289. It's certainly caused by a circ dep from commit 5ce968e0e571f555261c02a9e1d27447611cdb89 Bug 24151: Copy info to the pseudonymized table when a transaction is done See also bug 17600 for more context. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #106 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #105 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #100) > Marcel, the sed part needs to be there, otherwise I get "bad bcrypt > settings". > POD says "It must begin with "$2", optional "a", "$", two digits, "$", and > 22 base 64 digits", then "The function will die if SETTINGS does not have > this format." OK Seems that for long nobody cared about this module. This is a ticket for supporting $2y from 2014: https://rt.cpan.org/Public/Bug/Display.html?id=93688 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #104 from David Cook --- (In reply to Jonathan Druart from comment #103) > As I said previously it could be reused for other features. I don't think it > should be tight to the "anonymization" feature. I suppose. If other features wanted to deviate, then the onus could be on them to create a new setting. Yeah, ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #103 from Jonathan Druart --- As I said previously it could be reused for other features. I don't think it should be tight to the "anonymization" feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #102 from David Cook --- Oh I just want to say thanks for this. Very useful functionality! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #101 from David Cook --- (In reply to Jonathan Druart from comment #100) > I have renamed the config entry with "bcrypt_settings". > Awesome. I was scratching my head wondering why it was called "key". I think "bcrypt_settings" is much better, although within the context of koha-conf.xml that is a bit too generic I think. It might be better to have it be something like "anonymizer_bcrypt_settings". But that could just be me splitting hairs. My French teacher used to say something like "Ne coupons pas les cheveux en quatre, David." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #100 from Jonathan Druart --- I have renamed the config entry with "bcrypt_settings". Marcel, the sed part needs to be there, otherwise I get "bad bcrypt settings". POD says "It must begin with "$2", optional "a", "$", two digits, "$", and 22 base 64 digits", then "The function will die if SETTINGS does not have this format." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #99 from Jonathan Druart --- Created attachment 106255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106255=edit Bug 24151: Rename the config key with 'bcrypt_settings' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #98 from Julian Maurice --- (In reply to Jonathan Druart from comment #97) > (In reply to Julian Maurice from comment #96) > > (In reply to Jonathan Druart from comment #95) > > > Tomas suggested me "encryption_key", would it work for you? > > > > Another suggestion: since it seems to be a bcrypt settings string related to > > pseudonymization, why not "pseudonymization_bcrypt_settings" ? :) > > I think this setting could be reuse for other uses, and so the naming should > not be too specific. Can it be something else than a bcrypt settings string ? If not, I think we should have these words (bcrypt, settings) in the config variable name, it will probably easier to search "koha bcrypt settings" than "koha key" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #97 from Jonathan Druart --- (In reply to Julian Maurice from comment #96) > (In reply to Jonathan Druart from comment #95) > > Tomas suggested me "encryption_key", would it work for you? > > Another suggestion: since it seems to be a bcrypt settings string related to > pseudonymization, why not "pseudonymization_bcrypt_settings" ? :) I think this setting could be reuse for other uses, and so the naming should not be too specific. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #96 from Julian Maurice --- (In reply to Jonathan Druart from comment #95) > Tomas suggested me "encryption_key", would it work for you? Another suggestion: since it seems to be a bcrypt settings string related to pseudonymization, why not "pseudonymization_bcrypt_settings" ? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #95 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #94) > > > $2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 > > > BAD choice for a new config variable! What is key? Where is it used for? > > > Please add pseudonymize or something ? > > > > We could, but the point of the generic wording was to make it use for > > something else, if needed. It could be better named "secret_key". > > No blocker, but I prefer a more specific name. Using keys for several > purposes may not always be so handy. 'key' is really too generic. Tomas suggested me "encryption_key", would it work for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #94 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #93) > (In reply to Marcel de Rooy from comment #90) > > my $attributes = > > Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')- > > >search({transaction_id => $p->id }); > > So no Koha objects here but DBIx ? > > It's only used in test file. In pm file it's using create_related. > 97 > $self->_result->create_related('pseudonymized_borrower_attributes', > $attribute); > > I don't think it is worth creating a new module only for that purpose. Agreed. > > $(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'); > > Why do you change $2y to $2a ? > > If I understand correctly, $2y signals use of a safer updated algorithm. > > Good question. I remember I first used some methods from Koha::AuthUtils, > where we hardcode $2a. I guess it comes from there and so the replacement > should be removed. I will investigate a bit further. I would be inclined to remove the sed statement here. > > $2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 > > BAD choice for a new config variable! What is key? Where is it used for? > > Please add pseudonymize or something ? > > We could, but the point of the generic wording was to make it use for > something else, if needed. It could be better named "secret_key". No blocker, but I prefer a more specific name. Using keys for several purposes may not always be so handy. 'key' is really too generic. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #93 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #90) > Looks good to me, some additional comments: Thanks Marcel. > t/db_dependent/Koha/Pseudonymization.t > Please add test descriptions. This is a good habit. If we dont do it now, we > will not. > # Subtest: Config does not exist > ok 2 > # Subtest: Koha::Anonymized::Transactions tests > ok 3 > ok 4 > ok 5 > ok 6 > ok 7 > ok 8 > ok 9 > ok 10 > ok 11 > ok 12 Indeed, fixed. > $values->{branchcode} = $patron->branchcode; # FIXME Must be removed from > the pref options, or FK removed (?) > Adding a FIXME ! I have to admit I cannot remember what is the meaning of this FIXME. It seems to make sense to record the patron's library (?) > my $attributes = > Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')- > >search({transaction_id => $p->id }); > So no Koha objects here but DBIx ? It's only used in test file. In pm file it's using create_related. 97 $self->_result->create_related('pseudonymized_borrower_attributes', $attribute); I don't think it is worth creating a new module only for that purpose. > $(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'); > Why do you change $2y to $2a ? > If I understand correctly, $2y signals use of a safer updated algorithm. Good question. I remember I first used some methods from Koha::AuthUtils, where we hardcode $2a. I guess it comes from there and so the replacement should be removed. I will investigate a bit further. > $2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 > BAD choice for a new config variable! What is key? Where is it used for? > Please add pseudonymize or something ? We could, but the point of the generic wording was to make it use for something else, if needed. It could be better named "secret_key". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #92 from Jonathan Druart --- Created attachment 106195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106195=edit Bug 24151: Add description for tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #91 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #90) > In general: We are filling these tables with transactions? Are we going to > keep them indefinitely? What are the plans for cleanup etc.? This could be a > large table in no time. OK I see a follow-up for purging now ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #90 from Marcel de Rooy --- Looks good to me, some additional comments: t/db_dependent/Koha/Pseudonymization.t Please add test descriptions. This is a good habit. If we dont do it now, we will not. # Subtest: Config does not exist ok 2 # Subtest: Koha::Anonymized::Transactions tests ok 3 ok 4 ok 5 ok 6 ok 7 ok 8 ok 9 ok 10 ok 11 ok 12 $values->{branchcode} = $patron->branchcode; # FIXME Must be removed from the pref options, or FK removed (?) Adding a FIXME ! my $attributes = Koha::Database->new->schema->resultset('PseudonymizedBorrowerAttribute')->search({transaction_id => $p->id }); So no Koha objects here but DBIx ? $(htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/'); Why do you change $2y to $2a ? If I understand correctly, $2y signals use of a safer updated algorithm. $2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 BAD choice for a new config variable! What is key? Where is it used for? Please add pseudonymize or something ? In general: We are filling these tables with transactions? Are we going to keep them indefinitely? What are the plans for cleanup etc.? This could be a large table in no time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #87 from Marcel de Rooy --- Created attachment 106047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106047=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105813|0 |1 is obsolete|| --- Comment #84 from Marcel de Rooy --- Created attachment 106044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106044=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #89 from Marcel de Rooy --- Created attachment 106049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106049=edit Bug 24151: (QA follow-up) Fix POD warnings from QA tools POD is missing for get_hash POD is missing for new_from_statistic POD is missing for 'object_class' Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105814|0 |1 is obsolete|| --- Comment #85 from Marcel de Rooy --- Created attachment 106045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106045=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #88 from Marcel de Rooy --- Created attachment 106048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106048=edit Bug 24151: (QA follow-up) Correct license in two modules Still listing the address.. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105815|0 |1 is obsolete|| --- Comment #86 from Marcel de Rooy --- Created attachment 106046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106046=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105808|0 |1 is obsolete|| --- Comment #79 from Marcel de Rooy --- Created attachment 106039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106039=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105810|0 |1 is obsolete|| --- Comment #81 from Marcel de Rooy --- Created attachment 106041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106041=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105811|0 |1 is obsolete|| --- Comment #82 from Marcel de Rooy --- Created attachment 106042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106042=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105809|0 |1 is obsolete|| --- Comment #80 from Marcel de Rooy --- Created attachment 106040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106040=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #83 from Marcel de Rooy --- Created attachment 106043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106043=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105807|0 |1 is obsolete|| --- Comment #78 from Marcel de Rooy --- Created attachment 106038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106038=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105804|0 |1 is obsolete|| --- Comment #75 from Marcel de Rooy --- Created attachment 106035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106035=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105806|0 |1 is obsolete|| --- Comment #77 from Marcel de Rooy --- Created attachment 106037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106037=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105805|0 |1 is obsolete|| --- Comment #76 from Marcel de Rooy --- Created attachment 106036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106036=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105803|0 |1 is obsolete|| --- Comment #74 from Marcel de Rooy --- Created attachment 106034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106034=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105801|0 |1 is obsolete|| --- Comment #72 from Marcel de Rooy --- Created attachment 106032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106032=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Attachment #105802|0 |1 is obsolete|| Attachment #105812|0 |1 is obsolete|| Attachment #105816|0 |1 is obsolete|| --- Comment #73 from Marcel de Rooy --- Created attachment 106033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106033=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #71 from Marcel de Rooy --- Looking here now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added URL|https://gitlab.com/joubu/Ko | |ha/commits/bug_24151| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #70 from Jonathan Druart --- Created attachment 105816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105816=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #66 from Jonathan Druart --- Created attachment 105812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105812=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #69 from Jonathan Druart --- Created attachment 105815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105815=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #68 from Jonathan Druart --- Created attachment 105814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105814=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #67 from Jonathan Druart --- Created attachment 105813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105813=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #64 from Jonathan Druart --- Created attachment 105810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105810=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #63 from Jonathan Druart --- Created attachment 105809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105809=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #65 from Jonathan Druart --- Created attachment 105811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105811=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #62 from Jonathan Druart --- Created attachment 105808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105808=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #60 from Jonathan Druart --- Created attachment 105806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105806=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #61 from Jonathan Druart --- Created attachment 105807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105807=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #58 from Jonathan Druart --- Created attachment 105804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105804=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #57 from Jonathan Druart --- Created attachment 105803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105803=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #59 from Jonathan Druart --- Created attachment 105805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105805=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #56 from Jonathan Druart --- Created attachment 105802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105802=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Attachment #101034|0 |1 is obsolete|| Attachment #101035|0 |1 is obsolete|| Attachment #101036|0 |1 is obsolete|| Attachment #101037|0 |1 is obsolete|| Attachment #101038|0 |1 is obsolete|| Attachment #101039|0 |1 is obsolete|| Attachment #101040|0 |1 is obsolete|| Attachment #101041|0 |1 is obsolete|| Attachment #101042|0 |1 is obsolete|| Attachment #101043|0 |1 is obsolete|| Attachment #101044|0 |1 is obsolete|| Attachment #101045|0 |1 is obsolete|| Attachment #101046|0 |1 is obsolete|| Attachment #101047|0 |1 is obsolete|| Attachment #101048|0 |1 is obsolete|| Attachment #101049|0 |1 is obsolete|| --- Comment #55 from Jonathan Druart --- Created attachment 105801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105801=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|Signed Off |Patch doesn't apply --- Comment #54 from Julian Maurice --- Does not apply on master. Can you rebase please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Blocks||18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #50 from Jonathan Druart --- Created attachment 101046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101046=edit Bug 24151: Add boolean flag for has_cardnumber Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #49 from Jonathan Druart --- Created attachment 101045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101045=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #51 from Jonathan Druart --- Created attachment 101047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101047=edit Bug 24151: Fix location on return The item's location where not passed to UpdateStat Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #52 from Jonathan Druart --- Created attachment 101048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101048=edit Bug 24151: Add items.homebranch to the list Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #53 from Jonathan Druart --- Created attachment 101049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101049=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #47 from Jonathan Druart --- Created attachment 101043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101043=edit Bug 24151: Adding keep_for_anonymized to the UI Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #45 from Jonathan Druart --- Created attachment 101041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101041=edit Bug 24151: DB changes - pseudonymized_borrower_attributes Add a new DB table pseudonymized_borrower_attributes Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #48 from Jonathan Druart --- Created attachment 101044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101044=edit Bug 24151: Sync patron's attributes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #46 from Jonathan Druart --- Created attachment 101042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101042=edit Bug 24151: Add new column borrower_attribute_types.keep_for_pseudonymization Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #43 from Jonathan Druart --- Created attachment 101039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101039=edit Bug 24151: Add warning to the about page if key is missing in the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #44 from Jonathan Druart --- Created attachment 101040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101040=edit Bug 24151: Add key to the config Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #41 from Jonathan Druart --- Created attachment 101037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101037=edit Bug 24151: Add tests Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #40 from Jonathan Druart --- Created attachment 101036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101036=edit Bug 24151: Copy info to the pseudonymized table when a transaction is done This is the commit where you will find useful information about this development. The goal of this new feature is to add a way to pseudonymize patron's data, in a way they could not be personally identifiable. https://en.wikipedia.org/wiki/Pseudonymization There are different existing way to anonymize patron's information in Koha, but we loose the ability to make useful report. This development proposes to have 2 different tables: * 1 for transactions and patrons data (pseudonymized_transactions) * 1 for patrons' attributes (pseudonymized_borrower_attributes) Entries to pseudonymized_transactions are added when a new transaction (checkout, checkin, renew, on-site checkout) is done. Also, anonymized_borrower_attributes is populated if patron's attributes are marked as "keep for pseudonymization". To make those informations not identifiable to a patron, we are having a hashed_borrowernumber column in pseudonymized_transactions. This hash will be generated (Blowfish-based crypt) using a key stored in the Koha configuration. To make things configurable, we are adding 3 sysprefs and 1 new DB column: * syspref Pseudonymization to turn on/off the whole feature * syspref PseudonymizationPatronFields to list the informations of the patrons to sync * syspref PseudonymizationTransactionFields to list the informations of the transactions to copy * DB column borrower_attribute_types.keep_for_pseudonymization that is a boolean to enable/disable the copy of a given patron's attribute type. Test plan: 1/ Turn on Pseudonymization 2/ Define in PseudonymizationPatronFields and PseudonymizationTransactionFields the different fields you want to copy 3/ Go to the about page => You will see a warning about a missing config entry 4/ You need to generate a key and put it in the koha-conf.xml file. The following command will generate one: % htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' Then edit $KOHA_CONF and add it before of the end of the config section ($2a$10$PfdrEBdRcL2MZlEtKueyLegxI6zg735jD07GRnc1bt.N/ZYMvBAB2 5/ Restart memcached then plack (alias restart_all) => Everything is setup! 6/ Create a new transaction (checkin for instance) => Confirm that a new entry has been added to pseudonymized_transaction with the data you expect to be copied 7/ Edit some patron attribute types and tick "Keep for pseudonymization" 8/ Create a new transaction => Confirm that new entries have been added to pseudonymized_borrower_attributes 11/ Delete the patrons => Confirm that the entries still exist in the pseudonymized_* tables 12/ Purge the patrons (ie. use cleanup_database.pl to remove them from the deleted_borrowers table) => Confirm that the entries still exist in the pseudonymized_* tables See bug 24152 to remove data from the anonymized_* tables Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #42 from Jonathan Druart --- Created attachment 101038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101038=edit Bug 24151: Add tests - if config does not exist Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #39 from Jonathan Druart --- Created attachment 101035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101035=edit Bug 24151: DBIC changes Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #38 from Jonathan Druart --- Created attachment 101034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101034=edit Bug 24151: DB changes 1 new table: * pseudonymized_transactions 3 new sysprefs: * Pseudonymization * PseudonymizationPatronFields * PseudonymizationTransactionFields Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Signed-off-by: Sonia Bouis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Koha Team University Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr Status|Needs Signoff |Signed Off --- Comment #37 from Koha Team University Lyon 3 --- I've tested for Association KohaLa. I've followed the test plan and everything is Ok. I've played to check / uncheck borrowers/transaction information in the PseudonymizationPatronFields and PseudonymizationTransactionFields and data saved in the pseudonymized_transactions are consistent. I've also checked /unckecked "Keep for pseudonymization" for borrowers attributes and data in pseudonymized_borrower_attributes are also consistent. The data are keeped after deleting borrowers and cleaning deletedborrowers. Thank you for this job! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Attachment #97247|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Attachment #97246|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 --- Comment #36 from Jonathan Druart --- Up-to-date patches are on the remote branch: https://gitlab.com/joubu/Koha/commits/bug_24151 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24151] Add a pseudonymization process for patrons and transactions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24151 Jonathan Druart changed: What|Removed |Added Attachment #97242|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/