[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #27 from Joy Nelson  ---
not backported to 19.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #26 from Martin Renvoize  ---
Nice work everyone!

Pushed to master for 20.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Martin Renvoize  changed:

   What|Removed |Added

 Version(s)||20.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104252|0   |1
is obsolete||

--- Comment #25 from Katrin Fischer  ---
Created attachment 104341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104341=edit
Bug 24163: UTF-8 encode the output

Specify the UTF-8 charset in the header and Encode the output to avoid encoding
issues

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104192|0   |1
is obsolete||

--- Comment #23 from Katrin Fischer  ---
Created attachment 104339
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104339=edit
Bug 24163: (QA follow-up) Fix wordings

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #104193|0   |1
is obsolete||

--- Comment #24 from Katrin Fischer  ---
Created attachment 104340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104340=edit
Bug 24163: Add the new CSV profile to other installer files

export_format is not populated for other languages apparently...

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103586|0   |1
is obsolete||

--- Comment #22 from Katrin Fischer  ---
Created attachment 104338
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104338=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

Signed-off-by: Angela O'Connor Desmond


Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #103585|0   |1
is obsolete||

--- Comment #21 from Katrin Fischer  ---
Created attachment 104337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104337=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

Signed-off-by: Angela O'Connor Desmond


Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #20 from Jonathan Druart  
---
Sorry, just found local changes I had not embedded in the last patch!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #104194|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart  
---
Created attachment 104252
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104252=edit
Bug 24163: UTF-8 encode the output

Specify the UTF-8 charset in the header and Encode the output to avoid encoding
issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #18 from Katrin Fischer  ---
Hi Jonathan,

can you please retest? I am still seeing the same issue with diacritics and the
new CSV profiles. Checked twice I have the new patches, restart_all and the
Default CSV is working correct.

When I download the CSV and change the encoding form UTF-8 to Latin 3 (ISO
8859-3 ) in the import screen from LibreOffice, Zoë will display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #17 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #13)
> 1) Typo and rephrase
> 
> +For late orders exports you must provide a Template
> Toolkit syntax that will generate the whole CSV file..
> 
> I suggest a sight change here: 
> For exporting late orders you must provide a profile in Template Toolkit
> syntax to generate the CSV file.
> 
> Late orders (csv profile) => Late orders (CSV profile)
> default CSV export for late orders => Default ...

Fixed!

> 2) Other installers
> 
> Please add the profile to the other installer sample files as well.

Done!

> 3) Default
> 
> When you look at the pull down of the split button, it says "Default". Is
> the default different to the new template in significant ways? Wondering if
> we need to keep it or could replace it with the CSV profile. (question)

Yes it's different, the "Default" has:
ORDER DATE;ESTIMATED DELIVERY DATE;VENDOR;INFORMATION;TOTAL COST;BASKET;CLAIMS
COUNT;CLAIMED DATE;INTERNAL NOTE;VENDOR NOTE;ISBN

And has an additional line at the bottom:
;;"Total orders in late";1

When the new one has:
Title,Author,Publication year,ISBN,Quantity,Number of claims

I thought it was better to keep the default one (for those who use it), but we
can remove it if needed.

> 4) Diacritics / encoding
> 
> I was testing with our sample record: Typical girls? :
> Author: Howe, Zoë Street. 
> 
> The default is ok, but in the CSV profile export Zoë is broken.

Good catch, fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #15 from Jonathan Druart  
---
Created attachment 104193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104193=edit
Bug 24163: Add the new CSV profile to other installer files

export_format is not populated for other languages apparently...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #14 from Jonathan Druart  
---
Created attachment 104192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104192=edit
Bug 24163: (QA follow-up) Fix wordings

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #16 from Jonathan Druart  
---
Created attachment 104194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104194=edit
Bug 24163: Specify the UTF-8 charset in the header

To avoid encoding issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #13 from Katrin Fischer  ---
1) Typo and rephrase

+For late orders exports you must provide a Template
Toolkit syntax that will generate the whole CSV file..

I suggest a sight change here: 
For exporting late orders you must provide a profile in Template Toolkit syntax
to generate the CSV file.

Late orders (csv profile) => Late orders (CSV profile)
default CSV export for late orders => Default ...


2) Other installers

Please add the profile to the other installer sample files as well.


3) Default

When you look at the pull down of the split button, it says "Default". Is the
default different to the new template in significant ways? Wondering if we need
to keep it or could replace it with the CSV profile. (question)


4) Diacritics / encoding

I was testing with our sample record: Typical girls? :
Author: Howe, Zoë Street. 

The default is ok, but in the CSV profile export Zoë is broken.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #102258|0   |1
is obsolete||

--- Comment #12 from PTFS Europe Sandboxes  ---
Created attachment 103586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103586=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

Signed-off-by: Angela O'Connor Desmond


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

PTFS Europe Sandboxes  changed:

   What|Removed |Added

 Attachment #102257|0   |1
is obsolete||

--- Comment #11 from PTFS Europe Sandboxes  ---
Created attachment 103585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103585=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

Signed-off-by: Angela O'Connor Desmond


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

David Nind  changed:

   What|Removed |Added

 Attachment #102186|0   |1
is obsolete||

--- Comment #10 from David Nind  ---
Created attachment 102258
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102258=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

David Nind  changed:

   What|Removed |Added

 Attachment #102185|0   |1
is obsolete||

--- Comment #9 from David Nind  ---
Created attachment 102257
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102257=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #8 from Jonathan Druart  
---
Created attachment 102186
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102186=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #98691|0   |1
is obsolete||
  Attachment #98692|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 102185
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102185=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-03-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97122|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 98691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98691=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-02-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97123|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 98692
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98692=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||24161


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24161
[Bug 24161] Late orders improvements - keeping track of claims
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||24162
 Depends on|24162   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24162
[Bug 24162] Late orders improvements - display new columns
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #4 from Jonathan Druart  
---
Created attachment 97123
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97123=edit
Bug 24163: Add the csv into the DB - as an example

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #97120|0   |1
is obsolete||
  Attachment #97121|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 97122
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97122=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

Sponsored-by: Institute of Technology Tralee

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #2 from Jonathan Druart  
---
Created attachment 97121
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97121=edit
Bug 24163: Add the csv into the DB - as an example

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

--- Comment #1 from Jonathan Druart  
---
Created attachment 97120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97120=edit
Bug 24163: Allow to define CSV profile for late orders export

This new enhancement adds the ability to create a CSV profile for the late
orders export.
Prior to this, the CSV profile was hardcoded in a template and not
editable (unless you modify the .tt file of course).

The main difficulty of the request was to make the multiple claims dates
accessible from the CSV profile. So far we only accept columns from the
database. However we would like to use the Koha::Acquisition::Order
object to make things easier (it had a ->claims method to access the
different claims).
To acchieve this, we are going to accept the TT syntax for that CSV profile.
It means that only CSV profiles created for 'late_orders' will have the
capability to use the TT syntax (can be extended later of course if
needed).
The alternative was to use specific placeholders, like %claims_count%,
%claimed_date%, but it sounded more powerful and flexible to allow the
TT syntax instead.

Note that the former export (template based) still exists and is the
default option.

Test plan:
0. Apply the patches and execute the update database entry
1. Create some orders, close the basket
2. Claim some of the orders
3. Note the new button at the bottom of the table that have several
entries.
=> The first entry will generate a CSV file using the previous method
=> The second entry will generate it using the new CSV profile, note
that the number of claims as well as the different claims date are
displayed.

4. Bonus point: Edit the CSV profile (Home › Tools › CSV export
profiles) that is named "Late orders (csv profile)", or create a new
one, and modify it.
Export the late orders using this CSV profile and confirm that the
generated CSV file is the one you expect.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2020-01-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24163] Ability to define a CSV profile for late orders export

2019-12-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24163

Jonathan Druart  changed:

   What|Removed |Added

 CC||mark.gavillet@ptfs-europe.c
   ||om
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/