[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

--- Comment #7 from Katrin Fischer  ---
Created attachment 75348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75348=edit
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Version|rel_3_2 |master
   Assignee|gmcha...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
It appears the only remaining code for this permission has been changed since
and now also checks for another permission:


 66 [% IF ( CAN_user_management ||
CAN_user_editcatalogue_edit_catalogue ) %]
67 li
68 a class=toplinks
href=/cgi-bin/koha/circ/selectbranchprinter.plSet library/a
69 /li
70 [% END %]

Might be a good time to finally remove the permission?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||pasi.kalli...@pttk.fi

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
*** Bug 11776 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-04-25 
10:10:26 UTC ---
This is a real old bug. I don't think we have the permission 'management Set
library management parameters' in our granular permissions system that is now
standard.

Does the bug still exist or is it working correctly for IndependentBranches
now?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2426] Management Permissions Deprecated

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2426

--- Comment #4 from Owen Leonard oleon...@myacpl.org 2011-04-25 12:44:49 UTC 
---
The original question is still unanswered: How do we handle the permission to
set the branch when IndenpendantBranches is turned on:

strong[% LoginBranchname %]/strong
[% IF ( IndependantBranches ) %]
[% IF ( CAN_user_management ) %]
(a
href=/cgi-bin/koha/circ/selectbranchprinter.plSet/a)
[% END %]
[% ELSE %]
(a href=/cgi-bin/koha/circ/selectbranchprinter.plSet/a)
[% END %]

It sounds like gmcharlt proposed a new granular permission,
catalogue-setbranch. I'm not sure what atz meant by a psuedo permission, but
if any work followed from that it's probably locked up in LEK now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/