[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Blocks|22161 |22160 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22160 [Bug 22160] OMNIBUS: Transfers enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22161 [Bug 22161] Move C4::Circulation::transferbook and C4::Items::ModItemTransfer to Koha namespace -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Nick Clemens changed: What|Removed |Added Blocks||33761 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33761 [Bug 33761] Holds queue is not selecting items with completed transfers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Lucas Gass changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||lu...@bywatersolutions.com Resolution|--- |FIXED --- Comment #105 from Lucas Gass --- Enhancement won't be backported to the 22.05.x series -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #104 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #103 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #100) > Please QA this one or otherwise I will do it ;) Miracles happen :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #102 from Martin Renvoize --- Discussed with Tomas and he's happy for it to go PQA given it's had both Joonas's and my eyes on it. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #101 from Joonas Kylmälä --- FYI, patch "Bug 24295: Remove GetTransfers from opac-detail.pl" might become obsolete if bug 31313 follow-ups get pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #100 from Marcel de Rooy --- Please QA this one or otherwise I will do it ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #99 from Martin Renvoize --- Thanks for the rebase Joonas.. just confirming I'm happy with your updates and my testing shows it's all good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139558|0 |1 is obsolete|| --- Comment #98 from Martin Renvoize --- Created attachment 139667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139667=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139557|0 |1 is obsolete|| --- Comment #97 from Martin Renvoize --- Created attachment 139666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139666=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139556|0 |1 is obsolete|| --- Comment #96 from Martin Renvoize --- Created attachment 139665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139665=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139555|0 |1 is obsolete|| --- Comment #95 from Martin Renvoize --- Created attachment 139664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139664=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139554|0 |1 is obsolete|| --- Comment #94 from Martin Renvoize --- Created attachment 139663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139663=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139553|0 |1 is obsolete|| --- Comment #93 from Martin Renvoize --- Created attachment 139662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139662=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139552|0 |1 is obsolete|| --- Comment #92 from Martin Renvoize --- Created attachment 139661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139661=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139551|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 139660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139660=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139550|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 139659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139659=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139549|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 139658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139658=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates. Add missing Koha::Items module import. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139548|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 139657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139657=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139547|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 139656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139656=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #139546|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 139655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139655=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Victor Grousset/tuxayo changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #85 from Joonas Kylmälä --- *** Bug 30580 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #84 from Joonas Kylmälä --- Rebased the patches. In addition to the rebase I amended a couple minor fixes (left a comment on those patches): I noticed you had added output_pref() function call in some places but I didn't see it as needed as output_pref() is already called on the Template side via the $KohaDates filter, in fact some of the patches now were conflicting due to output_pref() calls being removed in the scripts in origin/master. So I removed the output_pref calls. Then there was a missing Koha::Items module import which I added. Signing off. Note to other testers: currently there is a regression in opac-detail.pl caused by bug 31313, see comment 16 there. This makes it harder to test the code change here as you would have to modify the item-status.inc code to fix the regression in order to be able to see the transfer status this patch touches on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #83 from Joonas Kylmälä --- Created attachment 139558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139558=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #82 from Joonas Kylmälä --- Created attachment 139557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139557=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #81 from Joonas Kylmälä --- Created attachment 139556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139556=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #80 from Joonas Kylmälä --- Created attachment 139555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139555=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #79 from Joonas Kylmälä --- Created attachment 139554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139554=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #78 from Joonas Kylmälä --- Created attachment 139553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139553=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #77 from Joonas Kylmälä --- Created attachment 139552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139552=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #76 from Joonas Kylmälä --- Created attachment 139551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139551=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #75 from Joonas Kylmälä --- Created attachment 139550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139550=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #74 from Joonas Kylmälä --- Created attachment 139549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139549=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates. Add missing Koha::Items module import. Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #73 from Joonas Kylmälä --- Created attachment 139548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139548=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 JK: Remove unneeded string formatting for transfertwhen as it's done on the template toolkit side already with $KohaDates Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #72 from Joonas Kylmälä --- Created attachment 139547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139547=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Joonas Kylmälä changed: What|Removed |Added Attachment #130430|0 |1 is obsolete|| Attachment #130431|0 |1 is obsolete|| Attachment #130432|0 |1 is obsolete|| Attachment #130433|0 |1 is obsolete|| Attachment #130434|0 |1 is obsolete|| Attachment #130435|0 |1 is obsolete|| Attachment #130436|0 |1 is obsolete|| Attachment #130437|0 |1 is obsolete|| Attachment #130438|0 |1 is obsolete|| Attachment #130439|0 |1 is obsolete|| Attachment #130440|0 |1 is obsolete|| Attachment #130441|0 |1 is obsolete|| Attachment #130442|0 |1 is obsolete|| --- Comment #71 from Joonas Kylmälä --- Created attachment 139546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139546=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 Rebased-by: Joonas Kylmälä Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #70 from Martin Renvoize ---
(In reply to Joonas Kylmälä from comment #56)
Thanks for the review Joonas, it was really helpful!
> 1. Some of the patches are missing check if there is any transfer at all
> before proceeding to check in_transit status:
>
> +my $transfer = $item->get_transfer;
> +if ( $transfer->in_transit ) {
>
Great catch, fixed inline in all patches now.
> 2. The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation"
> needs to come last in the patch series, so just reorder and reattach the
> patches.
Done
> 3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches
> that use the output_pref function here.
Another good catch, done inline in all patches now.
> 4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and
> minutes, please bring them back :)
Doh, sorted now.
> 5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the
> in_transit transfers, it used to return all transfers previously, even those
> not yet sent (so in queue). Could you double-check on this? I think it is
> okay and the previous behaviour was buggy as it says they are IN_TRANSIT
> transfers, not queued ones.
I agree with your conclusion here. It took a bit of digging first time around
to come to that conclusion but I did the change by design here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127476|0 |1 is obsolete|| --- Comment #69 from Martin Renvoize --- Created attachment 130442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130442=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127477|0 |1 is obsolete|| --- Comment #68 from Martin Renvoize --- Created attachment 130441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130441=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127475|0 |1 is obsolete|| --- Comment #67 from Martin Renvoize --- Created attachment 130440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130440=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127474|0 |1 is obsolete|| --- Comment #66 from Martin Renvoize --- Created attachment 130439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130439=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127473|0 |1 is obsolete|| --- Comment #65 from Martin Renvoize --- Created attachment 130438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130438=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127472|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 130437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130437=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127471|0 |1 is obsolete|| --- Comment #63 from Martin Renvoize --- Created attachment 130436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130436=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127470|0 |1 is obsolete|| --- Comment #62 from Martin Renvoize --- Created attachment 130435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130435=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127469|0 |1 is obsolete|| --- Comment #61 from Martin Renvoize --- Created attachment 130434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130434=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127468|0 |1 is obsolete|| --- Comment #60 from Martin Renvoize --- Created attachment 130433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130433=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127467|0 |1 is obsolete|| --- Comment #59 from Martin Renvoize --- Created attachment 130432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130432=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127466|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 130431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130431=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #127465|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 130430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130430=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295
Joonas Kylmälä changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||joonas.kylm...@iki.fi
--- Comment #56 from Joonas Kylmälä ---
1. Some of the patches are missing check if there is any transfer at all before
proceeding to check in_transit status:
+my $transfer = $item->get_transfer;
+if ( $transfer->in_transit ) {
This results to such errors as this:
> Can't call method "in_transit" on an undefined value at
> /kohadevbox/koha/catalogue/detail.pl line 350
2. The patch "Bug 24295: Finally remove GetTransfers from C4/Circulation"
needs to come last in the patch series, so just reorder and reattach the
patches.
3. Need to add "use Koha::DateUtils qw( output_pref );" to those patches that
use the output_pref function here.
4. "Bug 24295: Remove GetTransfers from detail.pl" removes hours and minutes,
please bring them back :)
5. "Bug 24295: Remove GetTransfer from Z3950Responder" now only lists the
in_transit transfers, it used to return all transfers previously, even those
not yet sent (so in queue). Could you double check on this? I think it is okay
and the previous behaviour was buggy as it says they are IN_TRANSIT transfers,
not queued ones.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #55 from Martin Renvoize --- Rebased.. remarkably, it wasn't too terrible a rebase.. just needed pretty much every patch touching to drop the GetTransfers import introduced with our EXPORT bug. Back to NSO -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #54 from Martin Renvoize --- Created attachment 127477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127477=edit Bug 24295: Remove GetTransfers from circ/transferstoreceive.pl Just drop the import of GetTransfers from circ/transferstoreceive.pl is it's never actually used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119867|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 127476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127476=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119866|0 |1 is obsolete|| --- Comment #52 from Martin Renvoize --- Created attachment 127475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127475=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119863|0 |1 is obsolete|| --- Comment #51 from Martin Renvoize --- Created attachment 127474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127474=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119862|0 |1 is obsolete|| --- Comment #50 from Martin Renvoize --- Created attachment 127473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127473=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119861|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 127472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127472=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119860|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize --- Created attachment 127471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127471=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119859|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 127470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127470=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #46 from Martin Renvoize --- Created attachment 127469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127469=edit Bug 24295: Remove GetTransfers from request.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119857|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 127468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127468=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119856|0 |1 is obsolete|| --- Comment #44 from Martin Renvoize --- Created attachment 127467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127467=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119855|0 |1 is obsolete|| --- Comment #43 from Martin Renvoize --- Created attachment 127466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127466=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119854|0 |1 is obsolete|| --- Comment #42 from Martin Renvoize --- Created attachment 127465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127465=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #41 from Tomás Cohen Arazi --- Nice work! Please re-do/rebase some of those. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #40 from Martin Renvoize --- Created attachment 119867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119867=edit Bug 24295: Finally remove GetTransfers from C4/Circulation This patch handles the final removal of GetTransfers from C4::Circulation. Test plan 1/ Check that there is no mention of the GetTransfers method codebase wide now 2/ Run the circulation and transfers tests and check nothing fails.. perhaps even run the full test suit in k-t-d 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #119864|0 |1 is obsolete|| --- Comment #39 from Martin Renvoize --- Created attachment 119866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119866=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118310|0 |1 is obsolete|| --- Comment #37 from Martin Renvoize --- Created attachment 119863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119863=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #38 from Martin Renvoize --- Created attachment 119864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119864=edit Bug 24295: Remove GetTransfers from C4/Search.pm This patch removes the final use of GetTransfers from C4::Search. Test plan 1/ Perform a search that will include results for some items that have transfers of various states assigned to them 2/ Check the results match expectations (before and after applying the patch should look the same) 3/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118308|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 119861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119861=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118309|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 119862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119862=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118306|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 119859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119859=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118307|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 119860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119860=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118305|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 119858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119858=edit Bug 24295: Remove GetTransfers from reserve.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118302|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 119855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119855=edit Bug 24295: Remove GetTransfers from opac-reserve.pl This patch replaces the call to GetTransfers in opac-reserve with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the opac-reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118304|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 119857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119857=edit Bug 24295: Remove GetTransfers from opac-basket.pl This patch replaces the call to GetTransfers in opac-basket with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-basket page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118301|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 119854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119854=edit Bug 24295: Remove GetTransfer from Z3950Responder Replace the GetTrasfer call in Z3950Responder/Session.pm with a call to the Koha::Item method 'get_transfer'. Test plan 1/ Configure your system to use the Z3950 responder 2/ Trigger an item transfer for an item 3/ Search for the item via Z3950 and varify the transfer status is set 4/ Apply the patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118303|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 119856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119856=edit Bug 24295: Remove GetTransfers from opac-detail.pl This patch replaces the call to GetTransfers in opac-detail with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the opac-detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Depends on|27896 |12362 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12362 [Bug 12362] Branch transfer records orphaned on cancelled holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27896 [Bug 27896] Remove C4::Circulation::DeleteTransfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 --- Comment #27 from Martin Renvoize --- Moving the below comment from bug 24295: >QA Query.. are 'get_transfer' and 'get_transfers' the right names for these >>accessors.. > >I feel like perhaps they would be better called > >`->next_transfer` and `->queued_transfers` or something along those lines. When talking around the subject, we decided upon `get_active_transfer` and `get_all_transfers` as suitable names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118300|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118299|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118298|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118297|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118296|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118295|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 118310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118310=edit Bug 24295: Remove GetTransfers call from C4/HoldsQueue.pm This patch removes the GetTransfers call from GetItemsAvailableToFillHoldRequestsForBib instead replacing it with an inline JOIN in the initial query. Test plan 1/ Run the holds queue 2/ Check the results 3/ Put one of the items in the holds queue into transit 4/ Run the holds queue again 5/ Check that the results do not contain the item that is in transit 6/ Apply the patch 7/ Run the holds queue again 8/ Check that the results still do not contain the item that is in transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118250|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 118309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118309=edit Bug 24295: Replace mock in t/db_dependent/Circulation/transferbook.t Replace the call to GetTransfers with the get_transfer method in Koha::Item in transferbook.t Test plan 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118249|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 118308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118308=edit Bug 24295: Replace mock in t/db_dependent/Search.t Replace the mock of GetTransfers in this test with a mock of transfers data Test plan 1/ Run t/db_dependent/Search.t 2/ Confirm it passes 3/ Apply patch 4/ Repeat steps 1-2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118248|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 118307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118307=edit Bug 24295: Remove GetTransfers from svc/holds This patch replaces the call to C4::GetTransfers in svc/holds with a call to the get_transfer method in the Koha::Item object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118247|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 118306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118306=edit Bug 24295: Remove GetTransfers from detail.pl This patch replaces the call to GetTransfers in detail.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Trigger the transfer of the item 2/ Check the detail page for the display of the current transfer status 3/ Apply patch 4/ Repeat step 2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24295] C4::Circulation::GetTransfers should be removed, use Koha::Item->get_transfer instead
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24295 Martin Renvoize changed: What|Removed |Added Attachment #118246|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 118305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118305=edit Bug 24295: Remove GetTransfers from reserve.pl This patch replaces the call to GetTransfers in reserve.pl with the get_transfer method available from the Koha::Item object Test plan 1/ Place a reserve on an item at a different branch 2/ Trigger the transfer of the item 3/ Check the reserves page for the display of the current transfer status 4/ Apply patch 5/ Repeat step 3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
