[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #10 from Nick Clemens --- Created attachment 105522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105522=edit Bug 24379: Don't drop default of 0 for login attempts When moving the column we drop the default, this means that DBs upgraded form earlier versions get the wrong values set To test: 1 - Checkout 16.11.x 2 - Reset all 3 - Checkout master 4 - updatedatabase 5 - SHOW CREATE TABLE borrowers; 6 - Note the column login_attempts defaults to NULL 7 - Apply patch(es) 8 - Repeat 9 - Now it defaults ot 0 (and has NOT NULL if applied all) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Blocks||25664 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25664 [Bug 25664] login_attempts for imported borrowers can be set to NULL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- I have tried on both master and 19.11.x and login_attempts contains "0" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #8 from Kelly McElligott --- This is currently still the case on 19.11. When creating a new patron, the login attempts are set to NULL making the password recovery not work on the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #7 from Katrin Fischer --- Forget the first line... I think it's possibly not fixed, started the comment before looking at updatedatabase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379
--- Comment #6 from Katrin Fischer ---
I think it might have been fixed already:
kohastructure.sql:
`login_attempts` int(4) default 0, -- number of failed login attemps
updatedatabase:
14478 $DBversion = '16.12.00.037'; - with default 0
14666 $DBversion = '17.06.00.009'; - is a little weird:
14668 $dbh->do(q{
14669 ALTER TABLE borrowers MODIFY COLUMN login_attempts int(4) AFTER
lang;
14670 });
14671 $dbh->do(q{
14672 ALTER TABLE deletedborrowers MODIFY COLUMN login_attempts int(4)
AFTER lang;
14673 });
Is it possible the 17.06 change broke the default 0 for updated installations?
That could explain, why you don't see the issue on master.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #5 from Lucas Gass --- I cannot recreate this in master. When I create a new patron (either from the staff client or selfreg via OPAC) login_attempts are initially set to 0 and I am able to reset my password via OpacResetPassword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- Is this ready for testing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #3 from Jonathan Druart --- Created attachment 97073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97073=edit Bug 24379: Fix the test First we create a patron using TestBuilder to get a hashref of valid info. Then we delete it and create a new patron using Koha::Patron->new Once stored, we should call discard_changes to make the calculated values available in the currenct object. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #2 from Nick Clemens --- Tests don't pass, something is missing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 Nick Clemens changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24379] Borrowers Login Attempts is NULL
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24379 --- Comment #1 from Nick Clemens --- Created attachment 97058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97058=edit Bug 24379: Make login_attempts not nullable While the column defaults to 0 in Koha::Object->store we set to NULL if NULLABLE When trying to reset a patrons password we check that the account is not administratively locked: login_attempts != -1 This query does not return rows where login_attempts IS NULL. It will return accounts where login_attempts = 0 Let's default to 0 like we intend To test: 1 - Create a new patron 2 - Note their login_attempts is NULL SELECT login_attempts FROM borrowers ORDER BY borrowernumber DESC LIMIT 1 3 - Enable OpacResetPassword 4 - Attempt to reset password before logging in, you cannot 5 - Apply patch, updatedatabase, restart_all, update schema 6 - Create another patron 7 - Their login attempts should be 0 8 - Attempt to reset password, it works! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
