[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #30 from Joy Nelson --- does not apply cleanly to 19.11.x branch. please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #29 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #28 from Jonathan Druart --- (In reply to Jonathan Druart from comment #27) > Created attachment 102985 [details] [review] > Bug 24380: Simplify condition > > Signed-off-by: Jonathan Druart IMO it eases the read of the condition, feel free to disagree and obsolete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #27 from Jonathan Druart --- Created attachment 102985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102985=edit Bug 24380: Simplify condition Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #26 from Jonathan Druart --- Created attachment 102984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102984=edit Bug 24380: (QA follow-up) Do not use compare float with precision forbidden pattern: Do not use compare float with precision (bug 24408). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What|Removed |Added Attachment #102894|0 |1 is obsolete|| Attachment #102895|0 |1 is obsolete|| Attachment #102896|0 |1 is obsolete|| --- Comment #23 from Jonathan Druart --- Created attachment 102981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102981=edit Bug 24380: Unit Test Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #24 from Jonathan Druart --- Created attachment 102982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102982=edit Bug 24380: Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #25 from Jonathan Druart --- Created attachment 102983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102983=edit Bug 24380: Add syspref CalculateFinesOnBackdate Signed-off-by: Martin Renvoize Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added Attachment #102575|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 102894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102894=edit Bug 24380 - Unit Test Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #22 from Martin Renvoize --- Thanks Kyle, all works as expected.. Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added Attachment #102577|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 102896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102896=edit Bug 24380: Add syspref CalculateFinesOnBackdate Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added Attachment #102576|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 102895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102895=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #18 from Katrin Fischer --- (In reply to Kyle M Hall from comment #17) > Created attachment 102577 [details] [review] > Bug 24380: Add syspref CalculateFinesOnBackdate Thank you Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #16 from Kyle M Hall --- Created attachment 102576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102576=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #102574|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 102575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102575=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #99537|0 |1 is obsolete|| Attachment #99538|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 102574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102574=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #17 from Kyle M Hall --- Created attachment 102577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102577=edit Bug 24380: Add syspref CalculateFinesOnBackdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #13 from Katrin Fischer --- (In reply to Martin Renvoize from comment #12) > I have a vague recollection of Katrin being keen to NOT do this.. perhaps it > should be behind YASP (Yet Another System Preference) Yes, we have an alternate fine calculation that is used with some of our libraries - recalculating would come up with the wrong values. So we have turned off the pref there. I think while we coudl argue that's our problem - there is also the staticfines.pl job and possible others with similar needs. I'd really like to put this under the same or a separate pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #12 from Martin Renvoize --- I have a vague recollection of Katrin being keen to NOT do this.. perhaps it should be behind YASP (Yet Another System Preference) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #97751|0 |1 is obsolete|| Attachment #97752|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 99536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99536=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #11 from Kyle M Hall --- Created attachment 99538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99538=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #99536|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall --- Created attachment 99537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99537=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart --- CONFLICT (content): Merge conflict in t/db_dependent/Circulation/Returns.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Katrin Fischer changed: What|Removed |Added Component|Architecture, internals,|Fines and fees |and plumbing| CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #7 from Kyle M Hall --- Created attachment 97752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97752=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #97750|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 97751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97751=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Attachment #97544|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 97750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97750=edit Bug 24380 - Unit Test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #4 from Kyle M Hall --- (In reply to Jonathan Druart from comment #3) > Kyle, can you provide tests please? Absolutely! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Kyle, can you provide tests please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Jonathan Druart changed: What|Removed |Added Depends on||14591 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 ByWater Sandboxes changed: What|Removed |Added Attachment #97055|0 |1 is obsolete|| --- Comment #2 from ByWater Sandboxes --- Created attachment 97544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97544=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! Signed-off-by: Kelly McElligott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24380] Backdated returns do not update fines unless CalculateFinesOnReturn is enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24380 --- Comment #1 from Kyle M Hall --- Created attachment 97055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97055=edit Bug 24380 - Backdated returns do not update fines unless CalculateFinesOnReturn is enabled In Koha 18.11 backdating a return triggered a recalculation of the fine. This was removed in bug 14591, and I believe it was in error. The bug report itself has no justification for the change in behavior. Test Plan: 1) Disable CalculateFinesOnReturn 2) Backdate an overdue with fines, note the fine does not change 3) Apply this patch 4) Repeat step 2 5) The fine should be updated! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
