[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Tomás Cohen Arazi changed: What|Removed |Added Blocks||31437 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31437 [Bug 31437] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #75 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Jonathan Druart changed: What|Removed |Added Blocks||28208 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28208 [Bug 28208] ModItemTransfer no longer updates item.datelastseen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks||28210 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28210 [Bug 28210] C4::Circulation::LostItem should pass through skip_record_index to MarkIssueReturned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #74 from Nick Clemens --- Created attachment 120116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120116=edit Bug 24446: (follow-up) Fix tests The tests were failing because we weren't actually changing the item, so store was doing nothing. We need to transfer 'from' a new branch so that the holdingbranch is changed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks|4234| Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #73 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #72 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #71 from Jonathan Druart --- Created attachment 117607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117607=edit Bug 24446: (QA follow-up) Use 'receive' method in ModReserveAffect ModeReserveAffect was setting all transfers in the queue to received by looping through a resultset. This patch updates the logic to try and catch the in_transit transfer and receive just that one instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #70 from Jonathan Druart --- Created attachment 117606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117606=edit Bug 24446: (QA follow-up) Remove superflous store calls The original code here called store after setting each field. Instead, we set all the fields and call store at the end and save ourselves a few database hits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #69 from Jonathan Druart --- Created attachment 117605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117605=edit Bug 24446: (QA follow-up) SIP test fix for bug 27166 A new test was introduced in bug 27166 since this code was written, this patch simply updates the test for the additional 'TransferTrigger' message that is returned by this patchset. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #66 from Jonathan Druart --- Created attachment 117602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117602=edit Bug 24446: (QA follow-up) Fix ModItemTransfer tests Seems I missed passing trigger in the tests for ModItemTransfer. This patch corrects that oversight. Signed-off-by: Kathleen Milne Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #68 from Jonathan Druart --- Created attachment 117604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117604=edit Bug 24446: (QA follow-up) Set TransferTrigger to 'Reserve' for bug 24298 The SIP initiated transfer was set to use the 'TransferTrigger' passed back from AddReturn; However, TransferTrigger is not set for reserves in AddReturn (It's is set controller side by circ/returns.pl). We thus need to also hard code the trigger type in the SIP transaction for reserves. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #65 from Jonathan Druart --- Created attachment 117601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117601=edit Bug 24446: (QA follow-up) Update transferbook Test Needed for a rebase, a new test was introduced so we need to add the trigger option into that test now too. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #67 from Jonathan Druart --- Created attachment 117603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117603=edit Bug 24446: (QA follow-up) Correction to datecancelled for ModItemTransfer ModItemTransfer always replaces any existing transfers, including those in transit.. so we needed to add a 'force' option to Koha::Item::Transfer->cancel(); Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #64 from Jonathan Druart --- Created attachment 117600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117600=edit Bug 24446: (QA follow-up) Update unit test for ModItemTransfer Update unit test to reflect we now use cancellationdate and cancellation_reason in ModItemTransfer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #63 from Jonathan Druart --- Created attachment 117599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117599=edit Bug 24446: Update ModItemTransfer for daterequested/datecancelled C4::Items::ModItemTransfer is used throughout the codebase and currently it will never set the daterequested or datecancelled fields. With the modifications to how circulation deals with transfers we need to update this function to set those fields appropriately. Functionality has been retained, ModItemTransfer will continue to add a transfer regardless of limits or current transits existing. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #62 from Jonathan Druart --- Created attachment 117598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117598=edit Bug 24446: Add datesent/datecancelled handling to GetTransfersFromTo With the first uses of Koha::Item->request_transfer and Koha::Item::Transfer->cancel having been added, we need to update GetTransferFromTo to respect transfers that have been requested but not yet sent and not cancelled. Test plan 1/ Run the included unit test 2/ Confirm the "Transfers to recieve" page loads 3/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #61 from Jonathan Druart --- Created attachment 117597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117597=edit Bug 24446: Add datecancelled handling to GetTransfers Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #60 from Jonathan Druart --- Created attachment 117596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117596=edit Bug 24446: Prioritize RotatingCollection transfer over StockRotationAdvance This patch prioritizes the RotatingCollection transfer type over the StockRotationAdvance transfers allowing us to queue up a our transfer behind it. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #59 from Jonathan Druart --- Created attachment 117595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117595=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. To test 1/ Run t/db_dependent/StockRotationsItems.t. 2/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #58 from Jonathan Druart --- Created attachment 117594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117594=edit Bug 24446: Update GetTransfers Unit Test We updated the return signature for GetTransfers and as such need to update the corresponding unit test Test plan 1/ Run t/db_dependent/Circulation/transfers.t 2/ Confirm it passes 3/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #57 from Jonathan Druart --- Created attachment 117593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117593=edit Bug 24446: Update transferbook Unit Test We updated C4::Circulation::transferbook to return the to_branch branchcode as the data entity for 'WasTransfered'. This patch updates the corresponding unit test. To test: 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Signoff if it passes Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #56 from Jonathan Druart --- Created attachment 117592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117592=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #55 from Jonathan Druart --- Created attachment 117591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117591=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #54 from Jonathan Druart --- Created attachment 117590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117590=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Jonathan Druart changed: What|Removed |Added Attachment #116557|0 |1 is obsolete|| Attachment #116558|0 |1 is obsolete|| Attachment #116559|0 |1 is obsolete|| Attachment #116560|0 |1 is obsolete|| Attachment #116561|0 |1 is obsolete|| Attachment #116562|0 |1 is obsolete|| Attachment #116563|0 |1 is obsolete|| Attachment #116564|0 |1 is obsolete|| Attachment #116565|0 |1 is obsolete|| Attachment #116566|0 |1 is obsolete|| Attachment #116567|0 |1 is obsolete|| Attachment #116568|0 |1 is obsolete|| Attachment #116569|0 |1 is obsolete|| Attachment #116570|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 117589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117589=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Kathleen Milne Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Text to go in the|This patchset updates the |This patchset updates the release notes|Stock Rotation system to|Stock Rotation system to |use the recently introduced |use the recently introduced |Koha::Item[::Transfer] |Koha::Item[::Transfer] |methods. |methods. | | |It fixes a bug |It fixes a bug |whereby such transfers |whereby such transfers |could be accidentally |could be accidentally |cancelled by other |cancelled by other |processes and sets these|processes and sets these |transfer to be the lowest |transfer to be the lowest |priority. |priority. || ||We also ||introduce handling for the ||new 'requested' transfer ||state into the circulation ||system. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Text to go in the||This patchset updates the release notes||Stock Rotation system to ||use the recently introduced ||Koha::Item[::Transfer] ||methods. || ||It fixes a bug ||whereby such transfers ||could be accidentally ||cancelled by other ||processes and sets these ||transfer to be the lowest ||priority. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |joonas.kylm...@helsinki.fi |y.org | Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #52 from Martin Renvoize --- Created attachment 116570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116570=edit Bug 24446: (QA follow-up) Correction to datecancelled for ModItemTransfer ModItemTransfer always replaces any existing transfers, including those in transit.. so we needed to add a 'force' option to Koha::Item::Transfer->cancel(); Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #51 from Martin Renvoize --- Created attachment 116569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116569=edit Bug 24446: (QA follow-up) Fix ModItemTransfer tests Seems I missed passing trigger in the tests for ModItemTransfer. This patch corrects that oversight. Signed-off-by: Kathleen Milne Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #50 from Martin Renvoize --- Created attachment 116568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116568=edit Bug 24446: (QA follow-up) Update transferbook Test Needed for a rebase, a new test was introduced so we need to add the trigger option into that test now too. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #49 from Martin Renvoize --- Created attachment 116567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116567=edit Bug 24446: Update ModItemTransfer for daterequested/datecancelled C4::Items::ModItemTransfer is used throughout the codebase and currently it will never set the daterequested or datecancelled fields. With the modifications to how circulation deals with transfers we need to update this function to set those fields appropriately. Functionality has been retained, ModItemTransfer will continue to add a transfer regardless of limits or current transits existing. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #48 from Martin Renvoize --- Created attachment 116566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116566=edit Bug 24446: Add datesent/datecancelled handling to GetTransfersFromTo With the first uses of Koha::Item->request_transfer and Koha::Item::Transfer->cancel having been added, we need to update GetTransferFromTo to respect transfers that have been requested but not yet sent and not cancelled. Test plan 1/ Run the included unit test 2/ Confirm the "Transfers to recieve" page loads 3/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #47 from Martin Renvoize --- Created attachment 116565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116565=edit Bug 24446: Add datecancelled handling to GetTransfers Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #46 from Martin Renvoize --- Created attachment 116564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116564=edit Bug 24446: Prioritize RotatingCollection transfer over StockRotationAdvance This patch prioritizes the RotatingCollection transfer type over the StockRotationAdvance transfers allowing us to queue up a our transfer behind it. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #45 from Martin Renvoize --- Created attachment 116563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116563=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. To test 1/ Run t/db_dependent/StockRotationsItems.t. 2/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #44 from Martin Renvoize --- Created attachment 116562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116562=edit Bug 24446: Update GetTransfers Unit Test We updated the return signature for GetTransfers and as such need to update the corresponding unit test Test plan 1/ Run t/db_dependent/Circulation/transfers.t 2/ Confirm it passes 3/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #43 from Martin Renvoize --- Created attachment 116561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116561=edit Bug 24446: Update transferbook Unit Test We updated C4::Circulation::transferbook to return the to_branch branchcode as the data entity for 'WasTransfered'. This patch updates the corresponding unit test. To test: 1/ Run t/db_dependent/Circulation/transferbook.t 2/ Signoff if it passes Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #42 from Martin Renvoize --- Created attachment 116560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116560=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #41 from Martin Renvoize --- Created attachment 116559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116559=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #40 from Martin Renvoize --- Created attachment 116558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116558=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #39 from Martin Renvoize --- Created attachment 116557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116557=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Kathleen Milne Signed-off-by: Martin Renvoize Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #111322|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110541|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110542|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110540|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110538|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110539|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks|22569 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 [Bug 22569] Stock rotation: 'Transfers to send' report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #38 from Martin Renvoize --- Created attachment 111322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111322=edit Bug 24446: Prioritize RotatingCollection transfer over StockRotationAdvance This patch prioritizes the RotatingCollection transfer type over the StockRotationAdvance transfers allowing us to queue up a our transfer behind it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks||26618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26618 [Bug 26618] C4/RotatingCollections.pm should not use C4::Circulation::transferbook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Depends on|26481 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26481 [Bug 26481] Add Koha::Item::Transfer->in_transit method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #37 from Katrin Fischer --- The dependent bug 26057 still requires sign-off - moving to BLOCKED for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks|23432 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks||23432 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23432 [Bug 23432] Stock rotation: cancelled transfer result in stockrotation failures -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Blocks||4234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4234 [Bug 4234] Automatic transfer shouldn't take precedence over a hold transit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110534|0 |1 is obsolete|| --- Comment #33 from Martin Renvoize --- Created attachment 110539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110539=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110537|0 |1 is obsolete|| --- Comment #36 from Martin Renvoize --- Created attachment 110542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110542=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110535|0 |1 is obsolete|| --- Comment #34 from Martin Renvoize --- Created attachment 110540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110540=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110536|0 |1 is obsolete|| --- Comment #35 from Martin Renvoize --- Created attachment 110541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110541=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110533|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 110538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110538=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #31 from Martin Renvoize --- Leaving as FQA.. just thought of some more tests I aught to add with that final followup :| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #30 from Martin Renvoize --- Created attachment 110537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110537=edit Bug 24446: (follow-up) Handle cases of pre-existing transfers This is a long standing bug in stockrotation (and transfers in general) where by if a transfer is in progress and another transfer is requested then the original transfer is inexplicitly cancelled. This patch updates the stockrotation code to handle queued transfers, either adding a StockrotationAdvance transfer to the queue when an in progress transfer was triggered to fulfil a Reserve, or otherwise cancelling the transfer as stockrotation should take precidence. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110281|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 110534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110534=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110283|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 110536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110536=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110280|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 110533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110533=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #110282|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 110535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110535=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #25 from Martin Renvoize --- Oops, I forgot to mark this as assigned.. I found a couple fo bugs whilst sorting out some of the tree last week.. working on them at the moment.. thanks for testing Katrin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |Failed QA --- Comment #24 from Katrin Fischer --- kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/StockRotationItems.t t/db_dependent/StockRotationItems.t .. 5/8 # Looks like you planned 6 tests but ran 5. # Failed test 'Tests for needs_advancing.' # at t/db_dependent/StockRotationItems.t line 229. Can't locate object method "clone" via package "0" (perhaps you forgot to load "0"?) at /usr/lib/x86_64-linux-gnu/perl5/5.24/DateTime/Duration.pm line 326. # Looks like your test exited with 255 just after 6. t/db_dependent/StockRotationItems.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/8 subtests Test Summary Report --- t/db_dependent/StockRotationItems.t (Wstat: 65280 Tests: 6 Failed: 1) Failed test: 6 Non-zero exit status: 255 Parse errors: Bad plan. You planned 8 tests but ran 6. Files=1, Tests=6, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.64 cusr 0.25 csys = 2.92 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Depends on||26057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26057 [Bug 26057] Transfers should record if they have been cancelled/overridden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Katrin Fischer changed: What|Removed |Added Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107304|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107305|0 |1 is obsolete|| --- Comment #22 from Martin Renvoize --- Created attachment 110283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110283=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #23 from Martin Renvoize --- Tested in use by Kathleen as part of relying on bug 22569 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107301|0 |1 is obsolete|| --- Comment #19 from Martin Renvoize --- Created attachment 110280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110280=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107303|0 |1 is obsolete|| --- Comment #21 from Martin Renvoize --- Created attachment 110282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110282=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107302|0 |1 is obsolete|| --- Comment #20 from Martin Renvoize --- Created attachment 110281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110281=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. Signed-off-by: Kathleen Milne -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Depends on|25767 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767 [Bug 25767] Add Koha::Item::Transfer->receipt method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Depends on||26481 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26481 [Bug 26481] Add Koha::Item::Transfer->receipt method -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107256|0 |1 is obsolete|| --- Comment #18 from Martin Renvoize --- Created attachment 107305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107305=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107255|0 |1 is obsolete|| --- Comment #17 from Martin Renvoize --- Created attachment 107304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107304=edit Bug 24446: Add Koha::Item::Transfer->in_transit method This method returns a boolean representing the in_transit state of the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107252|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 107301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107301=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107254|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 107303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107303=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107253|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 107302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107302=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107249|0 |1 is obsolete|| --- Comment #12 from Martin Renvoize --- Created attachment 107255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107255=edit Bug 24446: Add Koha::Item::Transfer->in_transit method This method returns a boolean representing the in_transit state of the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107250|0 |1 is obsolete|| --- Comment #13 from Martin Renvoize --- Created attachment 107256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107256=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107247|0 |1 is obsolete|| --- Comment #10 from Martin Renvoize --- Created attachment 107253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107253=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107248|0 |1 is obsolete|| --- Comment #11 from Martin Renvoize --- Created attachment 107254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107254=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #107246|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 107252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107252=edit Bug 24446: Update branchtransfers.daterequested for stockrotation This database update catches existing stockrotation triggered branchtransfers and moves the datesent value into daterequested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #8 from Martin Renvoize --- Created attachment 107250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107250=edit Bug 24446: Catch daterequested in circ returns Update C4::Circulation::AddReturn to use Koha::Item->get_transfer to find requested transfers and use Koha::Item::Transfer->receipt to complete transfer requests if they have arrived at their destination or return the relevant 'WrongTransfer', 'WasTransfered' and 'TransferTrigger' messages to the end user. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #105945|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 107248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107248=edit Bug 24446: Update StockRotationItem to use daterequested This patch updates the stockrotation functionality to utilise the new branchtransfers.daterequested field to more accurately track the state of stockrotation transfers. We also opt to start using the new Koha::Item and Koha::Item::Transfer methods to achieve this goal. Test plan 0/ Setup stockrotation and configure some rotas and assign items to them. 1/ Run the stockrotation cronscript 2/ Check the database for branchtransfers initiated by stockrotation and confirm that that now populate the daterequested field and not the datesent. 3/ Run the stockrotation tests and verify they pass 4/ Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 --- Comment #7 from Martin Renvoize --- Created attachment 107249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107249=edit Bug 24446: Add Koha::Item::Transfer->in_transit method This method returns a boolean representing the in_transit state of the transfer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446 Martin Renvoize changed: What|Removed |Added Attachment #105944|0 |1 is obsolete|| --- Comment #5 from Martin Renvoize --- Created attachment 107247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107247=edit Bug 24446: Improve StockRotationItem->advance tests This patch adds additional checks in the tests for item homebranch updates and cyclical transfers caused by the StockRotationItem->advance method. It highlights a bug in the original logic whereby a cyclical rotation would always result in a completed transfer but the physical item would not have actually been moved between branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
