[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 --- Comment #10 from Katrin Fischer --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Katrin Fischer changed: What|Removed |Added Version(s)||24.11.00 released in|| Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Severity|minor |enhancement QA Contact||m.de.r...@rijksmuseum.nl --- Comment #9 from Marcel de Rooy --- Moving to enh -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Marcel de Rooy changed: What|Removed |Added Attachment #168525|0 |1 is obsolete|| --- Comment #8 from Marcel de Rooy --- Created attachment 169994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169994&action=edit Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 David Nind changed: What|Removed |Added Attachment #168462|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 168525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168525&action=edit Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Pedro Amorim changed: What|Removed |Added Severity|enhancement |minor Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Pedro Amorim changed: What|Removed |Added Attachment #97678|0 |1 is obsolete|| --- Comment #6 from Pedro Amorim --- Created attachment 168462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168462&action=edit Bug 24471: Rename handle_commit_maybe method To test (k-t-d): 1) Enable ILLModule and install FreeForm, run: bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh) 2) Checkout 24.05.x branch, run: cd /kohadevbox/koha/Koha/Illbackends/FreeForm git checkout 24.05.x 3) Create a new ILL request from: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 4) Confirm the request creation works as before -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Pedro Amorim changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Martin Renvoize changed: What|Removed |Added Assignee|martin.renvoize@ptfs-europe |pedro.amo...@ptfs-europe.co |.com|m Status|Patch doesn't apply |ASSIGNED --- Comment #5 from Martin Renvoize --- I have a feeling this is no longer relevant? I've re-assigned to Pedro as our current lead on ILL, but I'd be happy for it to be a simple check and close if the idea if outdated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Andrew Isherwood changed: What|Removed |Added Assignee|bugzi...@warmlight.co.uk|koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- +1 to this bug report. I don't think that "maybe" should ever be in a function name... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Catherine changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Catherine --- CONFLICT (content): Merge conflict in ill/ill-requests.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Catherine changed: What|Removed |Added CC||catherinem2...@gmail.com Attachment #115252|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 --- Comment #2 from Catherine --- Created attachment 115252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115252&action=edit Bug 25054: (QA follow-up) Add space after comma for multiple aliases Just a little formatting change to help readability by adding a space after comma: alias1, alias2, ... Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 --- Comment #1 from Andrew Isherwood --- Created attachment 97678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97678&action=edit Bug 24471: handle_commit_maybe => redirect_user This patch renames all occurrences of handle_commit_maybe to redirect_user Test plan: - Navigate around ILL and check redirections from one action/stage to another are happening correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Andrew Isherwood changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24471] Rename ILL method handle_commit_maybe
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24471 Andrew Isherwood changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
