[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=22750 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #73 from Joy Nelson --- Also - dependencies lacking in 19.11.x - not backported -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #72 from Joy Nelson --- does not apply cleanly to 19.11.x please rebase if needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #71 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #69 from Kyle M Hall --- Created attachment 102137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102137=edit Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #70 from Kyle M Hall --- Created attachment 102138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102138=edit Bug 24474: (QA follow-up) Fix failing test The test was assuming default data and would fail if you ran through the test plan (and disabled all but `onpayment` for the 'MarkLostItemsAsReturned' preference) on the data before running the included unit tests. Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #68 from Kyle M Hall --- Created attachment 102136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102136=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #67 from Kyle M Hall --- Created attachment 102135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102135=edit Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #66 from Kyle M Hall --- Created attachment 102134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102134=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Kyle M Hall changed: What|Removed |Added Attachment #102132|0 |1 is obsolete|| --- Comment #65 from Kyle M Hall --- Created attachment 102133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102133=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Kyle M Hall changed: What|Removed |Added Attachment #102105|0 |1 is obsolete|| Attachment #102106|0 |1 is obsolete|| Attachment #102107|0 |1 is obsolete|| Attachment #102108|0 |1 is obsolete|| Attachment #102109|0 |1 is obsolete|| Attachment #102110|0 |1 is obsolete|| --- Comment #64 from Kyle M Hall --- Created attachment 102132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102132=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #102104|0 |1 is obsolete|| --- Comment #63 from David Nind --- Created attachment 102110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102110=edit Bug 24474: (QA follow-up) Fix failing test The test was assuming default data and would fail if you ran through the test plan (and disabled all but `onpayment` for the 'MarkLostItemsAsReturned' preference) on the data before running the included unit tests. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #100233|0 |1 is obsolete|| --- Comment #62 from David Nind --- Created attachment 102109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102109=edit Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #100232|0 |1 is obsolete|| --- Comment #61 from David Nind --- Created attachment 102108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102108=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #100231|0 |1 is obsolete|| --- Comment #60 from David Nind --- Created attachment 102107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102107=edit Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #100229|0 |1 is obsolete|| --- Comment #58 from David Nind --- Created attachment 102105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102105=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #100230|0 |1 is obsolete|| --- Comment #59 from David Nind --- Created attachment 102106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102106=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #57 from Martin Renvoize --- Created attachment 102104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102104=edit Bug 24474: (QA follow-up) Fix failing test The test was assuming default data and would fail if you ran through the test plan (and disabled all but `onpayment` for the 'MarkLostItemsAsReturned' preference) on the data before running the included unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #56 from Martin Renvoize --- That's really helpful David, thankyou. The tests really aught to take account of that.. I'll take a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #55 from David Nind --- I figured out what has happened: 1) If I leave MarkLostItemsAsReturned with only the 'when receiving payment for the item' option selected (as per the test plan) then the tests fail. 2) If I change MarkLostItemsAsReturned back to the default (with all options selected) then the tests pass. If this is fine, then I will sign-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #54 from Martin Renvoize --- Hmm.. I can't see any obvious reason for this :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #53 from Martin Renvoize --- How are you running the tests David? They're all passing for me within koha-testing-docker.. it feels like perhaps you have some data in your database that the tests are not expecting.. I'll take a look at trying to improve them to prevent such failures. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #52 from David Nind --- Everything works as per the test plan. However, there is still a failed test as before. Is there a system preference or setting related to test 31? I haven't failed QA, but I haven't signed it off yet either. root@8ca270a5fd09:koha(bz24474)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 30/47 # Failed test 'Should have a single 10 days overdue fine and lost charge' # at t/db_dependent/Circulation.t line 2430. # got: '27' # expected: '17' # Looks like you failed 1 test of 3. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2433. # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 31/47 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2433. t/db_dependent/Circulation.t .. 47/47 # Looks like you failed 1 test of 47. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/47 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 256 Tests: 47 Failed: 1) Failed test: 31 Non-zero exit status: 1 Files=1, Tests=47, 30 wallclock secs ( 0.09 usr 0.00 sys + 24.44 cusr 2.49 csys = 27.02 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #51 from Martin Renvoize --- Another few weeks passed.. quickly thinking this isn't 'critical' at this point. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #50 from Martin Renvoize --- Rebased again.. please test this Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98923|0 |1 is obsolete|| --- Comment #49 from Martin Renvoize --- Created attachment 100233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100233=edit Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98675|0 |1 is obsolete|| --- Comment #47 from Martin Renvoize --- Created attachment 100231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100231=edit Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98676|0 |1 is obsolete|| --- Comment #48 from Martin Renvoize --- Created attachment 100232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100232=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98674|0 |1 is obsolete|| --- Comment #46 from Martin Renvoize --- Created attachment 100230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100230=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98673|0 |1 is obsolete|| --- Comment #45 from Martin Renvoize --- Created attachment 100229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100229=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Bug 24474 depends on bug 24592, which changed state. Bug 24592 Summary: Clarify LOST_RETURN process by using FOUND over RETURNED https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #44 from Jonathan Druart --- Switching to Needs Signoff as I would like Aleisha to have a look at Martin's patches. However regression tests are missing, but that does not block human testing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #43 from Martin Renvoize --- As promised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #42 from Martin Renvoize --- Created attachment 98923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98923=edit Bug 24474: (follow-up) Add LOST_FOUND logic to Koha::Account::pay This patch adds the same updated logic as found in Koha::Account::Line->apply to handle LOST_FOUND credits being applied against their associated LOST debit. Currently a 'LOST_FOUND' credit is never created via the pay method and so the additional test will always pass, but the addition here accounts for possible future uses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #41 from Martin Renvoize --- (In reply to Jonathan Druart from comment #40) > Martin, what about the 2 occurrences in Koha::Account->pay? I think I traced it back and found that it's only actually occurring via a call to apply (i.e the call inside _FixAccountForLostAndFound), but it's probably not a bad idea to match the code in the two locations. I'll add a followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #40 from Jonathan Druart --- Martin, what about the 2 occurrences in Koha::Account->pay? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Chris Slone changed: What|Removed |Added CC||cslone@camdencountylibrary. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18895 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #39 from Martin Renvoize --- Hmm, I can't seem to replicate that test failure.. lets see how it goes in the QA run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #38 from David Nind --- Now works as outlined in the test plan! I re-ran the tests after signing off and one test fails: root@314245d82a59:koha(bz24474)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 30/47 # Failed test 'Should have a single 10 days overdue fine and lost charge' # at t/db_dependent/Circulation.t line 2344. # got: '27' # expected: '17' # Looks like you failed 1 test of 3. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2347. # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 31/47 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2347. t/db_dependent/Circulation.t .. 47/47 # Looks like you failed 1 test of 47. t/db_dependent/Circulation.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/47 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 256 Tests: 47 Failed: 1) Failed test: 31 Non-zero exit status: 1 Files=1, Tests=47, 29 wallclock secs ( 0.08 usr 0.00 sys + 23.90 cusr 2.79 csys = 26.77 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #98647|0 |1 is obsolete|| --- Comment #36 from David Nind --- Created attachment 98675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98675=edit Bug 24474: Filter out LOST_FOUND Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #98646|0 |1 is obsolete|| --- Comment #35 from David Nind --- Created attachment 98674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98674=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #98648|0 |1 is obsolete|| --- Comment #37 from David Nind --- Created attachment 98676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98676=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added Attachment #98645|0 |1 is obsolete|| --- Comment #34 from David Nind --- Created attachment 98673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98673=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #33 from Martin Renvoize --- (In reply to David Nind from comment #28) > For whatever reason I can't seem to get the 'onpayment' option to show up > for MarkLostItemsAsReturned. (Applied patch, ran database update, > restart_all). Doh! I missed a file when committing.. that should now be resolved. The test failure we're actually in the dependancy bug.. I've resolved them there and rebased this patchset upon them now. Cheers for testing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #32 from Martin Renvoize --- Created attachment 98648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98648=edit Bug 24474: (follow-up) Add onpayment to sysprefs file This patch adds the required line to the circulation.pref file to dispaly the onpayment option in the MarkLostItemReturned preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98487|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 98647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98647=edit Bug 24474: Filter out LOST_FOUND -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98486|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 98646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98646=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98485|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 98645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98645=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #28 from David Nind --- For whatever reason I can't seem to get the 'onpayment' option to show up for MarkLostItemsAsReturned. (Applied patch, ran database update, restart_all). For the tests I get this fail: root@50d5e409ced0:koha(bz24474)$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 30/47 # Failed test 'Should have a single 10 days overdue fine and lost charge' # at t/db_dependent/Circulation.t line 2344. # got: '27' # expected: '17' # Looks like you failed 1 test of 3. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2347. # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 31/47 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2347. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-99, 1='25', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-99, 1='28', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-74, 1='33', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`account_offsets`, CONSTRAINT `account_offsets_ibfk_t` FOREIGN KEY (`type`) REFERENCES `account_offset_types` (`type`) ON DELETE CASCADE ON UPDATE CASCADE) [for Statement "INSERT INTO `account_offsets` ( `amount`, `credit_id`, `type`) VALUES ( ?, ?, ? )" with ParamValues: 0=-100, 1='37', 2='Lost Item Found'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. t/db_dependent/Circulation.t .. 45/47 # Looks like you planned 2 tests but ran 1. t/db_dependent/Circulation.t .. 47/47 # Failed test 'Do not return on renewal (LOST charge)' # at t/db_dependent/Circulation.t line 3689. # Looks like you failed 2 tests of 47. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/47 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 512 Tests: 47 Failed: 2) Failed tests: 31, 47 Non-zero exit status: 2 Files=1, Tests=47, 29 wallclock secs ( 0.09 usr 0.00 sys + 23.87 cusr 2.77 csys = 26.73 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Blocks||14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24592 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #27 from Martin Renvoize --- Probably not QA ready, but certainly in good enough shape for some testing please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98460|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 98486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98486=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #26 from Martin Renvoize --- Created attachment 98487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98487=edit Bug 24474: Filter out LOST_FOUND -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98392|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 98485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98485=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned except for 'onpayment' - Check an item out - Create a manual invoice LOST for the checked in item - Renew the item - Check that the item was not returned -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Depends on||24592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24592 [Bug 24592] Clarify LOST_RETURN process by using FOUND over RETURNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98439|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98438|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98437|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Attachment #98436|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #23 from Martin Renvoize --- Created attachment 98460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98460=edit Bug 24474: Add `onpayment` option to `MarkLostItemsReturned` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Assignee|alei...@catalyst.net.nz |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #22 from Martin Renvoize --- OK.. having another go.. I don't like that I was moving the logic out of a well testing Object and into untested and hard to test messy controllers... bare with me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=24592 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #21 from Martin Renvoize --- This is still a work in progress.. I need to add some further tests selenium tests as this is moving code out of tested objects and into the controllers where really it should belong.. I really wish our controller layer was lighter and more clearly tested.. paycollect, for example, is a real mess at this point and I'm sure must contain untested functionality. I'll get writing tests and hopefully get this patchset through before swinging back around for a refactoring effort there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #20 from Martin Renvoize --- Created attachment 98439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98439=edit Bug 24474: Add ReturnLostItem handling for paypal payments This patch adds a call to ReturnLostItem for Lost Item payments taken via OPAC online payments through PayPal. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #19 from Martin Renvoize --- Created attachment 98438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98438=edit Bug 24474: Add ReturnLostItem handling for staff client payments This patch adds a call to ReturnLostItem for Lost Item payments taken via the staff client. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #18 from Martin Renvoize --- Created attachment 98437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98437=edit Bug 24474: Add ReturnLostItem handling for SIP Payments This patch adds a call to ReturnLostItem for Lost Item payments taken via SIP machines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #17 from Martin Renvoize --- Created attachment 98436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98436=edit Bug 24474: Drop `ReturnLostItem` from ::Account classes This patche removes the ReturnLostItem calls from Koha::Account->pay and Koha::Account::Line->apply methods. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #16 from Jonathan Druart --- (In reply to Chris Cormack from comment #13) > Then if you renew that item, > * then that makes it no longer lost - correct > * removes the charge - correct >- Now the code goes on, there is a paid charge for lost, I will return it > - not correct Martin, I think these steps are what my tests are doing and that they could be use to prove that a fix is correct. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Jonathan Druart changed: What|Removed |Added Attachment #98393|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Comment on attachment 98393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98393 Bug 24474: A try That really did not make sense! :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #14 from Martin Renvoize --- Thanks for the clarifications guys.. it's a real action at a distance issue I see.. hmm, I agree it would be best to strip out the behaviour from the accounts code and push it up a level into the controllers really. I'll have a go at that when I'm fresh tomorrow.. unless anyone else wants to give it a punt.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #13 from Chris Cormack --- Thats right, you have an item that is marked lost. But the library wants that to stay on the persons card. Not be removed, so it is still out to them. Then if you renew that item, * then that makes it no longer lost - correct * removes the charge - correct - Now the code goes on, there is a paid charge for lost, I will return it - not correct IE when you renew a lost item, the code in the accounts now returns it, because it has a paid for charge. I feel like having circulation actions inside the accounts module is a bad thing anyway, but certainly creates unexpected (and wrong) behaviour in this case -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #12 from Katrin Fischer --- WhenLostChargeReplacementFee DefaultLongOverdueChargeValue MarkLostItemsAsReturned Are the ones I am thinking of. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #11 from Katrin Fischer --- .. or maybe they just don't charge a fee. (no lost charge). I really wish our lost handling options were less confusing and more in one spot. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #10 from Katrin Fischer --- From what I understand: - the LOST charge is applied, but the library decided to not auto-return the item (config wise) - then renewing the item returns it I'll have to give this a go in testing, but I think we need to verify and try stuff here. Would be great to get a step by step by Aleisha if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
--- Comment #9 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #7)
> I gave a try to this, wrote the test then try to fix it.
>
> But my understanding of the code leads me to abandon. I do not understand
> why there are 3 calls to ReturnLostItem:
>
> Koha/Account.pm:C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account.pm:C4::Circulation::ReturnLostItem(
> $self->{patron_id}, $fine->itemnumber ) unless $checkout;
> Koha/Account/Line.pm:C4::Circulation::ReturnLostItem(
> $self->borrowernumber, $debit->itemnumber );
>
> That seems wrong to me.
>
> So I guess my test will not cover all the cases. Hope it could help as a
> start anyway.
Not sure I understand what you tried here Jonathan.. looking like you're simply
adding a second check to see if the item is still checked out before returning
it..
I think we need clarification on the requested behaviour before continuing
here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #8 from Martin Renvoize --- (In reply to Aleisha Amohia from comment #0) > This was a bug introduced by Bug 22982. > > "Hey all, this patch is causing problems for some of our libraries because > it's been assumed that lost items with no attached charge should > automatically be returned. I don't understand what you mean by this.. the code in bug 22982 only applies to LOST charges.. I'm not sure I can see how items are being returned when no lost item charge is attached in the first place? > This is not always the desired behaviour - we have one case where the > library wants to keep lost items on a patron's record, and another case > where a checked out lost item will be renewed, but the amount outstanding is > zero, so the item gets returned. So, this is where there are LOST charges being applied right? Instead of automatically returning the item on lost charge payment we want to allow for configurable state changes instead.. or am I misunderstanding the problem/request? > > These are edge cases, but the assumptions in this patch do not consider > them, and are causing problems. Is there a workaround? Or perhaps a better > way of doing this patch that can allow for the cases of 'renewing a lost > item' or 'wanting to keep a lost item on the checkouts record'? A solution > that avoids doing circulation actions in the accounts modules as this patch > does would be ideal." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #7 from Jonathan Druart
---
I gave a try to this, wrote the test then try to fix it.
But my understanding of the code leads me to abandon. I do not understand why
there are 3 calls to ReturnLostItem:
Koha/Account.pm:C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account.pm:C4::Circulation::ReturnLostItem(
$self->{patron_id}, $fine->itemnumber ) unless $checkout;
Koha/Account/Line.pm:C4::Circulation::ReturnLostItem(
$self->borrowernumber, $debit->itemnumber );
That seems wrong to me.
So I guess my test will not cover all the cases. Hope it could help as a start
anyway.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #5 from Jonathan Druart --- Created attachment 98392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98392=edit Bug 24474: Add tests This does the following using the interface: - Unselect all the options from MarkLostItemsAsReturned - Check an item out - Create a manual invoice LOST for the checked in item - Pay the fine (Make a payment> Pay > Confirm) - Renew the item => Item is checked in (NOT EXPECTED) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #6 from Jonathan Druart --- Created attachment 98393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98393=edit Bug 24474: A try This does not work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #4 from Aleisha Amohia --- (In reply to Martin Renvoize from comment #1) > Are you intending to work on this Aleisha.. just checking before I look at > it myself. Thanks for checking Martin, feel free to work on this yourself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #3 from Katrin Fischer --- Hm, if a library doesn't charge a lost fee and somene renews an item marked lost - would it still return it? I think the renewal part is what worries me most here and I think we shoudl never return an item on renewal. On paying the fine off, I can see why someone would want it and that seems ok to be pref driven. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 --- Comment #2 from Martin Renvoize --- It feels like yet another value to add to the `MarkLostItemsAsReturned` system preference to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- Are you intending to work on this Aleisha.. just checking before I look at it myself. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24474] Lost items that are checked out are always returned, even when attempting to renew them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24474 Chris Cormack changed: What|Removed |Added Summary|Lost items that are checked |Lost items that are checked |out are always returned |out are always returned, ||even when attempting to ||renew them CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
