[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Kyle M Hall changed: What|Removed |Added Blocks||28464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28464 [Bug 28464] Cancelling a wiating hold via SIP returns a failed response even when cancellation succeeds -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #17 from Joy Nelson --- fix for 19.11.x tests pushed to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #16 from Joy Nelson --- fix for 19.11.x tests pushed to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #15 from Jonathan Druart --- Created attachment 102518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102518&action=edit Bug 24553: Fix tests for 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.05 released in|| Status|Pushed to master|Pushed to stable --- Comment #14 from Joy Nelson --- backported to 19.11.x for 19.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #13 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Marcel de Rooy changed: What|Removed |Added Attachment #101096|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 101112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101112&action=edit Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron The drop_hold routine was using the wrong parameter for item info in the patron's array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable holds To test: 1 - Apply unit tests patch 2 - prove -v t/db_dependent/SIP/ILS.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/SIP/ILS.t 6 - It passes! You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold and check the messages, test coverage is improved by this patch and should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Marcel de Rooy changed: What|Removed |Added Attachment #101095|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 10 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10&action=edit Bug 24553: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #10 from Kyle M Hall --- Created attachment 101096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101096&action=edit Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron The drop_hold routine was using the wrong parameter for item info in the patron's array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable holds To test: 1 - Apply unit tests patch 2 - prove -v t/db_dependent/SIP/ILS.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/SIP/ILS.t 6 - It passes! You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold and check the messages, test coverage is improved by this patch and should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Kyle M Hall changed: What|Removed |Added Attachment #100891|0 |1 is obsolete|| Attachment #100892|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 101095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101095&action=edit Bug 24553: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #99593|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 100892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100892&action=edit Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron The drop_hold routine was using the wrong parameter for item info in the patron's array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable holds To test: 1 - Apply unit tests patch 2 - prove -v t/db_dependent/SIP/ILS.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/SIP/ILS.t 6 - It passes! You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold and check the messages, test coverage is improved by this patch and should be sufficient for testing Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #99592|0 |1 is obsolete|| --- Comment #7 from Andrew Fuerste-Henry --- Created attachment 100891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100891&action=edit Bug 24553: Unit tests Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #6 from Nick Clemens --- (In reply to Jonathan Druart from comment #5) > Those tests are 90% a copy of the subtest "cancel_hold" from > t/db_dependent/SIP/Transaction.t, that is actually testing drop_hold... Yes, but cancel_hold calls drop_hold - and does other things. These tests test that all the extra stuff happens - the other tests test that function specifically. We can move those tests here, but they cover two different modules - it seemed reasonable to cover the functions indivudally in their own files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #5 from Jonathan Druart --- Those tests are 90% a copy of the subtest "cancel_hold" from t/db_dependent/SIP/Transaction.t, that is actually testing drop_hold... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #4 from Nick Clemens --- (In reply to Jonathan Druart from comment #1) > What is the point of SIP::Patron->drop_hold? Are we maintaining a list of > holds to avoid fetching them several times? Indeed, we are. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #3 from Nick Clemens --- Created attachment 99593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99593&action=edit Bug 24553: Use 'barcode' not 'item_id' when removing hold from SIP patron The drop_hold routine was using the wrong parameter for item info in the patron's array of holds. We store it as 'barcode' not 'item_id'. This is true for both waiting and unavailable holds To test: 1 - Apply unit tests patch 2 - prove -v t/db_dependent/SIP/ILS.t 3 - It fails 4 - Apply second patch 5 - prove -v t/db_dependent/SIP/ILS.t 6 - It passes! You can also see bug 24175 - you cna hack sip_cli_emulator to allow cancelling a hold and check the messages, test coverage is improved by this patch and should be sufficient for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 --- Comment #2 from Nick Clemens --- Created attachment 99592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99592&action=edit Bug 24553: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #1 from Jonathan Druart --- What is the point of SIP::Patron->drop_hold? Are we maintaining a list of holds to avoid fetching them several times? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24553] Cancelling hold via SIP returns a failed response even when cancellation succeeds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24553 Nick Clemens changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
