[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #14 from Lucas Gass --- does not apply cleanly to 20.05.x, no backport please rebase if needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #13 from Jonathan Druart --- (In reply to Jonathan Druart from comment #12) > Created attachment 111371 [details] [review] > Bug 24598: Remove warning from test > > t/db_dependent/Koha/Items.t .. 6/12 Use of uninitialized value in string eq > at /kohadevbox/koha/C4/Circulation.pm line 1460. Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #12 from Jonathan Druart --- Created attachment 111371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111371&action=edit Bug 24598: Remove warning from test t/db_dependent/Koha/Items.t .. 6/12 Use of uninitialized value in string eq at /kohadevbox/koha/C4/Circulation.pm line 1460. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #11 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Marcel de Rooy changed: What|Removed |Added Attachment #110890|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 111061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111061&action=edit Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Marcel de Rooy changed: What|Removed |Added Attachment #110889|0 |1 is obsolete|| --- Comment #9 from Marcel de Rooy --- Created attachment 111060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111060&action=edit Bug 24598: Add tests Signed-off-by: Fridolin Somers Signed-off-by: Marcel de Rooy [EDIT] 49 to 50 tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #7 from Fridolin SOMERS --- Nice work. Test plan and unit test are OK. I add to rebase a bit unit test patch. Also changed a bit the test plan : - 1) Place an item on hold at Library A for Patron 1 at Library B + 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B Because I forgot twice to change pickup library ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Attachment #108003|0 |1 is obsolete|| --- Comment #6 from Fridolin SOMERS --- Created attachment 110890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110890&action=edit Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item at Library A on hold for Patron 1 of Library B with pickup library at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Attachment #108002|0 |1 is obsolete|| --- Comment #5 from Fridolin SOMERS --- Created attachment 110889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110889&action=edit Bug 24598: Add tests Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Fridolin SOMERS changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Amit Gupta changed: What|Removed |Added CC||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Daniel Gaghan changed: What|Removed |Added CC||daniel.gaghan@pueblolibrary ||.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #4 from Jonathan Druart --- Created attachment 108003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108003&action=edit Bug 24598: Complete transfer for hold if checked out When an item that has triggered a hold is in transit to a library, if the item is accidently shelved instead of scanned at the pickup library, and then checked out to another patron, the holds shows the item still in transit in the status, but says that it is waiting at the library, and the since date has vanished! Test plan: 1) Place an item on hold at Library A for Patron 1 at Library B 2) Check in the item at Library A to trigger the hold transfer 3) At Library B, check out the item to Patron 2 (click Yes) => The hold is not marked as in transit and is back to priority 1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #3 from Jonathan Druart --- Created attachment 108002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108002&action=edit Bug 24598: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > This reads a bit similar to bug 11722, could these be duplicates? Not sure. That was 6 years ago. This gives a better explanation, if it is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- This reads a bit similar to bug 11722, could these be duplicates? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24598] Hold not reset properly if checked out to another patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24598 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
