[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-04-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Michelle Spinney  changed:

   What|Removed |Added

 CC||mspin...@clamsnet.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |In Discussion

--- Comment #73 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #66)
> We now have the base for a booking feature in Koha. It could make sense to
> build this functionality on top of that now.

I've rebased this for main because one of our library's uses it in production,
bu I absolutely agree. Setting to In Discussion until someone has capacity to
take that on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148298|0   |1
is obsolete||

--- Comment #72 from Aleisha Amohia  ---
Created attachment 162479
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162479=edit
Bug 24718: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148297|0   |1
is obsolete||

--- Comment #71 from Aleisha Amohia  ---
Created attachment 162478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162478=edit
Bug 24718: Holds API fixes for datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148296|0   |1
is obsolete||

--- Comment #70 from Aleisha Amohia  ---
Created attachment 162477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162477=edit
Bug 24718: Hour based holds on OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148295|0   |1
is obsolete||

--- Comment #69 from Aleisha Amohia  ---
Created attachment 162476
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162476=edit
Bug 24718: Hour based holds on staff client

Tests in t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148294|0   |1
is obsolete||

--- Comment #68 from Aleisha Amohia  ---
Created attachment 162475
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162475=edit
Bug 24718: Modify reserves.reservedate and expirationdate to use datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-02-26 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #148293|0   |1
is obsolete||

--- Comment #67 from Aleisha Amohia  ---
Created attachment 162474
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162474=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2024-01-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #66 from Katrin Fischer  ---
We now have the base for a booking feature in Koha. It could make sense to
build this functionality on top of that now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-08-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Emmi Takkinen  changed:

   What|Removed |Added

 CC||emmi.takki...@koha-suomi.fi
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #65 from Emmi Takkinen  ---
There is a minor merge conflict in t/db_dependent/Holds.t while trying to apply
patch "Bug 24718: Hour based holds on staff client". I was able to resolve
this, but Koha now dies on Internal Server Error. Looking from locks there are
these lines:

Global symbol "$expdate" requires explicit package name (did you forget to
declare "my $expdate"?) at ../Koha/C4/Reserves.pm line 216." (and several
others)

Type of arg 1 to List::MoreUtils::XS::any must be block or sub {} (not
reference constructor) at ../Koha/C4/Reserves.pm line 1848, near
"$ignore_borrowers ;" 

Setting this status as "Patch doesn't apply".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126561|0   |1
is obsolete||

--- Comment #64 from Aleisha Amohia  ---
Created attachment 148298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148298=edit
Bug 24718: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126564|0   |1
is obsolete||

--- Comment #63 from Aleisha Amohia  ---
Created attachment 148297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148297=edit
Bug 24718: Holds API fixes for datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126563|0   |1
is obsolete||

--- Comment #62 from Aleisha Amohia  ---
Created attachment 148296
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148296=edit
Bug 24718: Hour based holds on OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126562|0   |1
is obsolete||

--- Comment #61 from Aleisha Amohia  ---
Created attachment 148295
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148295=edit
Bug 24718: Hour based holds on staff client

Tests in t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126560|0   |1
is obsolete||

--- Comment #60 from Aleisha Amohia  ---
Created attachment 148294
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148294=edit
Bug 24718: Modify reserves.reservedate and expirationdate to use datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2023-03-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #126559|0   |1
is obsolete||

--- Comment #59 from Aleisha Amohia  ---
Created attachment 148293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148293=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #58 from Aleisha Amohia  ---
I have rebased the patches and fixed the API test that was failing.

Note I removed the functionality to place hour-based holds on the OPAC because
it should use the new flatpickr plugin which still needs work Bug 29212 . That
can be added later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110303|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110091|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110090|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110089|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110088|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110087|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110086|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110085|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #57 from Aleisha Amohia  ---
Created attachment 126564
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126564=edit
Bug 24718: Holds API fixes for datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #56 from Aleisha Amohia  ---
Created attachment 126563
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126563=edit
Bug 24718: Hour based holds on OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #55 from Aleisha Amohia  ---
Created attachment 126562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126562=edit
Bug 24718: Hour based holds on staff client

Tests in t/db_dependent/Holds.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #54 from Aleisha Amohia  ---
Created attachment 126561
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126561=edit
Bug 24718: Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #53 from Aleisha Amohia  ---
Created attachment 126560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126560=edit
Bug 24718: Modify reserves.reservedate and expirationdate to use datetime

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-10-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110084|0   |1
is obsolete||

--- Comment #52 from Aleisha Amohia  ---
Created attachment 126559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126559=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=29002

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #51 from Martin Renvoize  ---
This looks interesting.. could we get a rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #50 from Tomás Cohen Arazi  ---
Without having looked at the patchset and how the API is to be used, it feels
like we should be adding a new (optional) field for either date-time case, or
the time portion. Depending on the use we would make of it.

We could also leave the route alone and have a special route for hourly holds
/holds/hourly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #110161|0   |1
is obsolete||

--- Comment #49 from Aleisha Amohia  ---
Created attachment 110303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110303=edit
Bug 24718: (follow-up) Attempting to fix Koha REST holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Donna  changed:

   What|Removed |Added

 CC||bwsdo...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #48 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #46)
> Nick, I didn't really know what to do other than remove dateonly flags from
> all the date options. I don't think it worked. Feel free to amend that last
> patch on my behalf.

Patch amended. Just needed to set the format to date-time everywhere - still
one failure, but it looks like that comes from C4::Reserves::AddReserve - the
time part is set based on the HourBasedHolds pref, so we need to mock that or
change the assumptions I tihnk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Nick Clemens  changed:

   What|Removed |Added

 Attachment #110137|0   |1
is obsolete||

--- Comment #47 from Nick Clemens  ---
Created attachment 110161
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110161=edit
Bug 24718: (follow-up) Attempting to fix Koha REST holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #46 from Aleisha Amohia  ---
Nick, I didn't really know what to do other than remove dateonly flags from all
the date options. I don't think it worked. Feel free to amend that last patch
on my behalf.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #45 from Aleisha Amohia  ---
Created attachment 110137
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110137=edit
Bug 24718: (follow-up) Attempting to fix Koha REST holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #44 from Aleisha Amohia  ---
(In reply to Nick Clemens from comment #42)

> It may be the problem is in api/v1/swagger/definitions/hold.json where
> hold_date and expiration_date are defined as "format": "date" and may need
> to be "date-time" with these patches?

Thank you for the suggestion, I'll try this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Nick Clemens  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #43 from Nick Clemens  ---
Created attachment 110098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110098=edit
Test failure after patches

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #42 from Nick Clemens  ---
(In reply to Aleisha Amohia from comment #41)
> > t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use
> > 23:59:59 if time not specified? I am not sure how it is handled for 
> > checkouts
> 
> The same tests in this test file fail for me, before and after the patches,
> so I can't test this one. Can you please paste the output for what fails and
> be more specific when you say 'should we accept a simple date'?
> 
> Thanks!

I filed bug 26463 - the tests fail for me if AllowHoldPolicyOverride is set,
otherwise they pass before these patches.

I will attach a list of failures I see after the patches.

By 'simple date' I meant we should not expect/require the time part of the
date, but fall back to a default. Though I am not sure where I saw that as
needed

It may be the problem is in api/v1/swagger/definitions/hold.json where
hold_date and expiration_date are defined as "format": "date" and may need to
be "date-time" with these patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106275|0   |1
is obsolete||

--- Comment #39 from Aleisha Amohia  ---
Created attachment 110090
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110090=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #41 from Aleisha Amohia  ---
(In reply to Nick Clemens from comment #32)
> Hi Aleisha,
> 
> The comment on the syspref says jobs will be run hourly - probably should
> say something like:
> NOTE: This system preference requires the misc/cronjobs/holds/ cronjobs. Ask
> your system administrator to schedule them. 

Fixed 

> 
> When confirming a hold the max pickup delay is added for days correctly,
> however, the time part is set to 00:00:00 - I thin it should be preserved
> from original setting or set to 23:59:59

Fixed (note, this is for when setting a hold as waiting). It now preserves
minutes and seconds

> 
> t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use
> 23:59:59 if time not specified? I am not sure how it is handled for checkouts

The same tests in this test file fail for me, before and after the patches, so
I can't test this one. Can you please paste the output for what fails and be
more specific when you say 'should we accept a simple date'?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #40 from Aleisha Amohia  ---
Created attachment 110091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110091=edit
Bug 24718: (follow-up) Update syspref description, fix expdate time when
setting waiting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106272|0   |1
is obsolete||

--- Comment #36 from Aleisha Amohia  ---
Created attachment 110087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110087=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106271|0   |1
is obsolete||

--- Comment #35 from Aleisha Amohia  ---
Created attachment 110086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110086=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106274|0   |1
is obsolete||

--- Comment #38 from Aleisha Amohia  ---
Created attachment 110089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110089=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106273|0   |1
is obsolete||

--- Comment #37 from Aleisha Amohia  ---
Created attachment 110088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110088=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #106270|0   |1
is obsolete||

--- Comment #34 from Aleisha Amohia  ---
Created attachment 110085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110085=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103549|0   |1
is obsolete||

--- Comment #33 from Aleisha Amohia  ---
Created attachment 110084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110084=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||n...@bywatersolutions.com

--- Comment #32 from Nick Clemens  ---
Hi Aleisha,

The comment on the syspref says jobs will be run hourly - probably should say
something like:
NOTE: This system preference requires the misc/cronjobs/holds/ cronjobs. Ask
your system administrator to schedule them. 

When confirming a hold the max pickup delay is added for days correctly,
however, the time part is set to 00:00:00 - I thin it should be preserved from
original setting or set to 23:59:59

t/db_dependent/api/v1/holds.t fails - should we accept a simple date and use
23:59:59 if time not specified? I am not sure how it is handled for checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103553|0   |1
is obsolete||

--- Comment #29 from Aleisha Amohia  ---
Created attachment 106273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106273=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103555|0   |1
is obsolete||

--- Comment #31 from Aleisha Amohia  ---
Created attachment 106275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106275=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103552|0   |1
is obsolete||

--- Comment #28 from Aleisha Amohia  ---
Created attachment 106272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106272=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103554|0   |1
is obsolete||

--- Comment #30 from Aleisha Amohia  ---
Created attachment 106274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106274=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103551|0   |1
is obsolete||

--- Comment #27 from Aleisha Amohia  ---
Created attachment 106271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106271=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-06-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Attachment #103550|0   |1
is obsolete||

--- Comment #26 from Aleisha Amohia  ---
Created attachment 106270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106270=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks|20453   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
[Bug 20453] Send notification when hold is cancelled by librarian
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Attachment #103522|0   |1
is obsolete||

--- Comment #25 from David Nind  ---
Created attachment 103555
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103555=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99542|0   |1
is obsolete||

--- Comment #21 from David Nind  ---
Created attachment 103551
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103551=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99548|0   |1
is obsolete||

--- Comment #23 from David Nind  ---
Created attachment 103553
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103553=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99543|0   |1
is obsolete||

--- Comment #22 from David Nind  ---
Created attachment 103552
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103552=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Attachment #103521|0   |1
is obsolete||

--- Comment #24 from David Nind  ---
Created attachment 103554
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103554=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99541|0   |1
is obsolete||

--- Comment #20 from David Nind  ---
Created attachment 103550
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103550=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

  Attachment #99540|0   |1
is obsolete||

--- Comment #19 from David Nind  ---
Created attachment 103549
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103549=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #18 from Aleisha Amohia  ---
Created attachment 103522
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103522=edit
Bug 24718: (follow-up) Updated schema file

For sandboxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #17 from Aleisha Amohia  ---
Created attachment 103521
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103521=edit
Bug 24718: (follow-up) Removing old code

This solves the JS error

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-04-22 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Failed QA

--- Comment #16 from David Nind  ---
Hi Aleisha.

Everything seems to work as expected according to the test plan.

There is one failed test though (after the patch is applied):

root@40629b80bd10:koha(bz24718)$ prove t/db_dependent/Holds.t
t/db_dependent/Holds.t .. 1/61 
#   Failed test 'holds_placed_today should return a valid borrowernumber'
#   at t/db_dependent/Holds.t line 104.
#  got: '247'
# expected: '246'
t/db_dependent/Holds.t .. 61/61 # Looks like you failed 1 test of 61.
t/db_dependent/Holds.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/61 subtests 

Test Summary Report
---
t/db_dependent/Holds.t (Wstat: 256 Tests: 61 Failed: 1)
  Failed test:  8
  Non-zero exit status: 1
Files=1, Tests=61,  7 wallclock secs ( 0.04 usr  0.00 sys +  5.63 cusr  0.52
csys =  6.19 CPU)
Result: FAIL

In addition, there is also an error happening after the patches are applied
when you go the patrons details page and the holds tab:

> DataTables warning: table id=holds-table - Ajax error. For more information 
> about this error, please see http://datatables.net/tn/7

I've reported this error before on bug 24769 - it only seems to happen for me
when testing ILS-DI bugs, but is now happening for this bug as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #15 from Aleisha Amohia  ---
(In reply to Aleisha Amohia from comment #12)
> The library wanted the ability to specify hours when reserving items for
> patrons, and be able to cancel those reserves - a process of 'booking'
> something for a few hours, with the ability to reject (cancel) the booking.
> The patron would then be notified if the reserve was rejected/cancelled by
> the library (this part is handled in Bug 20453). The cancel_expired_holds.pl
> cronjob can be run hourly to work with this feature. 
> 
> The library only needed the hour-based holds functionality on the staff side
> as their patrons can't placed holds via the OPAC (RequestOnOpac disabled)
> but I have put the functionality on the OPAC side for the option.
> 
> Test plan for Bug 24718: hour-based holds
> 
> You will need two borrowers (Borrower A and B) and a record with items
> (Biblio A)
> 
> 1) Update database, restart memcached

Remember to update dbix files!

> 2) Enable the following sysprefs: RequestOnOpac, AllowHoldDateInFuture,
> OPACAllowHoldDateInFuture, HourBasedHolds
> 3) Log into the OPAC as Borrower A
> 4) Find Biblio A
> 5) Click 'Place a reserve'
> 6) Click 'Show more options'
> 7) Try entering dates in the 'starts on' field and 'not needed after' field.
> Notice you can also enter a time. Leave the start date empty and choose a
> specific end date/time. Confirm the hold
> 8) Confirm the hold is saved with the reserve date set to today/now and the
> expiry date is saved as specified. Notice the time selection is shown.
> 9) Log into the staff interface
> 10) Find Biblio A and place a hold for Borrower B
> 11) Try entering dates in the 'starts on' field and 'expires on' field.
> Notice you can also enter a time. Specify a future start date. Confirm the
> hold
> 12) Confirm your selected date and time shows in the confirmed hold. View
> all of the pages that show holds and confirm they all show the date and time
> correctly.
> 
> Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #14 from Aleisha Amohia  ---
Created attachment 99548
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99548=edit
Bug 24718: Ensuring tests pass

Confirm these tests pass before and after applying patches

t/db_dependent/Holds.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/issue.t
t/db_dependent/Holds/HoldFulfillmentPolicy.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/HoldItemtypeLimit.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Reserves/CancelExpiredReserves.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||20453


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453
[Bug 20453] Send notification when hold is cancelled by librarian
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #13 from Aleisha Amohia  ---
Tests coming

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #12 from Aleisha Amohia  ---
The library wanted the ability to specify hours when reserving items for
patrons, and be able to cancel those reserves - a process of 'booking'
something for a few hours, with the ability to reject (cancel) the booking. The
patron would then be notified if the reserve was rejected/cancelled by the
library (this part is handled in Bug 20453). The cancel_expired_holds.pl
cronjob can be run hourly to work with this feature. 

The library only needed the hour-based holds functionality on the staff side as
their patrons can't placed holds via the OPAC (RequestOnOpac disabled) but I
have put the functionality on the OPAC side for the option.

Test plan for Bug 24718: hour-based holds

You will need two borrowers (Borrower A and B) and a record with items (Biblio
A)

1) Update database, restart memcached
2) Enable the following sysprefs: RequestOnOpac, AllowHoldDateInFuture,
OPACAllowHoldDateInFuture, HourBasedHolds
3) Log into the OPAC as Borrower A
4) Find Biblio A
5) Click 'Place a reserve'
6) Click 'Show more options'
7) Try entering dates in the 'starts on' field and 'not needed after' field.
Notice you can also enter a time. Leave the start date empty and choose a
specific end date/time. Confirm the hold
8) Confirm the hold is saved with the reserve date set to today/now and the
expiry date is saved as specified. Notice the time selection is shown.
9) Log into the staff interface
10) Find Biblio A and place a hold for Borrower B
11) Try entering dates in the 'starts on' field and 'expires on' field. Notice
you can also enter a time. Specify a future start date. Confirm the hold
12) Confirm your selected date and time shows in the confirmed hold. View all
of the pages that show holds and confirm they all show the date and time
correctly.

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #99545|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #99544|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20453

--- Comment #11 from Katrin Fischer  ---
If it goes the direction of the other bug, I think not having it necessarily
depend on hourly loans would be nice. Maybe we could also do it later. I am
adding a see also for now and will let you think it over to what works best
here (don't know much about the feature written yet!) :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #10 from Aleisha Amohia  ---
Hmm I see. I guess could obselete the final two patches here and put them on
Bug 24053 so that the notice is always sent, without depending on a syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #9 from Katrin Fischer  ---
Ok thx - I was thinking of something like bug 20453.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #8 from Aleisha Amohia  ---
(In reply to Katrin Fischer from comment #7)
> Hi Aleisha, just reading the commit subjects I wonder if the notice for
> cancelling holds could be a separate feature?

Not really, the sending of notices was part of the feature we wrote for this
library and depends on a syspref that this feature introduces. This will be
explain in the test plan I'm currently writing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
Hi Aleisha, just reading the commit subjects I wonder if the notice for
cancelling holds could be a separate feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #6 from Aleisha Amohia  ---
Created attachment 99545
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99545=edit
Bug 24718: Send notice when cancelling a hold from intranet

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #5 from Aleisha Amohia  ---
Created attachment 99544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99544=edit
Bug 24718: Adding notice to be sent when cancelling holds

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #1 from Aleisha Amohia  ---
Created attachment 99540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99540=edit
Bug 24718: Introducing HourBasedHolds system preference

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #4 from Aleisha Amohia  ---
Created attachment 99543
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99543=edit
Bug 24718: Get OPAC working with datetimepicker and HourBasedHolds

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #3 from Aleisha Amohia  ---
Created attachment 99542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99542=edit
Bug 24718: Get templates working with HourBasedHolds

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

--- Comment #2 from Aleisha Amohia  ---
Created attachment 99541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99541=edit
Bug 24718: Get reservedate and expirationdate to use datetime

Sponsored-by: Waikato Institute of Technology

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 24718] Introduce hour-based holds

2020-02-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718

Aleisha Amohia  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz
   |ity.org |
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/