[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #18 from Joy Nelson --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind changed: What|Removed |Added Text to go in the||This fixes a problem release notes||introduced by another patch ||in this release cycle. The ||patron's hold page now ||correctly lists holds where ||holds are placed using ||ILS-DI (and in some other ||situations). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #17 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #104296|0 |1 is obsolete|| --- Comment #16 from Tomás Cohen Arazi --- Created attachment 104300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104300=edit Better tests... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 104298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104298=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 104297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104297=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #13 from Tomás Cohen Arazi --- Created attachment 104296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104296=edit Bug 24769: Regression tests When regressions are found, we introduce regression tests :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103644|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added Attachment #103643|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #12 from David Nind --- Thanks Jonathan for writing the patches to fix this! This is the test plan I used: 1) Place a hold for a patron. 2) Check the patron's details page and holds tab, the hold is listed. 3) Enable the ILS-DI system preference (ILS-DI). 4) Use ILS-DI to place a hold for a patron, for example: http://127.0.0.1:8080/cgi-bin/koha/ilsdi.pl?service=HoldTitle_id=19_id=12_location='127.0.0.1' (where: 19 = a patron id and bib_id = 12 a bibliographical record) 5) On the staff client go to Patrons > [Patron hold placed for] > Details > Holds tab. 6) An error is displayed in a pop-up window: DataTables warning: table id=holds-table - Ajax error. For more information about this error, please see http://datatables.net/tn/7 7) After clicking on OK for the error message, the holds tab no longer lists any holds - even though 2 should be listed. 8) Go to the holds history for the patron and note that the Library for the hold placed using ILS-DI is blank. 9) Go to the bibliographical record and then holds - click update hold(s). Go to the patron's details page and click on the holds tab - this now displays correctly. 10) Apply the patch. 11) Repeat steps 4-5 (place a hold for another item). 12) The list of holds for the patron should display as expected with no errors. 13) Sign-off! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind changed: What|Removed |Added Attachment #103638|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 103644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103644=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind changed: What|Removed |Added Attachment #103637|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 103643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103643=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart changed: What|Removed |Added Severity|normal |major Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org Keywords||rel_20_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart changed: What|Removed |Added Attachment #103636|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 103637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103637=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #9 from Jonathan Druart --- Created attachment 103638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103638=edit Bug 24769: (bug 14711 follow-up 2) Fix typo in parameter name for AddReserve This patch fixes 2 other occurrences. The first one is in POD of AddReserve, the other one fixes SIP code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #7 from Jonathan Druart --- Created attachment 103636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103636=edit Bug 24769: (bug 14711 follow-up) Fix typo in parameter name for AddReserve The parameter is branchcode, not branch. Test plan: Place a hold on a biblio using ILSDI Check that the branchcode is correctly filled with the patron's library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 Jonathan Druart changed: What|Removed |Added Depends on||14711 CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Caused by commit 11b44869d95c47a7e6daec8dcb124762a9ee0026 Bug 14711: Change prototype for AddReserve - pass a hashref Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 --- Comment #5 from David Nind --- (In reply to David Nind from comment #4) > Error also occurring after applying the patches for bug 24718 > > That is not an ILS-DI related bug, so seems wider. > > Will change title to reflect this. Aleisha solved resolved this with a follow-up patch to resolve the JavaScript error, but it still exists for holds placed using ILS-DI. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 David Nind changed: What|Removed |Added Summary|DataTable error on patron |DataTable error on patron |hold page when hold placed |hold page when hold placed |using ILS-DI|(ILS-DI and other bugs) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
