[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Blocks||27822 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27822 [Bug 27822] Wrong systempreference for AddressFormat in 20.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Blocks||24897 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24897 [Bug 24897] Remove es-ES installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Blocks||27625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27625 [Bug 27625] Remove uk-UA installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Blocks||27624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27624 [Bug 27624] Remove ru-RU installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Blocks||27623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27623 [Bug 27623] Remove pl-PL installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Blocks||27622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27622 [Bug 27622] Remove nb-NO installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Blocks||27621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 [Bug 27621] Remove it-IT installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Blocks||27620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 [Bug 27620] Remove fr-CA installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Blocks||27619 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 [Bug 27619] Remove de-DE installer data -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #39 from Martin Renvoize --- Awesome work everyone, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #38 from Martin Renvoize --- Awesome work everyone, thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #37 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target, | |RM_priority | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #36 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #35 from Jonathan Druart --- Here we are! Simple and efficient, great work :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Katrin Fischer changed: What|Removed |Added Attachment #108166|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108946=edit Bug 24973: Load custom localization file It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. Moved corresponding files for de-DE, it-IT, nb-NO and completed es-ES To test: 1) Apply the patch 2) Install es-ES/de-DE/it-IT/nb-NO translation (any lang) ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #33 from Martin Renvoize --- Works as expected as I understand it.. Signing off and pushing to Katrin's pile for QA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added Attachment #108130|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 108166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108166=edit Bug 24973: Load custom localization file It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. Moved corresponding files for de-DE, it-IT, nb-NO and completed es-ES To test: 1) Apply the patch 2) Install es-ES/de-DE/it-IT/nb-NO translation (any lang) ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #31 from Martin Renvoize --- Excellent, thanks Bernardo, looks good now I can see the renames :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973
--- Comment #30 from Bernardo Gonzalez Kriegel ---
(In reply to Bernardo Gonzalez Kriegel from comment #29)
> (In reply to Martin Renvoize from comment #27)
> >
> > Bernardo.. do you still have the de-DE, it-IT parts of the patch somewhere?
> >
> > If so, I can signoff and we can move into QA
>
> Hi Martin, uploaded patch with all changes this time.
> Thanks!
It's the same patch, sorry.
But if you look at the details, you will see that some of the files are simply
renamed
rename installer/data/mysql/{de-DE/mandatory/system_preferences.sql =>
localization/de-DE/custom.sql} (98%)
rename installer/data/mysql/{de-DE/mandatory/system_preferences.txt =>
localization/de-DE/custom.txt} (100%)
rename installer/data/mysql/{it-IT/necessari/system_preferences.sql =>
localization/it-IT/custom.sql} (99%)
rename installer/data/mysql/{nb-NO/1-Obligatorisk/system_preferences.sql =>
localization/nb-NO/custom.sql} (100%)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #29 from Bernardo Gonzalez Kriegel --- (In reply to Martin Renvoize from comment #27) > > Bernardo.. do you still have the de-DE, it-IT parts of the patch somewhere? > > If so, I can signoff and we can move into QA Hi Martin, uploaded patch with all changes this time. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #105032|0 |1 is obsolete|| --- Comment #28 from Bernardo Gonzalez Kriegel --- Created attachment 108130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108130=edit Bug 24973: Load custom localization file It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. Moved corresponding files for de-DE, it-IT, nb-NO and completed es-ES To test: 1) Apply the patch 2) Install es-ES/de-DE/it-IT/nb-NO translation (any lang) ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #27 from Martin Renvoize --- (In reply to Martin Renvoize from comment #26) > (In reply to Bernardo Gonzalez Kriegel from comment #24) > > (In reply to Jonathan Druart from comment #22) > > > Switching to NSO to get feedback on the POC. > > > > Uploaded revised patch, now include files for de-DE, it-IT and nb-NO, > > taken from their language dirs. > > > > With something like this de-DE is covered and main dir could be removed. > > it-IT needs UNIMARC, more work to do > > nb-NO uses NORMARC, this case needs more thinking > > > > > > But any future language can be added there to have the few customizations > > deemed essential by its maintainer. > > > > If this approach is accepted we need to change the Bug description. > > This looks great to me and seems to achieve what's desired.. but I'm not the > target audience so I'm not comfortable doing a QA step.. I suppose doing the > SO would politely push it into Katrins pile. One note though.. I don't see > the additional languages you suggest you added in the above patch? Bernardo.. do you still have the de-DE, it-IT parts of the patch somewhere? If so, I can signoff and we can move into QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #26 from Martin Renvoize --- (In reply to Bernardo Gonzalez Kriegel from comment #24) > (In reply to Jonathan Druart from comment #22) > > Switching to NSO to get feedback on the POC. > > Uploaded revised patch, now include files for de-DE, it-IT and nb-NO, > taken from their language dirs. > > With something like this de-DE is covered and main dir could be removed. > it-IT needs UNIMARC, more work to do > nb-NO uses NORMARC, this case needs more thinking > > > But any future language can be added there to have the few customizations > deemed essential by its maintainer. > > If this approach is accepted we need to change the Bug description. This looks great to me and seems to achieve what's desired.. but I'm not the target audience so I'm not comfortable doing a QA step.. I suppose doing the SO would politely push it into Katrins pile. One note though.. I don't see the additional languages you suggest you added in the above patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Keywords||RM_priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #25 from Magnus Enger --- (In reply to Bernardo Gonzalez Kriegel from comment #24) > nb-NO uses NORMARC, this case needs more thinking NORMARC is actually dead (Bug 18984), no new sites should be created with NORMARC as the MARC flavour. New sites should just use the default English MARC 21 frameworks. (Existing sites will continue to use NORMARC a bit longer, but hopefully we will convert to MARC 21 some time before the end of the year.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #24 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #22) > Switching to NSO to get feedback on the POC. Uploaded revised patch, now include files for de-DE, it-IT and nb-NO, taken from their language dirs. With something like this de-DE is covered and main dir could be removed. it-IT needs UNIMARC, more work to do nb-NO uses NORMARC, this case needs more thinking But any future language can be added there to have the few customizations deemed essential by its maintainer. If this approach is accepted we need to change the Bug description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #104971|0 |1 is obsolete|| --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 105032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105032=edit Bug 24973: Load custom localization file It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. Moved corresponding files for de-DE, it-IT, nb-NO and completed es-ES To test: 1) Apply the patch 2) Install es-ES/de-DE/it-IT/nb-NO translation (any lang) ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #22 from Jonathan Druart --- Switching to NSO to get feedback on the POC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_11_target --- Comment #21 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #18) > (In reply to Jonathan Druart from comment #17) > > We could have a "localization" directory with common files (from Koha > > codebase) to have some localization stuffs set by default. > > localization/es-ES de-DE, etc. > > Then an empty localization/custom directory that we would look up to find > > .sql files. > > You mean something like: > [...] Yes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #20 from Bernardo Gonzalez Kriegel --- New patch, new proposal. One custom SQL file for each language in a new dir, untranslatable of course. It's ignored for english. Please tell me what you think :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103073|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103074|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103072|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103075|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #103071|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 104971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104971=edit Bug 24973: Load custom localization file This is a working POC patch It adds a new localization directory that could host a custom SQL file for each language, xx-YY/custom.sql This will be the last file to be loaded at install time, it can be used to set any difference from default values. It can't be deselected at install time. To test: 1) Apply the patch 2) Install es-ES translation ( cd misc/translation; ./translate install es-ES ) 3) Do a clean install using es-ES 4) After all files have been loaded check: * A new section labeled "Localization data added" with one file, custom.sql * Inspect the value of FrameworksLoaded syspref, last entry must be custom.sql 5) Remove/rename the file or localization dir and repeat 3/4, install must proceed normally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #18 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #17) > We could have a "localization" directory with common files (from Koha > codebase) to have some localization stuffs set by default. > localization/es-ES de-DE, etc. > Then an empty localization/custom directory that we would look up to find > .sql files. You mean something like: 1) Before "./translate install xx-YY" en/ mandatory/ marcflavour/ optional/ localization/ de-DE/ fr-CA/ xx-YY/ 2) After "translate install xx-YY", new dir with translations xx-YY/ mandatory/ marcflavour/ optional/ and we load first from 'xx-YY/' and last from 'localization/xx-YY/', with xx-YY lang maintainer responsible for xx-YY/ content (mostly updates) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #17 from Jonathan Druart --- We could have a "localization" directory with common files (from Koha codebase) to have some localization stuffs set by default. localization/es-ES de-DE, etc. Then an empty localization/custom directory that we would look up to find .sql files. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #16 from Bernardo Gonzalez Kriegel --- My turn to thank you "All" for your work :) (In reply to Katrin Fischer from comment #15) > Just a thought: Why not keep it simple for now? We could keep the SQL files > for any additional changes needed after the default installer files are > loaded. If I correctly interpret what you say is to leave all or part of the directory structure and at least one sql file with customizations, then the translation process populates those directories and then installation applies them. Is that correct? Something like this can be used for system preferences and frameworks, since they are loaded before the other files. Or if we agree in a hardcoded name then we could guarantee that it loads last. > At the moment it's very easy to customize the installer, as you just need to > add your own directory (optional) and a text and sql file. If we could keep > that ability at the same time, it would be a nice benefit. I have to admit, > we run some changes on the frameworks and other standard settings. It's easy, if you know how to do it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #15 from Katrin Fischer --- Thx for all the work here everyone. Just a thought: Why not keep it simple for now? We could keep the SQL files for any additional changes needed after the default installer files are loaded. At the moment it's very easy to customize the installer, as you just need to add your own directory (optional) and a text and sql file. If we could keep that ability at the same time, it would be a nice benefit. I have to admit, we run some changes on the frameworks and other standard settings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #14 from Martin Renvoize --- Thanks for all your work here Bernardo. I never realise quite how involved translation and localisation gets. Your ongoing work here is greatly appreciated both by myself and the wider community I'm sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #13 from Bernardo Gonzalez Kriegel --- (In reply to Martin Renvoize from comment #12) > Struggling to wrap my head around this one at the moment.. do we basically > end up with still having to maintain a set of distinct sysprefs.yaml files > within the koha repo? Hi Martin, I'm not entirely happy with this approach too, and I'm open to suggestions. As of now we can only do inserts using yaml, perhaps we can leave syspres.sql as is and then add a yaml file to 'update' some selected subset of sysprefs, using this last one to translate. > If that's the case.. I wonder if we could instead split localisation into a > distinct step in the installer.. so prefs are translated 'as is'.. but if > you want to add/change defaults those changes go into their own distinct > area and files.. something akin to the atomic updates and we run those after > the rest of install as a localisation step. I like the idea :) It's simpler, I'll try to write an alternative patch. Thanks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #12 from Martin Renvoize --- Struggling to wrap my head around this one at the moment.. do we basically end up with still having to maintain a set of distinct sysprefs.yaml files within the koha repo? If that's the case.. I wonder if we could instead split localisation into a distinct step in the installer.. so prefs are translated 'as is'.. but if you want to add/change defaults those changes go into their own distinct area and files.. something akin to the atomic updates and we run those after the rest of install as a localisation step. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #11 from Bernardo Gonzalez Kriegel --- Hi, I've uploaded my proposal for this problem. I create a new translation file, needed because it must show a message/advice to the translator. Then I need a new way to build the translation file, duplicating some of the code, can't found a better way for the moment, and release time is approaching, hope this pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #8 from Bernardo Gonzalez Kriegel --- Created attachment 103073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103073=edit Bug 24973: add locale-sysprefs.yml to localized dirs This patch put a copy of en/locale-sysprefs.yml on each localized installation directory. Each file complements general sysprefs.sql file to enable a normal install. To test: 1) Apply the patch 2) Do a clean install for any of current localized dirs: de-DE,es-ES,fr-CA,fr-FR,it-IT,nb-NO,pl-PL,ru-RU and uk-UA 3) Check systempreferecences table content No changes expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #7 from Bernardo Gonzalez Kriegel --- Created attachment 103072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103072=edit Bug 24973: Install localized sysprefs This patch changes installation files to process and install locale_sysprefs.yml This file must be present on each install dir. It complements sysprefs.sql, and is processed just before it. To test for EN 1) Apply the patch 2) Do a normal install only change to note is a new section when installer reports installed files named 'En data added', 'En' for english and shows locale-syspref.yml 3) Verify no changes on sysprefs values -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 103075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103075=edit Bug 24973: Add *-locale-prefs.po translation files This patch adds the new translation file for all current languages. To test: 1) Check update for a language (with no install dir) cd misc/translator ./translate update pt-BR 2) Check install ./translate install pt-BR verify creation of install dir ( installer/data/mysql/pt-BR) and locale_prefs.yml file 3) Do a clean install for your selected language, no problems expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #9 from Bernardo Gonzalez Kriegel --- Created attachment 103074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103074=edit Bug 24973: Translate locale-syspref.yml This patch modifies LangInstaller.pm to enable translation of the new localized system preference file. This 'translation' is special because it's used to SET some system preferences, not just translate some strings. The translation .po file is special, with a structure similar to the syspref translation file. It adds some comments to guide the translator in order to put correct values in the translation, perhaps an explanation will be needed in release notes. All new entries are set as 'fuzzy' and have a copy of the 'en' values as a reference. To test: 1) Apply the patch 2) Create translations file for a 'new' language cd misc/translation ./translate create xx-YY check new file po/xx-YY-locale-prefs.po 3) Update translations translate some strings on previous file, remember that those values sets the preference ./translate update xx-YY check translations are preserved 3) Install translations ./translate install xx-YY check new locale-sysprefs.yml file in installer/data/mysql/xx-YY/ check 'translated' options 4) Do a clean install with the new language Check correct value on sysprefs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 103071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103071=edit Bug 24973: rewrite subset of system preferences as YAML This patch removes a subset of system preferences from sysprefs.sql and rewrite them as YAML to SET their value for different languages using the translation process. The selected subset is an arbitrary, at this moment is similar to the one present in de-DE sysprefs file. Other languages update a different subset of sysprefs. I think that what the final subset will be falls outside the scope of this report. It can be enlarged or shortened at will. Test plan in following patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #5 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #3) > > We do not need to translate the explanation, it's not used. So no need to > split them. Yes, I realized that and discarded my own idea. (In reply to Jonathan Druart from comment #4) > > We must split this bug report, there are 2 different requests: > 1. Translate the default value of the sysprefs > 2. Set predefined settings depending on the region/country/etc > > Then it seems we need to define some options, but we need to list > exhaustively which ones are valid. My current approach is to rewrite in yaml format only a prefs subset (using those from DE, but can be defined), then producing a PO file like #. Use this to SET sysprefs #. variable: OpacNav #. options: 70|10 #. explanation: Use HTML tags to add navigational links to the left-hand navigational bar in OPAC #: installer/data/mysql/en//sysprefs.yml:systempreferences:1:row:13:mul:1 msgid "Important links here." msgstr "" #. Use this to SET sysprefs #. variable: BorrowersTitles #. options: #. explanation: Define appropriate Titles for patrons #: installer/data/mysql/en//sysprefs.yml:systempreferences:1:row:4:mul:1 msgid "Mr|Mrs|Miss|Ms" msgstr "" The text after '#.' is shown in pootle as comments to the left of the translation boxes (see https://translate.koha-community.org/es/19.11/translate/es-ES-staff-prog.po#unit=10916796) With po entries like this strings, in it's own file, we cat 'set' values for a selected group of sysprefs I'm using a sysprefs.yml file in 'en/' dir, that give us (2.), and its 'translation' (1.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #0) > In the de-DE installer a sysprefs.sql file is used to make some changes to > the system preferences for a smoother installation experience. The file can > be found here: > > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/ > mysql/de-DE/mandatory/system_preferences.sql; > h=2692f02b02da9100630a92c4f89fe7caba8ac786; > hb=7ce4122131a6c3d7f0fe7c953dc95fd5d831bf7f > > It's a mix of: > - Translating prefs content (HTML prefs, they might go away to news sometime) > - Localization settings (date format, currency format, time format) > - Translating pref options (borrower titles and relationships) > > It would be great if there was a way to keep this kind of modifications when > switching to the new yaml based installer files. We must split this bug report, there are 2 different requests: 1. Translate the default value of the sysprefs 2. Set predefined settings depending on the region/country/etc Then it seems we need to define some options, but we need to list exhaustively which ones are valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #3 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #2) > (In reply to Jonathan Druart from comment #1) > > Bernardo, could we imagine having the sysprefs' values translatable? > > It's in my TODO list, but to translate explanations column. > > In this case it's the values that must be translated. > Proposal: > * Split sysprefs.sql into localizable and not localizable parts > eg. sysprefs localsysprefs, our choice > * Put them in /en/ dir > * rewrite them as yaml, on syspref only translate explanation, on > localsysprefs explanation and value > * add strings from sysprefs in xx-YY-installer.po > * add strings from localsysprefs in it's own po file. > This file should contain useful comments so that the translators know what > values are valid. > > What do you think? We do not need to translate the explanation, it's not used. So no need to split them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 --- Comment #2 from Bernardo Gonzalez Kriegel --- (In reply to Jonathan Druart from comment #1) > Bernardo, could we imagine having the sysprefs' values translatable? It's in my TODO list, but to translate explanations column. In this case it's the values that must be translated. Proposal: * Split sysprefs.sql into localizable and not localizable parts eg. sysprefs localsysprefs, our choice * Put them in /en/ dir * rewrite them as yaml, on syspref only translate explanation, on localsysprefs explanation and value * add strings from sysprefs in xx-YY-installer.po * add strings from localsysprefs in it's own po file. This file should contain useful comments so that the translators know what values are valid. What do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Jonathan Druart changed: What|Removed |Added CC||bgkrie...@gmail.com Depends on||13897 --- Comment #1 from Jonathan Druart --- Bernardo, could we imagine having the sysprefs' values translatable? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 [Bug 13897] Use YAML files for installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24973] Allow to localize and translate system preferences with new yaml based installer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 Katrin Fischer changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
