[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in||19.05.11 Status|Pushed to stable|Pushed to oldstable --- Comment #24 from Lucas Gass --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable CC||j...@bywatersolutions.com Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #23 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Text to go in the||This fixes the display of release notes||cover images in the staff ||interface where there is no ||ISBN and both Amazon and ||local cover images are ||enabled. || ||Covers different ||combinations: ||- Amazon ||cover present, no local ||cover. ||- No Amazon cover, ||local cover image present. ||- Both Amazon and local ||cover image present. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #22 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #21 from Jonathan Druart --- Created attachment 103065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103065=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added Attachment #103034|0 |1 is obsolete|| Attachment #103035|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 103064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103064=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added Attachment #103036|0 |1 is obsolete|| --- Comment #19 from Jonathan Druart --- Comment on attachment 103036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103036 Bug 25007: (follow-up) Add check for normalized ISBN in opac-detail.tt Obsoleting this. Do not write patch to make me happy ;) My feeling is that [OPAC]AmazonCoverImages syspref MUST be tested with normalized_isbn, always. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Attachment #102062|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #18 from Lucas Gass --- Created attachment 103036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103036=edit Bug 25007: (follow-up) Add check for normalized ISBN in opac-detail.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #16 from Lucas Gass --- Created attachment 103034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103034=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Lucas Gass changed: What|Removed |Added Attachment #102063|0 |1 is obsolete|| --- Comment #17 from Lucas Gass --- Created attachment 103035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103035=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #15 from Jonathan Druart --- And what about OPAC? Should not we apply the same change to opac-detail? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #14 from Owen Leonard --- (In reply to Jonathan Druart from comment #12) > Should not it be done for XISBN as well? The FRBRizeEditions feature won't link a record if there is no ISBN, so I don't think it's possible for XISBN.normalized_isbn to evaluate as false AND a row be returned in the XISBN data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #13 from Jonathan Druart --- 701 [% FOREACH XISBN IN XISBNS %][% IF ( AmazonCoverImages ) %]http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link">https://images- na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html %].01._AA75_PU_PU-5_.jpg" />[% END %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- Should not it be done for XISBN as well? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Attachment #102060|0 |1 is obsolete|| --- Comment #10 from David Nind --- Created attachment 102062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102062=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Attachment #102061|0 |1 is obsolete|| --- Comment #11 from David Nind --- Created attachment 102063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102063=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Attachment #102057|0 |1 is obsolete|| --- Comment #9 from David Nind --- Created attachment 102061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102061=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Attachment #102056|0 |1 is obsolete|| --- Comment #8 from David Nind --- Created attachment 102060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102060=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 --- Comment #7 from Owen Leonard --- Created attachment 102057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102057=edit Bug 25007: (follow-up) Fix the way image check alters layout A question in the bug report asks: Why is is necessary to change the Bootstrap class to col-xs-12? The JavaScript which checks for the existence of an Amazon cover image is designed to remove the Amazon cover's container if there is none. Changing the class of cover image column is gone. However, the check is incorrect because it doesn't account for Local Covers. There might be both a 1 x 1 pixel Amazon image and a local cover image, so the layout shouldn't be changed unless there are no images present. To test, apply the patch and view the bibliographic details page of various titles including: - Amazon cover present, no local cover - No Amazon cover, local cover image present - Both Amazon and local cover image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Owen Leonard changed: What|Removed |Added Attachment #102054|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 102056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102056=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #5 from David Nind --- Note from testing: Using Google Chrome or Chromium before the patch is applied: the local image is not displayed on the detail page (it is in Firefox - in the wrong position as per the test plan). After applying the patch it works the same in Firefox as it does in Google Chrome or Chromium. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Attachment #102018|0 |1 is obsolete|| --- Comment #4 from David Nind --- Created attachment 102054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102054=edit Bug 25007: Check for normaalized ISBN when building Amazon link TO RECREATE: -Have Amazon images turned on and local images too. -Have a record with a local cover image -Make sure the record has no ISBN in 020 field. -Load detail page of that record and see that the local cover images is not on the right hand side like it should be but forced underneath 'catalogue_detail_biblio' in an odd spot. -Apply patch and reload page -The image should be back in its normal spot Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Owen Leonard changed: What|Removed |Added Blocks||25016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 [Bug 25016] Coce should not return a 1-pixel Amazon cover image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 Owen Leonard changed: What|Removed |Added Summary|AmazonCoverImages doesnt|AmazonCoverImages doesnt |check for ISNB in |check for ISBN in |details.tt |details.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
