[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Martin Renvoize changed: What|Removed |Added Severity|enhancement |normal CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 David Nind changed: What|Removed |Added Text to go in the||This patch improves the release notes||display of cover images ||where Coce is enabled and ||Amazon is a source. Where ||the image from Amazon is a ||1x1 pixel placeholder ||(meaning Amazon has no ||image) it is no longer ||displayed. CC||da...@davidnind.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Lucas Gass changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to stable|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Joy Nelson changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| CC||j...@bywatersolutions.com --- Comment #7 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 --- Comment #6 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Jonathan Druart changed: What|Removed |Added Attachment #103078|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 103082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103082=edit Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Jonathan Druart changed: What|Removed |Added Attachment #103033|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 103078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103078=edit Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- 1. Should not we hide the green dot if there is only 1 image? 2. Clicking a blue dot (select another image), the scrollbar is hitting the top (preventDefault is missing?) 3. Without cover images, I see the border of #cover-slides, then disappears. Cannot we avoid that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Lucas Gass changed: What|Removed |Added Attachment #102058|0 |1 is obsolete|| --- Comment #2 from Lucas Gass --- Created attachment 103033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103033=edit Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Owen Leonard changed: What|Removed |Added Blocks||25031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25031 [Bug 25031] Improve handling of multiple covers on the biblio detail page in the staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 --- Comment #1 from Owen Leonard --- Created attachment 102058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102058=edit Bug 25016: Coce should not return a 1-pixel Amazon cover image This patch adds an onload function to the JavaScript which loads images from Coce. In the case where the image is 1 x 1 pixel the image should be removed. To test you should have Coce enabled and Amazon.com included in the list of sources. - Apply the patch and view the bibliographic details page under a variety of conditions: - A title which has a matching Amazon image: - The image should load as expected. - A title which doesn't have a matching Amazon image - The image should not be found in the source at all after the page has loaded. - Test with local cover images enabled -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25016] Coce should not return a 1-pixel Amazon cover image
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25016 Owen Leonard changed: What|Removed |Added Depends on||25007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25007 [Bug 25007] AmazonCoverImages doesnt check for ISBN in details.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
