[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Fridolin Somers changed: What|Removed |Added Blocks||29571 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29571 [Bug 29571] Mainpage : "All libraries" pending suggestions are visible only if the current library has suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Blocks||27462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27462 [Bug 27462] Number of suggestions includes archived suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Christopher Davis changed: What|Removed |Added CC||tubaclari...@protonmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Text to go in the|This patch adds to the |This patch adds to the release notes|simple count of all |simple count of all |suggestions in the system |suggestions in the system |with a count filtered by|with a count filtered by |the users branch. This |the users branch. This |means that on the homepage |means that on the homepage |and other areas a user will |and other areas a user will |see a count of local|see a count of local |suggestions and total |suggestions and total |suggestions in the system. |suggestions in the system. || |Previously clicking the |Previously clicking the |link to suggestions would |link to suggestions would |take the user to a page |take the user to a page |showing fewer suggestions |showing fewer suggestions |that counted in the link. |that counted in the link. |Now these numbers hsould be |Now these numbers should be |more consistent.|more consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Owen Leonard changed: What|Removed |Added Blocks||26833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26833 [Bug 26833] Logged in library doesn't show with suggestions count -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Blocks||24370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24370 [Bug 24370] Editing purchase suggestion changes the acquisition library to logged-in user's -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Text to go in the||This patch adds to the release notes||simple count of all ||suggestions in the system ||with a count filtered by ||the users branch. This ||means that on the homepage ||and other areas a user will ||see a count of local ||suggestions and total ||suggestions in the system. || ||Previously clicking the ||link to suggestions would ||take the user to a page ||showing fewer suggestions ||that counted in the link. ||Now these numbers hsould be ||more consistent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #43 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #42 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #41 from Nick Clemens --- Created attachment 108984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108984=edit Bug 25033: (follow-up) Don't limit suggestions to branches if displaying by branch In the case of organizing by branches we should not filter by branch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #40 from Jonathan Druart --- I am sorry Nick, but I found something... 1. Go to /cgi-bin/koha/suggestion/suggestion.pl 2. Select all libraries: https://snipboard.io/esC3ot.jpg 3. Select IPT => Nothing displayed # OK 4. Organize by library => Nothing displayed # KO? /cgi-bin/koha/suggestion/suggestion.pl?branchcode=IPT=branchcode=__ANY__ The problem is that there is no more "library" filter. Maybe we should remove "branchcode" if organizing by library? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #107831|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 108953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108953=edit Bug 25033: (follow-up) Don't delete branchcode key from suggestion_ref Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #39 from Katrin Fischer --- Created attachment 108954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108954=edit Bug 25033: Fix number of tests Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104357|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 108951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108951=edit Bug 25033: Improve JS code a bit Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104161|0 |1 is obsolete|| --- Comment #34 from Katrin Fischer --- Created attachment 108949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108949=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104160|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 108948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108948=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104162|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 108950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108950=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Attachment #104940|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 108952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108952=edit Bug 25033: (follow-up) Deal with 'Any' branch and don't show dropdown if organized by library Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #32 from Katrin Fischer --- I really like this. This is a great improvement for a reoccurring support question I'd love to get rid of! The only thing that gets me thinking a bit is that there is a bit of code repeat between the start page and the acquisition home page right now. But I'd not want this to be held up much longer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added QA Contact|jonathan.dru...@bugs.koha-c | |ommunity.org| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #31 from Nick Clemens --- Created attachment 107831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107831=edit Bug 25033: (follow-up) Don't delete branchcode key from suggestion_ref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #30 from Jonathan Druart --- Found a bug: Create a suggestion 'xxx' for CPL Create a suggestion 'yyy' for FPL You see: https://snipboard.io/tIeo86.jpg Dropdown list has "FPL" and CPL is displayed (??) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #29 from Nick Clemens --- Created attachment 104940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104940=edit Bug 25033: (follow-up) Deal with 'Any' branch and don't show dropdown if organized by library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.dru...@bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #28 from Jonathan Druart --- Created attachment 104357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104357=edit Bug 25033: Improve JS code a bit -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart --- 1. We should remove the new dropdown list if the "Organize by" filter is set to Library 2. - Select "Any" - Select "Organize by library" Can't call method "branchname" on an undefined value at /kohadevbox/koha/suggestion/suggestion.pl line 64 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104093|0 |1 is obsolete|| --- Comment #26 from David Nind --- Created attachment 104162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104162=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104091|0 |1 is obsolete|| --- Comment #24 from David Nind --- Created attachment 104160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104160=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Attachment #104092|0 |1 is obsolete|| --- Comment #25 from David Nind --- Created attachment 104161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104161=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #23 from Nick Clemens --- Created attachment 104093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104093=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #22 from Nick Clemens --- Created attachment 104092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104092=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Attachment #102299|0 |1 is obsolete|| Attachment #102300|0 |1 is obsolete|| Attachment #102301|0 |1 is obsolete|| Attachment #102302|0 |1 is obsolete|| Attachment #102922|0 |1 is obsolete|| --- Comment #21 from Nick Clemens --- Created attachment 104091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104091=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #20 from Jonathan Druart --- Failing QA, please remove that method. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #19 from Jonathan Druart --- Nick, I tried to implement a simple version of Koha::Objects::Limit::Library, that could be used here. But I am having the impression that what we finally need here is simply using C4::Context::only_my_library from the controller script. I do not think we want such subroutines appear in several of our Koha modules. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #17 from Jonathan Druart --- Resume for private discussion: Maybe the method was not needed (but now we have it, and covered by tests). Another solution would have been to do something like Koha::Patron->libraries_where_can_see_patrons, ie. get a whitelist of libraries for a given patron. (Note that this method currently use userenv but should not, and could avoid it). Waiting for another QA feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #17) > Resume for private discussion: *from* -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #16 from Nick Clemens --- (In reply to Jonathan Druart from comment #14) > 1. Can you rename the "$option" parameter to something more meaningful? > $option let think it's a hashref. Done > 2. Reading filter_by_user_branch I'd say there is a case where we return > undef, and it's not expected (chaining should be allowed). > I'd say the 'else' should be removed, to return $self in any cases. else removed. > 3. Actually, maybe you should pass the logged in user instead of the > branchcode, that will allow to filter for someone else than the logged in > user, and that will make you remove the test on $userenv. What do you think? I think we need the userenv as we want contextual filtering - i.e. it matters more which branch you are signed in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #15 from Nick Clemens --- Created attachment 102922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102922=edit Bug 25033: (follow-up) Fix links and return self as fallback -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #14 from Jonathan Druart --- 1. Can you rename the "$option" parameter to something more meaningful? $option let think it's a hashref. 2. Reading filter_by_user_branch I'd say there is a case where we return undef, and it's not expected (chaining should be allowed). I'd say the 'else' should be removed, to return $self in any cases. 3. Actually, maybe you should pass the logged in user instead of the branchcode, that will allow to filter for someone else than the logged in user, and that will make you remove the test on $userenv. What do you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #12 from Owen Leonard --- Created attachment 102301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102301=edit Bug 25033: Remove CountSuggestion Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #11 from Owen Leonard --- Created attachment 102300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102300=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #13 from Owen Leonard --- Created attachment 102302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102302=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Owen Leonard changed: What|Removed |Added Attachment #102282|0 |1 is obsolete|| Attachment #102283|0 |1 is obsolete|| Attachment #102284|0 |1 is obsolete|| Attachment #102285|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 102299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102299=edit Bug 25033: Add filter_by_user_branch to Koha/Suggestions.pm Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #9 from Nick Clemens --- Created attachment 102285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102285=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #8 from Nick Clemens --- Created attachment 102284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102284=edit Bug 25033: Remove CountSuggestion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #7 from Nick Clemens --- Created attachment 102283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102283=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "Centerville: 1 / All libraries: 3" suggestions 8 - Confirm that the links take you to suggestions view of your branch or all libraries respectively 9 - Turn on IndependentBranches 10 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 11 - Sign in as that user 11 - See "Centerville: 1" suggestion on mainpage and on acqui home -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Attachment #102225|0 |1 is obsolete|| Attachment #102226|0 |1 is obsolete|| Attachment #102227|0 |1 is obsolete|| Attachment #102228|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 102282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102282=edit Bug 25033: Add filter_by_user_branch to Koha/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #5 from Nick Clemens --- Instead of: 1 (5) Should be: Centerville 1 / All 5 The words above should be links to view current library suggestions or all library suggestions Also, don't delete the branch choice when adding suggestions, d'oh -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added CC||bwsdo...@gmail.com, ||ke...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added CC||and...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #4 from Nick Clemens --- Created attachment 102228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102228=edit Bug 25033: Move branchfilter to top of page There is confusion becase it is not obvious when the suggestions page is being limited to a branch Moving the branch filter to the top of the page makes it easier to see To test: 1 - Apply patch 2 - From mainpage or acqui-home note the link to suggestions takes you to suggestions limited to current branch 3 - Change the dropdown 4 - Note the page refreshes and loads the correct suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #2 from Nick Clemens --- Created attachment 102226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102226=edit Bug 25033: Display both local and all pending suggestions counts if the numbers differ To test: 0 - Be in staff client as a superlibrarian 1 - Place some suggestions 1 for any branch 1 for signed in branch 1 for another branch 2 - Go to Koha main page, 3 suggestions pending 3 - Click 'Suggestions pending approval' - you see one suggestion 4 - Click on 'Acquisitions' in breadcrumbs , 3 suggestions pending 5 - Click manage suggestions - you see one suggestion 6 - Apply patch 7 - On mainpage and acqui-home you now see "1 (3)" suggestions 8 - Turn on IndependentBranches 9 - Create a user with acquisition and suggestions permissions but not superlibrarian in one of the branches used above 10 - Sign in as that user 11 - See 1 suggestion on mainpage and 1 on acqui home -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #3 from Nick Clemens --- Created attachment 102227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102227=edit Bug 25033: Remove CountSuggestion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 --- Comment #1 from Nick Clemens --- Created attachment 102225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102225=edit Bug 25033: Add filter_by_user_branch to Koha/Suggestions.pm -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25033] Counts of suggestions are confusing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25033 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
