[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #8 from Lucas Gass --- missing dependencies for 19.05.x, no backport -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|20.05.00|20.05.00, 19.11.06 released in|| --- Comment #7 from Joy Nelson --- backported to 19.11.x for 19.11.06 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 --- Comment #6 from Janusz Kaczmarek --- (In reply to Martin Renvoize from comment #5) > Nice work everyone! > > Pushed to master for 20.05 I would suggest pushing it to 19.11.XX as well since 19.11 is affected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 --- Comment #5 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081
Jonathan Druart changed:
What|Removed |Added
Attachment #102528|0 |1
is obsolete||
--- Comment #3 from Jonathan Druart
---
Created attachment 102544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102544=edit
Bug 25081: Fix creation of new item for a received issue
The Bug 23435 introduced the idea of multiple copies added while
receiving a new issue. Unfortunately, under some circumstances, it
causes no items being added at all. It occurs stochastically, only
under some conditions. But it is quite likely to happen while receiving
a supplemental issue.
The reason fot hist is that, in serials-edit.pl, line ca 292 and infra,
@num_copies is treated in the same way as @tags, while it should be
treated similarly to @bibnums. It will be obvious after examining the
content of parameters tag, subfield, field_value, ..., number_of_copies.
In other words, for every edited issue number_of_copies is a scalar.
Nota bene:
a) beter to initialize $countdistinct with zero;
b) note that in master, now, before applying the patch,
$itemhash{$item}->{'num_copies'} is treated once as a scalar
and in the next line--as an array:
$itemhash{$item}->{'num_copies'} //= 1;
for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){
TEST PLAN
=
1. Have a subscription with the option "Create an item
record when receiving this serial" active and try to receive a
supplemental issue. Control that a new item under the biblio record
(usually) will not be created.
2. Apply the patch.
3. Repeat p. 1 -- a new item should be created.
Signed-off-by: Aleisha Amohia
Signed-off-by: Jonathan Druart
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 --- Comment #4 from Jonathan Druart --- Created attachment 102545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102545=edit Bug 25081: Fix wrong comment Not directly related to previous patch, coming from 23435. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Jonathan Druart changed: What|Removed |Added Depends on||23435 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23435 [Bug 23435] Add multiple copies of an item when receiving in serials -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081
Aleisha Amohia changed:
What|Removed |Added
Attachment #102527|0 |1
is obsolete||
--- Comment #2 from Aleisha Amohia ---
Created attachment 102528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102528=edit
Bug 25081 - new item for a received issue is (stochastically) not created
The Bug 23435 introduced the idea of multiple copies added while
receiving a new issue. Unfortunately, under some circumstances, it
causes no items being added at all. It occurs stochastically, only
under some conditions. But it is quite likely to happen while receiving
a supplemental issue.
The reason fot hist is that, in serials-edit.pl, line ca 292 and infra,
@num_copies is treated in the same way as @tags, while it should be
treated similarly to @bibnums. It will be obvious after examining the
content of parameters tag, subfield, field_value, ..., number_of_copies.
In other words, for every edited issue number_of_copies is a scalar.
Nota bene:
a) beter to initialize $countdistinct with zero;
b) note that in master, now, before applying the patch,
$itemhash{$item}->{'num_copies'} is treated once as a scalar
and in the next line--as an array:
$itemhash{$item}->{'num_copies'} //= 1;
for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){
TEST PLAN
=
1. Have a subscription with the option "Create an item
record when receiving this serial" active and try to receive a
supplemental issue. Control that a new item under the biblio record
(usually) will not be created.
2. Apply the patch.
3. Repeat p. 1 -- a new item should be created.
Signed-off-by: Aleisha Amohia
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081
Janusz Kaczmarek changed:
What|Removed |Added
Status|NEW |Needs Signoff
Assignee|koha-b...@lists.koha-commun |janus...@gmail.com
|ity.org |
--- Comment #1 from Janusz Kaczmarek ---
Created attachment 102527
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102527=edit
Bug 25081 - new item for a received issue is (stochastically) not created
Nota bene:
a) beter to initialize $countdistinct with zero;
b) note that in master, now, before applying the patch,
$itemhash{$item}->{'num_copies'} is treated once as a scalar
and in the next line--as an array:
$itemhash{$item}->{'num_copies'} //= 1;
for (my $copy = 0; $copy < $itemhash{$item}->{'num_copies'}[$index];){
TEST PLAN
=
1. Have a subscription with the option "Create an item
record when receiving this serial" active and try to receive a
supplemental issue. Control that a new item under the biblio record
(usually) will not be created.
2. Apply the patch.
3. Repeat p. 1 -- a new item should be created.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25081] new item for a received issue is (stochastically) not created
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25081 Janusz Kaczmarek changed: What|Removed |Added CC||alei...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
