[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Blocks|24101 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #78 from Lari Taskula --- Taking a different approach with less code dependencies - moving these patches to Bug 26814. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26814 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Status|Needs Signoff |BLOCKED --- Comment #77 from Lari Taskula --- Marked as blocked since dependent Bug 25037 does not apply. I'm also considering of dropping it from dependencies. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on|25112 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #76 from Lari Taskula --- Rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #75 from Lari Taskula --- Created attachment 107533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107533=edit Bug 25089: (OLD GUI) Indent and add checkout type to all_rules hash No other changes in this patch. To test: 1. git diff --word-diff=color --ignore-all-space HEAD~1 -- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt 2. Observe only $ct has been added Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103545|0 |1
is obsolete||
--- Comment #73 from Lari Taskula ---
Created attachment 107531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107531=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #104274|0 |1 is obsolete|| --- Comment #74 from Lari Taskula --- Created attachment 107532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107532=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. First apply all the patches tagged with (OLD GUI) prefix in commit title 2. Go to Circulation rules page in Koha 3. Observe checkout type column in the rule matrix 4. Test circulation rules matrix by setting, modifying and deleting rules. 5. Test default checkout, hold and return policy settings. 6. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103542|0 |1
is obsolete||
--- Comment #70 from Lari Taskula ---
Created attachment 107528
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107528=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103544|0 |1
is obsolete||
--- Comment #72 from Lari Taskula ---
Created attachment 107530
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107530=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103543|0 |1
is obsolete||
--- Comment #71 from Lari Taskula ---
Created attachment 107529
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107529=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103541|0 |1 is obsolete|| --- Comment #69 from Lari Taskula --- Created attachment 107527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107527=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103540|0 |1 is obsolete|| --- Comment #68 from Lari Taskula --- Created attachment 107526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107526=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103539|0 |1 is obsolete|| --- Comment #67 from Lari Taskula --- Created attachment 107525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107525=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103537|0 |1 is obsolete|| --- Comment #65 from Lari Taskula --- Created attachment 107523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107523=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103538|0 |1 is obsolete|| --- Comment #66 from Lari Taskula --- Created attachment 107524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107524=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103547|0 |1 is obsolete|| --- Comment #64 from Lari Taskula --- Created attachment 104275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104275=edit Bug 25089: Change sorting order to branchcode, checkout_type, categorycode, itemtype Otherwise we need to duplicate a rule with renewalsallowed=0 every rule if we don't want on-site checkouts to be renewalable. To test: 1. prove t/db_dependent/Koha/CirculationRules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103546|0 |1 is obsolete|| --- Comment #63 from Lari Taskula --- Created attachment 104274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104274=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103361|0 |1 is obsolete|| --- Comment #62 from Lari Taskula --- Created attachment 103547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103547=edit Bug 25089: Change sorting order to branchcode, checkout_type, categorycode, itemtype Otherwise we need to duplicate a rule with renewalsallowed=0 every rule if we don't want on-site checkouts to be renewalable. To test: 1. prove t/db_dependent/Koha/CirculationRules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103360|0 |1 is obsolete|| --- Comment #61 from Lari Taskula --- Created attachment 103546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103546=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103358|0 |1
is obsolete||
--- Comment #59 from Lari Taskula ---
Created attachment 103544
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103544=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103359|0 |1
is obsolete||
--- Comment #60 from Lari Taskula ---
Created attachment 103545
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103545=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103356|0 |1
is obsolete||
--- Comment #57 from Lari Taskula ---
Created attachment 103542
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103542=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103357|0 |1
is obsolete||
--- Comment #58 from Lari Taskula ---
Created attachment 103543
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103543=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103353|0 |1 is obsolete|| --- Comment #54 from Lari Taskula --- Created attachment 103539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103539=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103354|0 |1 is obsolete|| --- Comment #55 from Lari Taskula --- Created attachment 103540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103540=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103355|0 |1 is obsolete|| --- Comment #56 from Lari Taskula --- Created attachment 103541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103541=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103352|0 |1 is obsolete|| --- Comment #53 from Lari Taskula --- Created attachment 103538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103538=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103351|0 |1 is obsolete|| --- Comment #52 from Lari Taskula --- Created attachment 103537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103537=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103348|0 |1 is obsolete|| --- Comment #50 from Lari Taskula --- Created attachment 103360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103360=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103345|0 |1
is obsolete||
--- Comment #47 from Lari Taskula ---
Created attachment 103357
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103357=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103346|0 |1
is obsolete||
--- Comment #48 from Lari Taskula ---
Created attachment 103358
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103358=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103347|0 |1
is obsolete||
--- Comment #49 from Lari Taskula ---
Created attachment 103359
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103359=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103349|0 |1 is obsolete|| --- Comment #51 from Lari Taskula --- Created attachment 103361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103361=edit Bug 25089: Change sorting order to branchcode, checkout_type, categorycode, itemtype Otherwise we need to duplicate a rule with renewalsallowed=0 every rule if we don't want on-site checkouts to be renewalable. To test: 1. prove t/db_dependent/Koha/CirculationRules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103342|0 |1 is obsolete|| --- Comment #44 from Lari Taskula --- Created attachment 103354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103354=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103344|0 |1
is obsolete||
--- Comment #46 from Lari Taskula ---
Created attachment 103356
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103356=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103343|0 |1 is obsolete|| --- Comment #45 from Lari Taskula --- Created attachment 103355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103355=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103341|0 |1 is obsolete|| --- Comment #43 from Lari Taskula --- Created attachment 103353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103353=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103340|0 |1 is obsolete|| --- Comment #42 from Lari Taskula --- Created attachment 103352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103352=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103339|0 |1 is obsolete|| --- Comment #41 from Lari Taskula --- Created attachment 103351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103351=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103292|0 |1 is obsolete|| --- Comment #39 from Lari Taskula --- Created attachment 103348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103348=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #40 from Lari Taskula --- Created attachment 103349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103349=edit Bug 25089: Change sorting order to branchcode, checkout_type, categorycode, itemtype Otherwise we need to set renewalsallowed=0 for every rule if we don't want on-site checkouts to be renewalable. To test: 1. prove t/db_dependent/Koha/CirculationRules.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103290|0 |1
is obsolete||
--- Comment #37 from Lari Taskula ---
Created attachment 103346
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103346=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103291|0 |1
is obsolete||
--- Comment #38 from Lari Taskula ---
Created attachment 103347
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103347=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103288|0 |1
is obsolete||
--- Comment #35 from Lari Taskula ---
Created attachment 103344
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103344=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103287|0 |1 is obsolete|| --- Comment #34 from Lari Taskula --- Created attachment 103343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103343=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103289|0 |1
is obsolete||
--- Comment #36 from Lari Taskula ---
Created attachment 103345
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103345=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103283|0 |1 is obsolete|| --- Comment #30 from Lari Taskula --- Created attachment 103339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103339=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103284|0 |1 is obsolete|| --- Comment #31 from Lari Taskula --- Created attachment 103340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103340=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103286|0 |1 is obsolete|| --- Comment #33 from Lari Taskula --- Created attachment 103342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103342=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103285|0 |1 is obsolete|| --- Comment #32 from Lari Taskula --- Created attachment 103341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103341=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103247|0 |1
is obsolete||
--- Comment #28 from Lari Taskula ---
Created attachment 103291
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103291=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103248|0 |1 is obsolete|| --- Comment #29 from Lari Taskula --- Created attachment 103292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103292=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103245|0 |1
is obsolete||
--- Comment #26 from Lari Taskula ---
Created attachment 103289
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103289=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103246|0 |1
is obsolete||
--- Comment #27 from Lari Taskula ---
Created attachment 103290
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103290=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103241|0 |1 is obsolete|| --- Comment #22 from Lari Taskula --- Created attachment 103285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103285=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103244|0 |1
is obsolete||
--- Comment #25 from Lari Taskula ---
Created attachment 103288
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103288=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103243|0 |1 is obsolete|| --- Comment #24 from Lari Taskula --- Created attachment 103287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103287=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103242|0 |1 is obsolete|| --- Comment #23 from Lari Taskula --- Created attachment 103286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103286=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103239|0 |1 is obsolete|| --- Comment #20 from Lari Taskula --- Created attachment 103283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103283=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103240|0 |1 is obsolete|| --- Comment #21 from Lari Taskula --- Created attachment 103284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103284=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103054|0 |1
is obsolete||
--- Comment #18 from Lari Taskula ---
Created attachment 103247
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103247=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103053|0 |1
is obsolete||
--- Comment #17 from Lari Taskula ---
Created attachment 103246
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103246=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103052|0 |1
is obsolete||
--- Comment #16 from Lari Taskula ---
Created attachment 103245
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103245=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #19 from Lari Taskula --- Created attachment 103248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103248=edit Bug 25089: (OLD GUI) Add checkout_type to smart-rules To test: 1. Go to Circulation rules page in Koha 2. Observe checkout type column in the rule matrix 3. Test circulation rules matrix by setting, modifying and deleting rules. 4. Test default checkout, hold and return policy settings. 5. Test default checkout, hold policy by patron category settings. Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
Lari Taskula changed:
What|Removed |Added
Attachment #103051|0 |1
is obsolete||
--- Comment #15 from Lari Taskula ---
Created attachment 103244
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103244=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103049|0 |1 is obsolete|| --- Comment #13 from Lari Taskula --- Created attachment 103242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103242=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103050|0 |1 is obsolete|| --- Comment #14 from Lari Taskula --- Created attachment 103243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103243=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103048|0 |1 is obsolete|| --- Comment #12 from Lari Taskula --- Created attachment 103241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103241=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103047|0 |1 is obsolete|| --- Comment #11 from Lari Taskula --- Created attachment 103240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103240=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Attachment #103046|0 |1 is obsolete|| --- Comment #10 from Lari Taskula --- Created attachment 103239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103239=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on||25113, 25114 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25113 [Bug 25113] Make CirculationRules.t flexible for new scope combinations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25114 [Bug 25114] Remove duplicated logic from GetLoanLength() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added CC||lari.task...@hypernova.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #8 from Lari Taskula ---
Created attachment 103053
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103053=edit
Bug 25089: Add checkout_type to get_effective_rule
To test:
1. Find all occurrences of get_effective_rule that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | \
grep -Pavz 'hold|reserves|article_requests' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to get_effective_rule(), or that we
are explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
1.3 Verify the other cases. If you find another result than
what is mentioned above, then this test fails.
2. Find all subroutines using get_effective_rule()
git grep --no-index -n -p -P 'get_effective_rule\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
C4/Circulation.pm=376=sub TooMany {
C4/Circulation.pm=1300=sub AddIssue {
C4/Circulation.pm=1633=sub GetBranchBorrowerCircRule {
C4/Circulation.pm=1689=sub GetBranchItemRule {
C4/Circulation.pm=3030=sub GetRenewCount {
C4/Reserves.pm=348=sub CanItemBeReserved {
C4/Reserves.pm=2230=sub GetHoldRule {
Koha/Biblio.pm=294=sub article_request_type_for_bib {
Koha/Charges/Fees.pm=98=sub accumulate_rentalcharge {
Koha/CirculationRules.pm=218=sub get_effective_rules {
Koha/CirculationRules.pm=390=sub get_opacitemholds_policy {
Koha/CirculationRules.pm=416=sub get_onshelfholds_policy {
Koha/Item.pm=571=sub article_request_type {
Koha/REST/V1/Checkouts.pm=192=sub allows_renewal {
Koha/Template/Plugin/CirculationRules.pm=26=sub Get {
Check these subroutines and make sure they are using
get_effective_rule() with the new scope, unless not needed.
When fetching a hold-related rules, checkout_type is not needed.
These subroutines and classes need changes to sub params:
2.1. Check modifications to Koha::Charges::Fees
2.2. Check modification made to C4::Circulation::_debar_user_on_return().
2.3. Check modification made to C4::Circulation::_calculate_new_debar_dt().
3. Find all occurrences of get_effective_rule with the following command:
grep --exclude-dir='.git' -Prn 'get_effective_rule(?!s)'
Make sure all matches (where rule scope allows checkout_type) are
updated.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #9 from Lari Taskula ---
Created attachment 103054
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103054=edit
Bug 25089: Add checkout_type to get_effective_rules
To test:
1. Find all occurrences of get_effective_rules that are missing
checkout_type where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' \
-Przo '(?s)(::|->)get_effective_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
1.1. Verify command output. Only reserve related calls to
get_effective_rules() should be returned.
2. Find all subroutines using get_effective_rules()
git grep --no-index -n -p -P 'get_effective_rules\s*\(' \
| grep -v 'sub {' | grep -P 'sub .*'
This list should be returned:
git grep --no-index -n -p 'get_effective_rules' | grep -P 'sub .*'
3. Check modification made to C4::Circulation::CalcDateDue()
4. Check modification made to C4::Circulation::CalcFine()
5. Check modification made to C4::Circulation::GetLoanLength()
6. Check modification made to C4::Circulation::GetHardDueDate()
Make sure all matches (where rule scope allows checkout_type) are
updated.
7. Run these unit tests:
grep -Prl --color=never 'get_effective_rule\(|set_rule\(|set_rules\(' \
t/db_dependent/ | grep '^.*\.t$' | xargs prove
8. Test onboarding tool
8.1. Drop your database (take backups first if needed)
8.2. Navigate to web installer
8.3. Continue until you reach onboarding tool step where circulation
rules are added.
8.4. Observe new drop down selection "Checkout type".
8.5. Select any checkout type and continue the onboarding process.
8.6. Investigate your database table "circulation_rules". You should
now have rules with checkout_type of your choice.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #7 from Lari Taskula ---
Created attachment 103052
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103052=edit
Bug 25089: Add checkout_type to set_rules
To test:
1. Find all occurrences of set_rules that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rules.*?\)' | \
grep -avz 'checkout_type' && echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rules(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rules()
git grep --no-index -n -p -P 'set_rules\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t=293=
sub set_holdallowed_rule {
3. The boring step. Find all occurrences of set_rules() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rules'
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #5 from Lari Taskula --- Created attachment 103050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103050=edit Bug 25089: Sort circulation rules Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089
--- Comment #6 from Lari Taskula ---
Created attachment 103051
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103051=edit
Bug 25089: Add checkout_type to set_rule
To test:
1. Find all occurrences of set_rule that are missing checkout_type
where required
grep --exclude-dir '.git' --exclude-dir 'misc/translator' \
--exclude-dir 'koha-tmpl' -Przo '(?s)(::|->)set_rule(?!s).*?\)' | \
grep -avz 'checkout_type' | grep -Pavz 'hold|reserves|article_requests' \
&& echo ""
The only occasions this should return anything are cases where
a HASH or HASHref is given to set_rule(), or that we are
explicitly testing missing parameters in an unit test.
1.2 Verify the HASH/HASHref cases. The hash should contain
a checkout_type (unless the rule is related to holds)
2. Find all subroutines using set_rule()
git grep --no-index -n -p -P 'set_rule\s*\(' | grep -v 'sub {' \
| grep -P 'sub .*'
2.1 The only return should be
Koha/CirculationRules.pm=326=sub set_rules {
3. The boring step. Find all occurrences of set_rule() with
the following command:
grep --exclude-dir='.git' -Prn 'set_rule' | grep -v set_rules
Go through this list and make sure all neccessary locations are
updated. A change is required when the rule scope includes
checkout_type. See Koha/CirculationRules.pm for scopes.
Hold/reserve related rules do not require it.
Sponsored-by: The National Library of Finland
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #3 from Lari Taskula --- Created attachment 103048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103048=edit Bug 25089: Add checkout_type to Koha::CirculationRules To test: 1. prove t/db_dependent/Koha/CirculationRules.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #4 from Lari Taskula --- Created attachment 103049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103049=edit Bug 25089: Remove on-site specific circulation rules To apply: 1. perl installer/data/mysql/updatedatabase.pl To test: 1. Search for patron_maxonsiteissueqty rule $ grep -rn 'patron_maxonsiteissueqty' 2. Observe no results in Koha source files 3. Search for maxonsiteissueqty rule $ grep -rn 'maxonsiteissueqty' 4. Observe no results (apart from .git) 5. Check modification made to C4::Circulation::GetBranchBorrowerCircRule(). Make sure the new parameter is being used everywhere. You can search the usage of this subroutine with similar grep commands as above. 6. Run the following tests: prove t/db_dependent/Circulation/Branch.t prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t prove t/db_dependent/Circulation/TooMany.t Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #1 from Lari Taskula --- Created attachment 103046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103046=edit Bug 25089: Add a new checkout_type to circulation_rules table To add: 1. perl installer/data/mysql/updatedatabase.pl Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 --- Comment #2 from Lari Taskula --- Created attachment 103047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103047=edit Bug 25089: Schema changes Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on||25112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Blocks|25112 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Blocks||25112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25112 [Bug 25112] Koha::CirculationRules->set_rules should handle scopes per rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25089] Add checkout_type to circulation rules
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25089 Lari Taskula changed: What|Removed |Added Depends on||25037 Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|koha-b...@lists.koha-commun |lari.task...@hypernova.fi |ity.org | Blocks||24101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25037 [Bug 25037] Add support for multiple checkout types -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
