[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #16 from Kyle M Hall --- (In reply to David Cook from comment #15) > I don't have anything to ad from a QA perspective... but I'm intrigued by > this one! > > In Discourse, the named plugins go into /var/www/discourse/plugins, so you > wind up with something like > /var/www/discourse/plugins/discourse-jwt/plugin.rb > (https://github.com/discourse/discourse-jwt). I found it super convenient. Yeah, that's basically the gist of what we are trying do to here as well! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #15 from David Cook --- I don't have anything to ad from a QA perspective... but I'm intrigued by this one! In Discourse, the named plugins go into /var/www/discourse/plugins, so you wind up with something like /var/www/discourse/plugins/discourse-jwt/plugin.rb (https://github.com/discourse/discourse-jwt). I found it super convenient. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #14 from Kyle M Hall --- (In reply to Martin Renvoize from comment #13) > Is this dead in the water? I'm not opposed to continuing work on it if someone can tell me what needs done. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #13 from Martin Renvoize --- Is this dead in the water? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Please check comment#9 and comment#10 - something appears not to be right with uninstalling plugins. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #11 from Katrin Fischer --- Tomas, you are QA contact here - could you verify that uninstalling works correctly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #10 from David Cook --- (In reply to Julian Maurice from comment #9) > Not sure how this worked before, but uninstalling a plugin with the patch > applied leaves a lot of files in . Can it be fixed ? I think uninstallation is already broken anyway? Bug 25604 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #9 from Julian Maurice --- Not sure how this worked before, but uninstalling a plugin with the patch applied leaves a lot of files in . Can it be fixed ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Keywords|rel_20_11_target| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added Keywords|rel_20_05_candidate |rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added Component|Architecture, internals,|Plugin architecture |and plumbing| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added QA Contact|josef.mora...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #8 from Martin Renvoize --- Setting back to signed off.. I've asked Tomas to give the follow-ups a quick once over to check there's nothing I've missed in Kyles work. Thanks for your effort guys, this will be a nice improvement. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #6 from Kyle M Hall --- Created attachment 103495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103495&action=edit Bug 25222: (QA follow-up) Make Koha create the subdirectory -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #7 from Kyle M Hall --- Created attachment 103496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103496&action=edit Bug 25222: (QA follow-up) Update @INC when calling Koha::Plugins::new -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #5 from Martin Renvoize --- Had a quick chat with Kyle regarding alternatives: >I'm not sure about the approach in bug 25222 - Add ability to let plugins live >in individual subdirectories > should we require that plugin devs package like this under a top level dir.. > or should we actually handle the separation at install time perhaps and > create a directory for each plugin there? > I can see things ending up very inconsistent with a mix of the two styles > otherwise. We agreed that if it's not a mammoth task it would be cleaner to continue to package plugins the way we currently are, and instead split them up at install time. As such, we're going to have a go at that and I'll hold off pushing this until we've reached a conclusion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Hmm.. this looks like it adds a new dependency but doesn't specify that in the cpanfile File::Find::Rule -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Josef Moravec changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | Status|Signed Off |Passed QA CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Josef Moravec changed: What|Removed |Added Attachment #103317|0 |1 is obsolete|| --- Comment #3 from Josef Moravec --- Created attachment 103389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103389&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added Attachment #103311|0 |1 is obsolete|| --- Comment #2 from Arthur Suzuki --- Created attachment 103317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103317&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! Signed-off-by: Arthur Suzuki -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Arthur Suzuki changed: What|Removed |Added CC||arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 --- Comment #1 from Kyle M Hall --- Created attachment 103311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103311&action=edit Bug 25222: Add ability to let plugins live in individual subdirectories From Tomas: "We really need to put each plugin in its own subdirectory (to identify them individually) and have a metadata file we can refer to." This would make things much more manageable. Right now, plugins get all mixed together in the plugins directory. For example, installing the kitchen sink plugin results in Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm being created in the plugins directory. Installing CoverFlow will create CoverFlow.pm in the same directory as KitchenSink.pm. There is no reason that plugins cannot be created to install in a subdirectory directly in the kpz file. In that case, the plugins directory would contain something like kitchen-sink/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm, while CoverFlow would live in coverflow/Koha/Plugin/Com/ByWaterSolutions/CoverFlow.pm. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Download the Kitchen Sink plugin 4) Rename it from kzp to zip 5) Unzip the plugin 6) Create a new directory kitchen-sink 7) move the Koha directory from the plugin into kitchen-sink 8) Zip the new kitchen-sink directory, include that directory in the zip file 9) Change the file suffix from zip to kpz 10) Install the plugin in Koha 11) The plugin should load! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25222] Add ability to let plugins live in individual subdirectories
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25222 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25174 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
