[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #211 from Jonathan Druart --- Bug 25261: (QA follow-up) Add confirmation to issues table I don't understand this patch. 1. The JS code is added in the "renew" function but we are talking about checkin 2. Why don't we simply don't remove the checkbox to prevent checkin (like we do for item on hold)? 3. The "Confirm" will no longer be displayed because of the table refresh, see bug 28653 and bug 36131. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Blocks||30519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30519 [Bug 30519] Regression: using sys pref CircConfirmItemParts prevents checkin from moremember.pl and circulation.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Caroline Cyr La Rose changed: What|Removed |Added Keywords||Manual-updated CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What|Removed |Added Blocks||29504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29504 [Bug 29504] Confirm Item Parts requires Force Checkout permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||27976 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27976 [Bug 27976] Add Granular options to CircConfirmItemParts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds the |This enhancement adds the release notes|option to require staff |option to require staff |members to confirm that an |members to confirm that an |item contains all it's |item contains all its |listed parts at |listed parts at |check-in/check-out time. |check-in/check-out time. || |New system preference: |New system preference: |`CircConfirmItemParts` |`CircConfirmItemParts` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #210 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds the release notes||option to require staff ||members to confirm that an ||item contains all it's ||listed parts at ||check-in/check-out time. || ||New system preference: ||`CircConfirmItemParts` Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target|release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #209 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #208 from Jonathan Druart --- Created attachment 111027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111027=edit Bug 25261: Prevent tests to fail if CircConfirmItemParts is on Setting items.materials to NULL at TestBuilder level will (certainly) prevent some tests to fail if the pref is on In t/db_dependent/selenium/basic_workflow.t we set 952$3 to an empty string. The tests will pass even if the pref is turned on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110375|0 |1 is obsolete|| --- Comment #206 from Martin Renvoize --- Created attachment 110934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110934=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #207 from Martin Renvoize --- Minor rebase for conflict caused by bug 25321. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110374|0 |1 is obsolete|| --- Comment #205 from Martin Renvoize --- Created attachment 110933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110933=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110373|0 |1 is obsolete|| --- Comment #204 from Martin Renvoize --- Created attachment 110932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110932=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110370|0 |1 is obsolete|| --- Comment #201 from Martin Renvoize --- Created attachment 110929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110929=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110371|0 |1 is obsolete|| --- Comment #202 from Martin Renvoize --- Created attachment 110930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110930=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110372|0 |1 is obsolete|| --- Comment #203 from Martin Renvoize --- Created attachment 110931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110931=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110369|0 |1 is obsolete|| --- Comment #200 from Martin Renvoize --- Created attachment 110928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110928=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110368|0 |1 is obsolete|| --- Comment #199 from Martin Renvoize --- Created attachment 110927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110927=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110365|0 |1 is obsolete|| --- Comment #196 from Martin Renvoize --- Created attachment 110924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110924=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110366|0 |1 is obsolete|| --- Comment #197 from Martin Renvoize --- Created attachment 110925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110925=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110367|0 |1 is obsolete|| --- Comment #198 from Martin Renvoize --- Created attachment 110926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110926=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110364|0 |1 is obsolete|| --- Comment #195 from Martin Renvoize --- Created attachment 110923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110923=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110363|0 |1 is obsolete|| --- Comment #194 from Martin Renvoize --- Created attachment 110922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110922=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110362|0 |1 is obsolete|| --- Comment #193 from Martin Renvoize --- Created attachment 110921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110921=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110359|0 |1 is obsolete|| --- Comment #190 from Martin Renvoize --- Created attachment 110918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110918=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110360|0 |1 is obsolete|| --- Comment #191 from Martin Renvoize --- Created attachment 110919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110919=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110358|0 |1 is obsolete|| --- Comment #189 from Martin Renvoize --- Created attachment 110917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110917=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110361|0 |1 is obsolete|| --- Comment #192 from Martin Renvoize --- Created attachment 110920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110920=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110357|0 |1 is obsolete|| --- Comment #188 from Martin Renvoize --- Created attachment 110916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110916=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110356|0 |1 is obsolete|| --- Comment #187 from Martin Renvoize --- Created attachment 110915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110915=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110340|0 |1 is obsolete|| --- Comment #185 from Katrin Fischer --- Created attachment 110374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110374=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110338|0 |1 is obsolete|| --- Comment #183 from Katrin Fischer --- Created attachment 110372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110372=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110341|0 |1 is obsolete|| --- Comment #186 from Katrin Fischer --- Created attachment 110375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110375=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110339|0 |1 is obsolete|| --- Comment #184 from Katrin Fischer --- Created attachment 110373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110373=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110335|0 |1 is obsolete|| --- Comment #180 from Katrin Fischer --- Created attachment 110369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110369=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110334|0 |1 is obsolete|| --- Comment #179 from Katrin Fischer --- Created attachment 110368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110368=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110337|0 |1 is obsolete|| --- Comment #182 from Katrin Fischer --- Created attachment 110371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110371=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110336|0 |1 is obsolete|| --- Comment #181 from Katrin Fischer --- Created attachment 110370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110370=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110333|0 |1 is obsolete|| --- Comment #178 from Katrin Fischer --- Created attachment 110367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110367=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110330|0 |1 is obsolete|| --- Comment #175 from Katrin Fischer --- Created attachment 110364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110364=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110332|0 |1 is obsolete|| --- Comment #177 from Katrin Fischer --- Created attachment 110366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110366=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110331|0 |1 is obsolete|| --- Comment #176 from Katrin Fischer --- Created attachment 110365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110365=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110328|0 |1 is obsolete|| --- Comment #173 from Katrin Fischer --- Created attachment 110362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110362=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110329|0 |1 is obsolete|| --- Comment #174 from Katrin Fischer --- Created attachment 110363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110363=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110327|0 |1 is obsolete|| --- Comment #172 from Katrin Fischer --- Created attachment 110361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110361=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110324|0 |1 is obsolete|| --- Comment #169 from Katrin Fischer --- Created attachment 110358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110358=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110326|0 |1 is obsolete|| --- Comment #171 from Katrin Fischer --- Created attachment 110360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110360=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110325|0 |1 is obsolete|| --- Comment #170 from Katrin Fischer --- Created attachment 110359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110359=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110322|0 |1 is obsolete|| --- Comment #167 from Katrin Fischer --- Created attachment 110356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110356=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Attachment #110323|0 |1 is obsolete|| --- Comment #168 from Katrin Fischer --- Created attachment 110357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110357=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #166 from Martin Renvoize --- (In reply to Katrin Fischer from comment #144) > I retested this: > > - Turn on multi part checking and edit 30018 to have $3 > - Check out 30018 in staff > - Go to sco/sco-main.pl > - The checkout shows in the table of checkouts > - The last column is "Renew item" > - Click on it, click "Renew" - page refreshes, all is good > - Apply patches, repeat > - Renew doesn't direct back to the overview page anymore Rebased on master should have fixed this.. you were seeing a manifestation of bug 26301 which was pushed to master over night. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110268|0 |1 is obsolete|| --- Comment #165 from Martin Renvoize --- Created attachment 110341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110341=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110258|0 |1 is obsolete|| --- Comment #163 from Martin Renvoize --- Created attachment 110339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110339=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110259|0 |1 is obsolete|| --- Comment #164 from Martin Renvoize --- Created attachment 110340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110340=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110184|0 |1 is obsolete|| --- Comment #162 from Martin Renvoize --- Created attachment 110338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110338=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110049|0 |1 is obsolete|| --- Comment #157 from Martin Renvoize --- Created attachment 110333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110333=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110051|0 |1 is obsolete|| --- Comment #159 from Martin Renvoize --- Created attachment 110335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110335=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110133|0 |1 is obsolete|| --- Comment #161 from Martin Renvoize --- Created attachment 110337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110337=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110052|0 |1 is obsolete|| --- Comment #160 from Martin Renvoize --- Created attachment 110336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110336=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110048|0 |1 is obsolete|| --- Comment #156 from Martin Renvoize --- Created attachment 110332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110332=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110050|0 |1 is obsolete|| --- Comment #158 from Martin Renvoize --- Created attachment 110334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110334=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110044|0 |1 is obsolete|| --- Comment #152 from Martin Renvoize --- Created attachment 110328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110328=edit Bug 25261: (QA follow-up) Simplify tests and conditions Use build_sample_item in tests Simplify tests for the confirmation Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110046|0 |1 is obsolete|| --- Comment #154 from Martin Renvoize --- Created attachment 110330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110330=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110047|0 |1 is obsolete|| --- Comment #155 from Martin Renvoize --- Created attachment 110331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110331=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110043|0 |1 is obsolete|| --- Comment #151 from Martin Renvoize --- Created attachment 110327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110327=edit Bug 25261: (QA follow-up) Add unit tests Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110041|0 |1 is obsolete|| --- Comment #149 from Martin Renvoize --- Created attachment 110325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110325=edit Bug 25261: (follow-up) Rename CircConfirmParts to CircConfirmItemParts This clarifies the preference name to make it clear we are talking about the 'parts' that make up an 'item'. 'Part' is a well known term in british english libraries and I think perhaps 'Materials' may be confused with other terms? Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110042|0 |1 is obsolete|| --- Comment #150 from Martin Renvoize --- Created attachment 110326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110326=edit Bug 25261: (follow-up) item.material may contain non-numerics Whilst QAing bug 13547 it was highlighted to me the at the 952$3 field, and thus the item.materials field, may contain arbitrary notes about the material rather than just numeric values. As such we need to check for the field being defined as aposed to greater than '0'. Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110045|0 |1 is obsolete|| --- Comment #153 from Martin Renvoize --- Created attachment 110329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110329=edit Bug 25261: (QA follow-up) Non-confirm on return This patch updates the confirmation from an alert to a dismissable modal which allows for optionally not checking the item in Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110040|0 |1 is obsolete|| --- Comment #148 from Martin Renvoize --- Created attachment 110324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110324=edit Bug 25261: Checkout confirmation depending on syspref With this follow-up patch, the intended confirmation of checkin based on CircConfirmParts value is effective. Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110039|0 |1 is obsolete|| --- Comment #147 from Martin Renvoize --- Created attachment 110323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110323=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an item to contain multiple parts by populating 'Materials specified (bound volume or other part)' 2/ Enable the new system preference 'CircConfirmParts' 3/ Attempt to checkout the item created in step 1 to a user and note that confirmation is now required. 4/ Checkout the item 5/ Attempt to checkin the item you have just checked out and note that confirmation is required. 6/ Signoff Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #110038|0 |1 is obsolete|| --- Comment #146 from Martin Renvoize --- Created attachment 110322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110322=edit Bug 25261: Add system preference Sponsored-by: Royal College of Music [https://www.rcm.ac.uk/] Sponsored-by: PTFS Europe [https://ptfs-europe.com/] Signed-off-by: Frédéric Demians Signed-off-by: Kyle M Hall Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #145 from Martin Renvoize --- Right.. you were getting caught by bug 26301.. which got pushed to master last night! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #144 from Katrin Fischer --- I retested this: - Turn on multi part checking and edit 30018 to have $3 - Check out 30018 in staff - Go to sco/sco-main.pl - The checkout shows in the table of checkouts - The last column is "Renew item" - Click on it, click "Renew" - page refreshes, all is good - Apply patches, repeat - Renew doesn't direct back to the overview page anymore -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #143 from Martin Renvoize --- Created attachment 110268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110268=edit Bug 25261: (QA follow-up) Prevent server error on bad barcode Prior to this patch if you had CircConfirmParts enabled and you attempted to checkin a deleted item then you would be met with a server error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #142 from Katrin Fischer --- > > I also had trouble with the 'renew' option from here - could you try that > > please? > > This is a bit weird; but I don't think it's anything to do with this bug. > The renewal goes through as expected if you look at the data, but I would > expect the page to redirect back to the logged in SCO session rather than > just leave you on the confirmation page. The behaviour pre-exists this bug > though, so I'd prefer to fix it in it's own bug. It worked for me without the patches - the page did then reload for me. Same item as with the confirmation. I can retest, but it might be related. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #141 from Katrin Fischer --- (In reply to Martin Renvoize from comment #140) > (In reply to Katrin Fischer from comment #134) > > Note: There are some issues with the CSS there - the Renew item link is not > > obvious as a button - and I am not sure why the normal return option doesn't > > display :( > > Not related to this bug; certainly one to raise on it's own bug. Forgot to update here, already filed 2 new bugs for this: Bug 26479 Bug 26478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #140 from Martin Renvoize --- (In reply to Katrin Fischer from comment #134) > Note: There are some issues with the CSS there - the Renew item link is not > obvious as a button - and I am not sure why the normal return option doesn't > display :( Not related to this bug; certainly one to raise on it's own bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #139 from Martin Renvoize --- (In reply to Katrin Fischer from comment #135) > > 2) Self check out (sco-main) > > I also had trouble with the 'renew' option from here - could you try that > please? This is a bit weird; but I don't think it's anything to do with this bug. The renewal goes through as expected if you look at the data, but I would expect the page to redirect back to the logged in SCO session rather than just leave you on the confirmation page. The behaviour pre-exists this bug though, so I'd prefer to fix it in it's own bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #138 from Martin Renvoize --- Created attachment 110259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110259=edit Bug 25261: (QA follow-up) Catch attepts to return via SCO This patch adds a block to capture attempts to return items with attached materials when checking in via the self checkout when the relevant system preference is set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #137 from Martin Renvoize --- Created attachment 110258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110258=edit Bug 25261: (QA follow-up) Make issue and returns messages consistent This patch makes the confirmation dialogue handing and visuality consistent between issues and returns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #136 from Katrin Fischer --- sci-main is ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #135 from Katrin Fischer --- > 2) Self check out (sco-main) I also had trouble with the 'renew' option from here - could you try that please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #134 from Katrin Fischer --- 1) Check in via check in page With confirmation off: When returning an item with $3 the dialog is blue. With the patch, the dialog is yellow and has a list item. I believe that the previous formatting should be kept in this case, so that checkout and checkin match up. With confirmation on: There is a similar problem as before with the modal AND the normal message showing in the background. I think we should only show the modal in this case. Visually I would maybe make the $3 content in the message stand out a bit more, making it maybe? 2) Self check out (sco-main) On self check out with returns allowed (SCOAllowCheckin): When you click on "renew item", it asks if you want to renew or return it. You can then successfully return the item from this dialog. Note: There are some issues with the CSS there - the Renew item link is not obvious as a button - and I am not sure why the normal return option doesn't display :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #133 from Martin Renvoize --- Corrected in followup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #132 from Martin Renvoize --- Created attachment 110184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110184=edit Bug 25261: (QA follow-up) Prevent double dialogue This patch removes the blue information message box if we are using multi-part confirmations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #131 from Katrin Fischer --- When checking out an item with $3 set and the syspref active, I see both the old blue 'information dialog' and the new yellow 'confirmation dialog'. The information shown is doubled up this way - I believe if we ask for confirmation the blue one should not appear? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #130 from Katrin Fischer --- Created attachment 110133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110133=edit Bug 25261: (QA follow-up) Terminology: checkin/checkout -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109508|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 110052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110052=edit Bug 25261: (QA follow-up) Restore previously returned list Test plan 0 - Enable ShowAllCheckins 1 - Check in several regular items 2 - Check in an item with parts 3 - Confirm the checkin in 4 - The list of checkins contains all the previous checkins and the multi-part checkin too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109499|0 |1 is obsolete|| --- Comment #123 from Martin Renvoize --- Created attachment 110046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110046=edit Bug 25261: (QA follow-up) Add confirmation to issues table The issues table allows for checkins and was not appropriately requireing confirmation for the multi-part confirmation added in this bug. Test plan 1/ Enable the feature as per previous patches 2/ Checkot an item with attached materials 3/ Navigate to a page that display your users issues table (the checkout page is a reasonable example) 4/ You should have the option to select items for return in the table (If not, use the column settings to enable the feature) 5/ Select at least the item with attached materials to return 6/ Upon clicking the return buttton you should find that items without additional materials are returned as expected, but rows with additional materials turn yellow and contain a message and additional checkbox for confirmation in the table. 7/ Ensure the checkbox is selected and click the return button again 8/ This item should have been returned. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109501|0 |1 is obsolete|| --- Comment #125 from Martin Renvoize --- Created attachment 110048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110048=edit Bug 25261: (QA follow-up) Add handling to SCO Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via the SCO 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109504|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 110051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110051=edit Bug 25261: (QA follow-up) Capitalize return of needsconfirm This patch capitalizes the 'ADDITIONAL_MATERIALS' key in the needsconfirm hash return value for CanBookBeIssued to restore consistency with previous code and ensure SIP Checkout works as expected. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109503|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 110050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110050=edit Bug 25261: (QA follow-up) Add handling to SCI Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via the SCI 3/ Note that the return is blocked with the message '(The item cannot be returned at a self service terminal, please see library staff for assistance)' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109502|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 110049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110049=edit Bug 25261: (QA follow-up) Catch check in SIP Checkin Test plan 1/ Enable the feature as per previous patches 2/ Attempt to return an item with materials attached via a SIP unit 3/ Note that the return is blocked with an alert type of '99' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Attachment #109500|0 |1 is obsolete|| --- Comment #124 from Martin Renvoize --- Created attachment 110047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110047=edit Bug 25261: (QA follow-up) Catch check in SIP Checkout Test plan 1/ Enable the feature as per previous patches 2/ Attempt to checkout an item with materials attached via a SIP unit 3/ Note that the checkut is blocked with the message 'Item must be issued at a circulation desk' 4/ Signoff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
