[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 David Cook changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from David Cook --- *** This bug has been marked as a duplicate of bug 27594 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #12 from David Cook --- (In reply to Tomás Cohen Arazi from comment #11) > I don't think we should add workarounds for old browsers. > I'd just keep the feature for supported browsers. Hmm, I suppose that would be all right. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #11 from Tomás Cohen Arazi --- I don't think we should add workarounds for old browsers. I'd just keep the feature for supported browsers. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #10 from David Cook --- (In reply to Katrin Fischer from comment #8) > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt >OK filters >FAIL forbidden patterns > forbidden pattern: console.log (line 435) > > I believe the line can just be removed? Yep. Just haven't gotten around to it yet heh. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #9 from Katrin Fischer --- Please also see comment #7 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #8 from Katrin Fischer --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt OK filters FAIL forbidden patterns forbidden pattern: console.log (line 435) I believe the line can just be removed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #7 from David Cook --- (In reply to Sally from comment #6) > (In reply to David Cook from comment #5) > > > > As far as I know, that shouldn't be an issue. I tested this using a HTTP > > site. > > > > What browser did you use and what exact issue did you have? > > The problem is this: > > 5b) If you're using a modern browser, try Ctrl+V somewhere and note > that the URL has already been copied to your clipboard > > (If the browser supports the Clipboard API, the URL is also written to the > browser's clipboard, making manually copying from the modal redundant.) > > This doesn't happen for me on the sandbox - I had to manually copy the link > from the modal, because Ctrl+V still retains my previous clipboard contents. > > The web browser is Chrome 86. Hmm that's interesting. It should've worked for you. Maybe I'll have to test this one again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #6 from Sally --- (In reply to David Cook from comment #5) > > As far as I know, that shouldn't be an issue. I tested this using a HTTP > site. > > What browser did you use and what exact issue did you have? The problem is this: 5b) If you're using a modern browser, try Ctrl+V somewhere and note that the URL has already been copied to your clipboard (If the browser supports the Clipboard API, the URL is also written to the browser's clipboard, making manually copying from the modal redundant.) This doesn't happen for me on the sandbox - I had to manually copy the link from the modal, because Ctrl+V still retains my previous clipboard contents. The web browser is Chrome 86. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #5 from David Cook --- (In reply to Sally from comment #3) > This works but perhaps someone else wants to test the automatic link copying > using a HTTPS site? > > The sandbox I was using doesn't have an SSL certificate, so the link wasn't > automatically copied to the clipboard, because Clipboard API isn't supported > on HTTP. As far as I know, that shouldn't be an issue. I tested this using a HTTP site. What browser did you use and what exact issue did you have? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #4 from David Cook --- Comment on attachment 111296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111296 Bug 25475: add "Copy link" button to upload.pl Review of attachment 111296: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=25475=111296) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload.tt @@ +431,5 @@ > +var popup = ' class="modal-dialog"> class="modal-body">'+res+'' > +$(popup).modal(); > +} > + > +console.log(res); Oops. That's a bit of debugging code that shouldn't be there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk Status|Needs Signoff |Signed Off --- Comment #3 from Sally --- This works but perhaps someone else wants to test the automatic link copying using a HTTPS site? The sandbox I was using doesn't have an SSL certificate, so the link wasn't automatically copied to the clipboard, because Clipboard API isn't supported on HTTP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #104858|0 |1 is obsolete|| --- Comment #2 from PTFS Europe Sandboxes --- Created attachment 111296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111296=edit Bug 25475: add "Copy link" button to upload.pl This patch adds a "Copy link" button to /cgi-bin/koha/tools/upload.pl. It will create a modal that displays a URL like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe Users can then copy the URL from that modal. If the browser supports the Clipboard API, the URL is also written to the browser's clipboard, making manually copying from the modal redundant. Test plan: 0) Apply patch 1) Go to http://localhost:8081/cgi-bin/koha/tools/upload.pl 2) Upload a file with the "Allow public downloads" box checked 3) Note the "Copy link" button in the "Actions" column 4) Click "Copy link" 5) Note that a modal is created with contents like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe 5b) If you're using a modern browser, try Ctrl+V somewhere and note that the URL has already been copied to your clipboard 6) Manually highlight the text in the modal and Ctrl+C 7) Click outside the modal 8) Paste the URL somewhere useful like a system preference or News item 9) Profit Signed-off-by: Sally -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 David Cook changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 --- Comment #1 from David Cook --- Created attachment 104858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104858=edit Bug 25475: add "Copy link" button to upload.pl This patch adds a "Copy link" button to /cgi-bin/koha/tools/upload.pl. It will create a modal that displays a URL like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe Users can then copy the URL from that modal. If the browser supports the Clipboard API, the URL is also written to the browser's clipboard, making manually copying from the modal redundant. Test plan: 0) Apply patch 1) Go to http://localhost:8081/cgi-bin/koha/tools/upload.pl 2) Upload a file with the "Allow public downloads" box checked 3) Note the "Copy link" button in the "Actions" column 4) Click "Copy link" 5) Note that a modal is created with contents like the following: http://kohadev.myDNSname.org:8080/cgi-bin/koha/opac-retrieve-file.pl? id=beb928969032f980056ea8269bc816fe 5b) If you're using a modern browser, try Ctrl+V somewhere and note that the URL has already been copied to your clipboard 6) Manually highlight the text in the modal and Ctrl+C 7) Click outside the modal 8) Paste the URL somewhere useful like a system preference or News item 9) Profit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25475] upload.pl should provide a "Copy link" option
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25475 David Cook changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |dc...@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
