[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 --- Comment #3 from Tomás Cohen Arazi --- Created attachment 104856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104856=edit Bug 25482: Wrong permissions specification for adv editor macros The current permissions are defined as a hash, with a duplicate key. This is generally invalid, but Debian 9's Mojolicious::Plugin::OpenAPI lets it go through, even though the results are, random? This patch sets the required permissions right, and following the haspermissions() syntax correctly. Tests for searching macros are not passing. Still trying to figure. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 --- Comment #2 from Tomás Cohen Arazi --- Oh, they are, on a separate file :-D t/db_dependent/Auth/haspermission.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added CC|ro...@catalyst.net.nz |n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482
Tomás Cohen Arazi changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
|ity.org |
--- Comment #1 from Tomás Cohen Arazi ---
Found the issue. It took me a while
The thing is, the JSON::Validator/openAPI plugin combination we have in D9 is
very loose, and doesn't catch a problem in the Advanced editor macros routes
spec. Basically, there are routes that have:
x-koha-permission: {
editcatalogue => 'advanced_editor',
editcatalogue => 'delete_shared_macros',
}
which is basically invalid, as you shouldn't be able to define a hash with two
values for the same key.
My first attempt was to just to the expected thing:
x-koha-permission: {
"editcatalogue" => [
'advanced_editor',
'delete_shared_macros'
]
}
This should work, but it doesn't really. Plack would be back to work, but
C4::Auth::haspermission validates the permissions when it shouldn't. At least
that's what running
$ prove t/db_dependent/api/v1/advanced_editor_macros.t
tells.
I will review the tests tomorrow (too tired today). It is possible that the
permissions assignment taking place in the tests is incorrect.
I was about to write a regression test for C4::Auth for this case, and see
what's going on, but... to my dismay... couldn't find tests...
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Jonathan Druart changed: What|Removed |Added Keywords||rel_20_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25482] koha-plack not working under D10
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25482 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
