[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens changed: What|Removed |Added Blocks||35293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35293 [Bug 35293] Regression: Bug 33390 (QA follow-up) patch overwrote the template changes to bug 25560 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Nick Clemens changed: What|Removed |Added Blocks||35692 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35692 [Bug 35692] ONLYMESSAGE option in UpdateNotforLoanStatusOnCheckin is not honored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Martin Renvoize changed: What|Removed |Added Text to go in the|The |The release notes|UpdateNotForLoanStatusOnChe |`UpdateNotForLoanStatusOnCh |ckin system preference is |eckin` system preference is |now more configurable: you |now more configurable: you |can define rules to be |can define rules to be |applied to specific item|applied to specific item |types upon check-in. |types upon check-in. | | |Add |Add |the item type code followed |the item type code followed |by a colon, and then on |by a colon, and then on |separate lines below define |separate lines below define |each notforloan value pair |each notforloan value pair |with leading spaces.|with leading spaces. |Example: |Example: | | |BK |BK | -1: 0 | -1: 0 | | |You |You |can use an _ALL_ wildcard |can use an _ALL_ wildcard |to target all item types. |to target all item types. |The _ALL_ wildcard does NOT |The *_ALL_* wildcard does |override item-type specific |NOT override item-type |rules. |specific rules. |Example: |Example: | | |_ALL_: |_ALL_: || -1: 2 |-1: 2 | | |If an item |If an item type is |type is not defined in the |not defined in the |`UpdateNotForLoanStatusOnCh |UpdateNotForLoanStatusOnChe |eckin` system preference, |ckin system preference, and |and there are no *_ALL_* |there are no _ALL_ rules|rules defined, then items |defined, then items of that |of that type will not have |type will not have their|their notforloan status |notforloan status change on |change on check-in, |check-in, irrespective of |irrespective of their |their current notforloan|current notforloan value. |value. | CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer changed: What|Removed |Added Status|Pushed to master|Needs documenting -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #89 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katie Bliss changed: What|Removed |Added CC||kebl...@dmpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #88 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||23.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_23_11_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #87 from Kyle M Hall --- Created attachment 148683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148683=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #86 from Kyle M Hall --- Created attachment 148682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148682=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: _ALL_: -1: 0 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' (NOT_LOAN=0) 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: _ALL_: -1: 0 CD: -1: 2 2: 0 9. Check-in an 'ordered' (NOT_LOAN=-1) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Staff collection' (NOT_LOAN=2). This is because the _ALL_ rule does not override all other rules. 10. Check-in a 'Staff collection' (NOT_LOAN=2) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Available for loan' (NOT_LOAN=0) 11. Check-in a 'Staff collection' (NOT_LOAN=2) DVD item (item level itype='DVD') and observe the items notforloan status does not change 12. Check-in an 'ordered' (NOT_LOAN=-1) DVD item (item level itype='DVD') and observe the items notforloan status updates to 'Available for loan' (NOT_LOAN=0) Sponsored-By: Waikato Institute of Technology, NZ Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #85 from Kyle M Hall --- Created attachment 148681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148681=edit Bug 25560: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall changed: What|Removed |Added Attachment #148679|0 |1 is obsolete|| --- Comment #84 from Kyle M Hall --- Created attachment 148680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148680=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall changed: What|Removed |Added Attachment #146556|0 |1 is obsolete|| Attachment #146557|0 |1 is obsolete|| Attachment #146558|0 |1 is obsolete|| Attachment #146993|0 |1 is obsolete|| --- Comment #83 from Kyle M Hall --- Created attachment 148679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148679=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Text to go in the|The |The release notes|UpdateNotForLoanStatusOnChe |UpdateNotForLoanStatusOnChe |ckin system preference is |ckin system preference is |now more flexible: you can |now more configurable: you |define rules to be applied |can define rules to be |to specific item types upon |applied to specific item |check-in. |types upon check-in. | | |Adding the item |Add |type code followed by a |the item type code followed |colon, and then in separate |by a colon, and then on |lines below each value pair |separate lines below define |rules with leading spaces. |each notforloan value pair |Example: |with leading spaces. | |Example: |BK | | -1: 0 |BK | | -1: 0 |If an | |item type is not defined in |You |UpdateNotForLoanStatusOnChe |can use an _ALL_ wildcard |ckin then items of that |to target all item types. |type will not have their|The _ALL_ wildcard does NOT |notforloan status change on |override item-type specific |check-in, irrespective of |rules. |their current notforloan|Example: |value. | ||_ALL_: || ||-1: 2 || ||If an item type is ||not defined in the ||UpdateNotForLoanStatusOnChe ||ckin system preference, and ||there are no _ALL_ rules ||defined, then items of that ||type will not have their ||notforloan status change on ||check-in, irrespective of ||their current notforloan ||value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Status|ASSIGNED|Signed Off --- Comment #82 from Alex Buckley --- (In reply to Kyle M Hall from comment #72) > Alex, why not add a wildcard option ( say "*" )? That way, if a notforloan > change applies to all itemtypes, it won't require creating a section for > each and every itemtype. It should also simplify the upgrade patch. Hi Kyle, Setting this back to 'Signed-off' as Katrin said in comment #74. I have added the _ALL_ wildcard, like how Nick suggested in comment #62 . Also, as suggested in that comment I have made this wildcard not override other rules. I've also updated the unit tests to test using the wildcard. Could you please take a look and let me know what other changes might be needed for QA? Thanks, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #81 from Alex Buckley --- Created attachment 146993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146993=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #146559|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #80 from Alex Buckley --- I've attached some updated patches that use a wildcard '_ALL_' as a special term to apply for all item types. These patches are not quite ready for testing yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #79 from Alex Buckley --- Created attachment 146559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146559=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #78 from Alex Buckley --- Created attachment 146558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146558=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: _ALL_: -1: 0 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' (NOT_LOAN=0) 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: _ALL_: -1: 0 CD: -1: 2 2: 0 9. Check-in an 'ordered' (NOT_LOAN=-1) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Staff collection' (NOT_LOAN=2). This is because the _ALL_ rule does not override all other rules. 10. Check-in a 'Staff collection' (NOT_LOAN=2) CD item (item level itype='CD') and observe the item's notforloan status updates to 'Available for loan' (NOT_LOAN=0) 11. Check-in a 'Staff collection' (NOT_LOAN=2) DVD item (item level itype='DVD') and observe the items notforloan status does not change 12. Check-in an 'ordered' (NOT_LOAN=-1) DVD item (item level itype='DVD') and observe the items notforloan status updates to 'Available for loan' (NOT_LOAN=0) Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #77 from Alex Buckley --- Created attachment 146557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146557=edit Bug 25560: Template changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #76 from Alex Buckley --- Created attachment 146556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146556=edit Bug 25560: Database changes Sponsored-by: Waikato Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138494|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138495|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138498|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138499|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #75 from Alex Buckley --- (In reply to Katrin Fischer from comment #74) > > > > I am working on amending my patches to do that now. > > > > Kind regards, > > Alex > > Hi Alex, moving this out of queue for now - please switch back to Signed-off > once you are ready! Hi Katrin, thank you, will do! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #74 from Katrin Fischer --- > > I am working on amending my patches to do that now. > > Kind regards, > Alex Hi Alex, moving this out of queue for now - please switch back to Signed-off once you are ready! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added CC||alexbuck...@catalyst.net.nz --- Comment #73 from Alex Buckley --- (In reply to Kyle M Hall from comment #72) > Alex, why not add a wildcard option ( say "*" )? That way, if a notforloan > change applies to all itemtypes, it won't require creating a section for > each and every itemtype. It should also simplify the upgrade patch. Hi Kyle, Thanks for this feedback. Chris and I had thought it might make it clearer having a separate section for each item type, that way there is no confusion around which rule (if there multiple conflicting ones) was prioritised for a particular itemtype. However, thinking about this more I think you and Nick (in comment #62) are right about having a wildcard option for every item type, and making for a simpler upgrade patch. I think Nick's suggestion of using the _ALL_ option as the wildcard, and having that override item type specific rules, like in UpdateItemLocationOnCheckin, would be good so as to maintain consistency in the sysprefs. I am working on amending my patches to do that now. Kind regards, Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com --- Comment #72 from Kyle M Hall --- Alex, why not add a wildcard option ( say "*" )? That way, if a notforloan change applies to all itemtypes, it won't require creating a section for each and every itemtype. It should also simplify the upgrade patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #71 from Fridolin Somers --- Careful Bug 30407 is also modifying this preference -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30407 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138497|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #70 from Alex Buckley --- Sorry I realised this patchset no longer checks what the item-level_itypes syspref is set to. I've removed that, as it is not checked on master, so I re-added the last two patches to reflect that. Ready for testing/review again :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #69 from Alex Buckley --- Created attachment 138499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138499=edit Bug 25560: Unit tests Test plan: 1. Run tests sudo koha-shell prove xt prove t/db_dependent/Circulation/issue.t Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Attachment #138496|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 Alex Buckley changed: What|Removed |Added Keywords||Manual, ||release-notes-needed Summary|Exclude itemtypes from |Define itemtype specific |UpdateNotForLoanStatusOnChe |rules in the |ckin|UpdateNotForLoanStatusOnChe ||ckin system preference Text to go in the|Add boolean flag|The release notes|itemtypes.updatenotforloan, |UpdateNotForLoanStatusOnChe |enabled by default. |ckin system preference is | |now more flexible: you can |When|define rules to be applied |this item type flag is |to specific item types upon |disabled items of that type |check-in. |will not be updated on | |check-in. |Adding the item ||type code followed by a ||colon, and then in separate ||lines below each value pair ||rules with leading spaces. ||Example: || ||BK || -1: 0 || ||If an ||item type is not defined in ||UpdateNotForLoanStatusOnChe ||ckin then items of that ||type will not have their ||notforloan status change on ||check-in, irrespective of ||their current notforloan ||value. --- Comment #67 from Alex Buckley --- (In reply to Nick Clemens from comment #62) > (In reply to Alex Buckley from comment #61) > > Just to note I have a working patchset that can use YAML defined in the > > UpdateNotForLoanStatusOnCheckin syspref like so: > > > > BK: > > -1: 0 > > > > CR: > > -2: 0 > > > > I am currently working on how to handle existing values in the syspref so > > they still apply for all itemtypes for upgrading libraries. > > Any suggestions would be much appreciated on this point. > > Maybe add an _ALL_ option - and then existing rules can be placed under > that? Similar to UpdateItemLocationOnCheckin - but probably not make _ALL_ > override the other rules as it does on that pref Thanks for that Nick. Am certainly happy to make that change if you would like. You will see in the attached patchset I have just added, that I'm listing the existing rules under each item type, like so: BK: -1: 0 CR: -1: 0 etc. The reason for this is I had a chat with Chris and we wondered whether having an _ALL_ option could create user confusion in which rule is overridden in a situation of conflicting rules, like: _ALL_: -1: 0 BK: -1: 2 By explicitly defining every item type and all rules that could apply for it, as I have in my attached patchset, it clarifies any potential confusion around rules overriding. It does, however, mean librarians will need to write a rule under every item type option for it to be applied to all items. I'm not sure if this should be 'Need signoff' so will leave it with the current setting for now. Happy to hear your thoughts though? :) Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25560] Define itemtype specific rules in the UpdateNotForLoanStatusOnCheckin system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25560 --- Comment #68 from Alex Buckley --- Created attachment 138498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138498=edit Bug 25560: Define item-type specific rules in UpdateNotForLoanStatusOnCheckin This enhancement respects the 'item-level_itypes' syspref, so will look at the authoritative item type when determining to update the notforloan status. Test plan: 1. Set -1 to 'Ordered', and 1 to 'Not for Loan' in Administration > Authorised values > NOT_LOAN 2. Make sure the 'item-level_itypes' syspref is set to 'specific item' 3. Add the following rules in UpdateNotForLoanStatusOnCheckin system preference: -1: 0 4. Apply patch & update database cd installer/data/mysql sudo koha-shell ./updatedatabase.pl 5. Restart plack 6. Observe the UpdateNotForLoanStatusOnCheckin syspref values have updated to the following format: : -1: 0 : -1: 0 etc. Each item type setup in Koha has the existing rule(s) listed under it 7. Check in an 'Ordered' item of any item type and confirm it is changed to 'Available for loan' 8. Reset the UpdateNotForLoanStatusOnCheckin syspref to: BK: -1: 0 CD: 1: 0 9. Check-in an 'ordered' BK item (item level itype='BK') and observe the item's notforloan status updates 10. Check-in a 'Not for Loan' CD item (item level itype='CD') and observe the item's notforloan status updates 11. Check-in an 'ordered' DVD item (item level itype='DVD') and observe the items notforloan status does not change Sponsored-By: Waikato Institute of Technology, NZ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
