[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616
Andrew Fuerste-Henry changed:
What|Removed |Added
CC||and...@bywatersolutions.com
--- Comment #31 from Andrew Fuerste-Henry ---
I'm getting these failures on the qa script when applying the 21.11 patches to
21.05:
FAIL t/Search.t
FAIL valid
Test2::Hub::plan(Test2::Hub=HASH(0x55c009a7ad60),
"SKIP") called
Test2::Hub::process(Test2::Hub=HASH(0x55c009a7ad60),
Test2::Event::Plan=HASH(0x55c00c82a630)) called
Test2::Hub::send(Test2::Hub=HASH(0x55c009a7ad60),
Test2::Event::Plan=HASH(0x55c00c82a630)) called
Test2::API::Context::send_event(Test2::API::Context=HASH(0x55c00c831440),
"Plan", "max", 0, "directive", "SKIP", "reason", "Skipping remaining tests
since we don't have a schema") called
Test2::API::Context::plan(Test2::API::Context=HASH(0x55c00c831440), 0, "SKIP",
"Skipping remaining tests since we don't have a schema") called
Test::Builder::skip_all(Test::Builder=HASH(0x55c0095c7af0), "Skipping remaining
tests since we don't have a schema") called
Test::DBIx::Class::_initialize_schema("Test::DBIx::Class",
HASH(0x55c00a915a80)) called
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Kyle M Hall changed: What|Removed |Added Version(s)|22.05.00|22.05.00,21.11.04 released in|| Status|Pushed to master|Pushed to stable --- Comment #30 from Kyle M Hall --- Pushed to 21.11.x for 21.11.04 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #29 from Fridolin Somers --- Bug 25616: (follow-up) Fix t/Search.t pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #28 from Fridolin Somers --- Created attachment 131293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131293=edit Bug 25616: [21.11.x] (follow-up) Fix t/Search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #27 from Fridolin Somers --- Created attachment 131292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131292=edit Bug 25616: (follow-up) Fix t/Search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #26 from Fridolin Somers --- Ah wait, t/Search.t/ is failling : # Failed test '$query built correctly (no operator)' # at t/Search.t line 90. # got: 'query AND parsed_operand' # expected: 'query and parsed_operand' # Failed test '$query_cgi built correctly (no operator)' # at t/Search.t line 92. # got: 'query_cgi=%20AND%20=index=original_operand' # expected: 'query_cgi=%20and%20=index=original_operand' # Failed test '$query_desc build correctly (no operator)' # at t/Search.t line 94. # got: 'query_desc AND index_plus original_operand' # expected: 'query_desc and index_plus original_operand' # Looks like you failed 3 tests of 20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #25 from Fridolin Somers --- (In reply to Kyle M Hall from comment #20) > Patches need rebased for 21.11.x if backport is needed. Here we go. Conflict solved on Koha::Biblio::get_marc_authors still in C4::Biblio::GetMarcAuthors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #24 from Fridolin Somers --- Created attachment 131164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131164=edit Bug 25616: [21.11.x] (QA follow-up) Catch a case in labels/label-item-search.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #23 from Fridolin Somers --- Created attachment 131163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131163=edit Bug 25616: [21.11.x] (follow-up) Use uppercase in advanced search booleans Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #22 from Fridolin Somers --- Created attachment 131162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131162=edit Bug 25616: [21.11.x] Fix t/db_dependent/Search.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #21 from Fridolin Somers --- Created attachment 131161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131161=edit Bug 25616: [21.11.x] Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #20 from Kyle M Hall --- Patches need rebased for 21.11.x if backport is needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #19 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 濾 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from Martin Renvoize --- Good catch, no regressions found and QA scripts are happy. I found another obvious case, and there are lots more `' and '` occurrences in the codebase that a possible cases of this. I think we should push this one as is and handle follow-ups in more bugs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #17 from Martin Renvoize --- Created attachment 131022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131022=edit Bug 25616: (QA follow-up) Catch a case in labels/label-item-search.pl Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130916|0 |1 is obsolete|| --- Comment #16 from Martin Renvoize --- Created attachment 131021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131021=edit Bug 25616: (follow-up) Use uppercase in advanced search booleans Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130915|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 131020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131020=edit Bug 25616: Fix t/db_dependent/Search.t Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added Attachment #130914|0 |1 is obsolete|| --- Comment #14 from Martin Renvoize --- Created attachment 131019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131019=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=30153 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Attachment #130589|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 130916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130916=edit Bug 25616: (follow-up) Use uppercase in advanced search booleans Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Attachment #130588|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 130915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130915=edit Bug 25616: Fix t/db_dependent/Search.t Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Attachment #130029|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 130914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130914=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #10 from Fridolin Somers --- Seems logical to use uppercase in advanced search page OPAC and staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #9 from Fridolin Somers --- Created attachment 130589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130589=edit Bug 25616: (follow-up) Use uppercase in advanced search booleans -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #8 from Fridolin Somers --- Created attachment 130588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130588=edit Bug 25616: Fix t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This looks all good, but I think we might need to fix tests: t/db_dependent/Search.t .. # Failed test 'Built composed implicit-and CCL keyword query' # at t/db_dependent/Search.t line 423. # 'kw,wrdl=(rk=(salud)) AND kw,wrdl=(rk=(higiene)) ' # doesn't match '(?^u:kw\W.*salud\W.*and.*kw\W.*higiene)' # Looks like you failed 1 test of 90. t/db_dependent/Search.t .. 1/3 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 906. t/db_dependent/Search.t .. 2/3 # Looks like you failed 1 test of 3. t/db_dependent/Search.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report --- t/db_dependent/Search.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 1 Non-zero exit status: 1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #6 from Fridolin Somers --- I found one more in C4::Search::_build_initial_query -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Attachment #105411|0 |1 is obsolete|| --- Comment #5 from Fridolin Somers --- Created attachment 130029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130029=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=26537 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Severity|enhancement |normal --- Comment #4 from Fridolin Somers --- Oh I've been searching hours on that bug. Need to be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #3 from David Gustafsson --- The same issue has been address in bug 23322 och bug 24506, but some instances of where operator case need to be changed remains and is addressed in this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 David Gustafsson changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #2 from David Gustafsson --- Regarding how to test. I have tested the fix in bulkmarimport.pl but regarding the others I am not all that familiar with Koha from a user-perspective and it would take me too long to write an how to test for all of them. One thing that could go wrong is that operator precedence for AND/OR is not what you expect and parentheses needs to be used for queries mixing them both. I tried to review all replacements and i THINK that AND/OR is not mixed in those places so should be ok and no extra precedence tweaking needed. Also think this will fix more than it could potentially break, but help in writing an how to test would otherwise be appreciated if this feels to risky to merge without one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25616] Uppercase hard coded lower case boolean operators for Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25616 --- Comment #1 from David Gustafsson --- Created attachment 105411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105411=edit Bug 25616: Uppercase hard coded lower case boolean operators for Elasticsearch Uppercase occurances of all (hopefully) lowercase "and" used in ElasticSearch Query String Query contexts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
