[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00, 20.05.03 |20.11.00, 20.05.03, released in||19.11.09 CC||alei...@catalyst.net.nz Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Aleisha Amohia --- backported to 19.11.x for 19.11.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Lucas Gass changed: What|Removed |Added Version(s)|20.11.00|20.11.00, 20.05.03 released in|| Status|Pushed to master|Pushed to stable CC||lu...@bywatersolutions.com --- Comment #8 from Lucas Gass --- backported to 20.05.x for 20.05.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 George Williams (NEKLS) changed: What|Removed |Added CC||geo...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 --- Comment #7 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Katrin Fischer changed: What|Removed |Added Attachment #106416|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 107372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107372=edit Bug 25724: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Katrin Fischer changed: What|Removed |Added Attachment #106417|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 107373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107373=edit Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105790|0 |1 is obsolete|| --- Comment #3 from Andrew Fuerste-Henry --- Created attachment 106416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106416=edit Bug 25724: Unit tests Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105791|0 |1 is obsolete|| --- Comment #4 from Andrew Fuerste-Henry --- Created attachment 106417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106417=edit Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Nick Clemens changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |n...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 --- Comment #1 from Nick Clemens --- Created attachment 105790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105790=edit Bug 25724: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 --- Comment #2 from Nick Clemens --- Created attachment 105791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105791=edit Bug 25724: Do not call ModReserveStatus when completing transfer I can not see how this code is useful here. It checks for a reserve with priority 0 and found = NULL That is not a status that should occur when filling a transfer. Either the found is 'T' if we are transferring due to the hold, or the hold was placed after the transfer was initiated, and so the priority is not 0 Additional, AddReturn checks for reserves later and asks the staff to confirm waiting status. ModReserveStatus also calls CartToShelf regardless of what happens here. To test: 1 - Set UpdateItemLocationOnCheckin to: _ALL_: CART 2 - SetAutomaticItemReturn = Do 3 - Check an item in at a different branch than it's homebranch to create a transfer 4 - Check the item in at it's homebranch 5 - View the item details page 6 - Item is not in CART location 7 - Apply patch 8 - Repeat 9 - Item is in CART location after completion of transfer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25724] Transferred item checked in to shelving cart has cart location removed when transfer is filled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25724 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
