[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Blocks||29133 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29133 [Bug 29133] Wrong string format in select2.inc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #47 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #46 from Jonathan Druart --- (In reply to Jonathan Druart from comment #45) > Created attachment 109361 [details] [review] > Bug 25727: (follow-up) Do not open options on clear Pushed to master for 20.11. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Attachment #109359|0 |1 is obsolete|| --- Comment #45 from Jonathan Druart --- Created attachment 109361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109361=edit Bug 25727: (follow-up) Do not open options on clear -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #44 from Jonathan Druart --- Created attachment 109359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109359=edit Bug 25727: (follow-up) Do not open options on clear -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #43 from Jonathan Druart --- (In reply to Jonathan Druart from comment #41) > (In reply to Katrin Fischer from comment #40) > > Should we file a bug for the width issue to keep open until it can be > > resolved? (maybe with the next version of select2?) > > I think we should reach them. I will do it next week. No need for that, see bug 26288. The next version (in beta so far) seems to fix the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #42 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #41 from Jonathan Druart --- (In reply to Katrin Fischer from comment #40) > Should we file a bug for the width issue to keep open until it can be > resolved? (maybe with the next version of select2?) I think we should reach them. I will do it next week. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #40 from Katrin Fischer --- Should we file a bug for the width issue to keep open until it can be resolved? (maybe with the next version of select2?) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108830|0 |1 is obsolete|| --- Comment #39 from Katrin Fischer --- Created attachment 108882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108882=edit Bug 25727: (follow-up) Some style updates, JS i18n This patch makes to general changes. First, it makes some minor style changes to the appearance of the dropdowns. Second, it moves the JS content in select2.inc into a separate JS file. This is made possible by Bug 21156. To test, apply the patch and view a page which uses the Select2 library, e.g. the add item screen. Confirm that the Select2-styled dropdowns look good and work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/select2.js for translation, e.g.: msgid "No results found" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test a Select2-styled dropdown. Test that translated strings appear. For example: - Use the filter form to search for a string which isn't found. You should see a translated version. - Make a selection in one of the dropdowns. Hover your mouse over the "X" icon which now appears. The tooltip should be a translated version. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108400|0 |1 is obsolete|| --- Comment #38 from Katrin Fischer --- Created attachment 108881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108881=edit Bug 25727: Default to dropdownAutoWidth This will set a correct width by default. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108395|0 |1 is obsolete|| --- Comment #37 from Katrin Fischer --- Created attachment 108880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108880=edit Bug 25727: Do not open options on clear We want to restore the previous behaviour and keep the options closed when clear is clicked https://github.com/select2/select2/issues/3320#issuecomment-621662039 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108354|0 |1 is obsolete|| --- Comment #35 from Katrin Fischer --- Created attachment 108878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108878=edit Bug 25727: Fix highlight of a missing field In the previous version of Select2 we had only 1 'a' tag that was visible, next to the invisible select. Now we have a 3 nested span elt, the last one (with a role=combobox attribute) is the one we want to style. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108355|0 |1 is obsolete|| --- Comment #36 from Katrin Fischer --- Created attachment 108879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108879=edit Bug 25727: (follow-up) Use CSS specificity rather than !important This patch adds specificty to the CSS which controls the "invalid" appearance of a Select2 dropdown so that the use of "!important" can be avoided. The patch also puts this style into our custom select2 CSS file so that it is located with other Select2 style changes. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727
Katrin Fischer changed:
What|Removed |Added
Attachment #108353|0 |1
is obsolete||
--- Comment #34 from Katrin Fischer ---
Created attachment 108877
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108877=edit
Bug 25727: Fix default values
The way we defined the default values does not longer work (?)
Using
$.fn.select2.defaults.set
instead of
jQuery.extend($.fn.select2.defaults, {
fixes the problem.
It restores the allowClear setting.
There is a change in the behavior here, the selection opens when the
clear button is clicked. That is coming from a change in Select2
apparently. We may want to hack something to restore the precedent
behaviour.
This patch also removes the redefinition of the width. It seems that the
issue that this code was trying to correct is now fixed.
Signed-off-by: Owen Leonard
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108352|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 108876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108876=edit Bug 25727: Adjust translations Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Attachment #108351|0 |1 is obsolete|| --- Comment #32 from Katrin Fischer --- Created attachment 108875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108875=edit Bug 25727: Upgrade the Select2 JS lib to version 4 In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging Test plan: Confirm that there is no visible regression on dropdown list with select2 Like edit a bibliographic records, and the items. Sponsored-by: Orex Digital Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Attachment #108829|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 108830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108830=edit Bug 25727: (follow-up) Some style updates, JS i18n This patch makes to general changes. First, it makes some minor style changes to the appearance of the dropdowns. Second, it moves the JS content in select2.inc into a separate JS file. This is made possible by Bug 21156. To test, apply the patch and view a page which uses the Select2 library, e.g. the add item screen. Confirm that the Select2-styled dropdowns look good and work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/select2.js for translation, e.g.: msgid "No results found" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test a Select2-styled dropdown. Test that translated strings appear. For example: - Use the filter form to search for a string which isn't found. You should see a translated version. - Make a selection in one of the dropdowns. Hover your mouse over the "X" icon which now appears. The tooltip should be a translated version. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Attachment #108823|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 108829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108829=edit Bug 25727: (follow-up) Some style updates, JS i18n This patch makes to general changes. First, it makes some minor style changes to the appearance of the dropdowns. Second, it moves the JS content in select2.inc into a separate JS file. This is made possible by Bug 21156. To test, apply the patch and view a page which uses the Select2 library, e.g. the add item screen. Confirm that the Select2-styled dropdowns look good and work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/select2.js for translation, e.g.: msgid "No results found" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test a Select2-styled dropdown. Test that translated strings appear. For example: - Use the filter form to search for a string which isn't found. You should see a translated version. - Make a selection in one of the dropdowns. Hover your mouse over the "X" icon which now appears. The tooltip should be a translated version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Attachment #108436|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #29 from Owen Leonard --- > Bug 25727: Do not wrap option text My patch excludes this one. I think it's preferable to have the option text wrap rather than have horizontal scrollbars. I tried but was unable to improve the width of the dropdowns. I consider it a bug in this version of Select2 because I don't think there is a configuration option that will solve it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #28 from Owen Leonard --- Created attachment 108823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108823=edit Bug 25727: (follow-up) Some style updates, JS i18n This patch makes to general changes. First, it makes some minor style changes to the appearance of the dropdowns. Second, it moves the JS content in select2.inc into a separate JS file. This is made possible by Bug 21156. To test, apply the patch and view a page which uses the Select2 library, e.g. the add item screen. Confirm that the Select2-styled dropdowns look good and work correctly. TESTING TRANSLATABILITY - Update a translation, e.g. fr-FR: > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for JavaScript strings, e.g. misc/translator/po/fr-FR-messages-js.po - Locate strings pulled from koha-tmpl/intranet-tmpl/prog/js/select2.js for translation, e.g.: msgid "No results found" msgstr "" - Edit the "msgstr" string however you want (it's just for testing). - Install the updated translation: > perl translate install fr-FR - Switch to your newly translated language in the staff client and test a Select2-styled dropdown. Test that translated strings appear. For example: - Use the filter form to search for a string which isn't found. You should see a translated version. - Make a selection in one of the dropdowns. Hover your mouse over the "X" icon which now appears. The tooltip should be a translated version. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #27 from Katrin Fischer --- Ohoh. Would it make sense to ask others to take a look? I remember we resolved another tricky CSS issue latley with more brain power :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #26 from Jonathan Druart --- Katrin, this is all what I managed to do. It's not perfect and I am not sure you will be happy with it.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #25 from Jonathan Druart --- Created attachment 108436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108436=edit Bug 25727: Do not wrap option text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #24 from Katrin Fischer --- I think we are not quite there yet - location is ok now, but "Institut Protestant de Théologie" in the libraries list still wraps on 2 lines. I think they should probably adjust their width dynamically? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #23 from Jonathan Druart --- And this patch seems to fix 2! Can you confirm? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #22 from Jonathan Druart --- Created attachment 108400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108400=edit Bug 25727: Default to dropdownAutoWidth This will set a correct width by default. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #21 from Jonathan Druart --- 1. is fixed, for 2 I can take a look later. Today I am facing problems with yarn and cannot regenerate the css file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #20 from Jonathan Druart --- Created attachment 108395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108395=edit Bug 25727: Do not open options on clear We want to restore the previous behaviour and keep the options closed when clear is clicked https://github.com/select2/select2/issues/3320#issuecomment-621662039 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #19 from Katrin Fischer --- 1) I think the new behaviour of the x button that no longer clears the field is confusing and will cause a lot of questions in support. It did not always work nicely for me on the first go to select the 'empty' entry either. You mention in one of the comments that we might want to fix this and I think we should. 2) The second thing is that the sizes are slightly different. For example on the edit item form the location "New materials shelf" fits into one line before, but not after. I'd like to see the input fields adapt better to the length of the entries as this makes things harder to read. (Coming from someone whose language tends to have lng words). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #18 from Jonathan Druart --- Created attachment 108355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108355=edit Bug 25727: (follow-up) Use CSS specificity rather than !important This patch adds specificty to the CSS which controls the "invalid" appearance of a Select2 dropdown so that the use of "!important" can be avoided. The patch also puts this style into our custom select2 CSS file so that it is located with other Select2 style changes. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #17 from Jonathan Druart --- Created attachment 108354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108354=edit Bug 25727: Fix highlight of a missing field In the previous version of Select2 we had only 1 'a' tag that was visible, next to the invisible select. Now we have a 3 nested span elt, the last one (with a role=combobox attribute) is the one we want to style. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727
--- Comment #16 from Jonathan Druart
---
Created attachment 108353
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108353=edit
Bug 25727: Fix default values
The way we defined the default values does not longer work (?)
Using
$.fn.select2.defaults.set
instead of
jQuery.extend($.fn.select2.defaults, {
fixes the problem.
It restores the allowClear setting.
There is a change in the behavior here, the selection opens when the
clear button is clicked. That is coming from a change in Select2
apparently. We may want to hack something to restore the precedent
behaviour.
This patch also removes the redefinition of the width. It seems that the
issue that this code was trying to correct is now fixed.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Attachment #105975|0 |1 is obsolete|| Attachment #105976|0 |1 is obsolete|| Attachment #105977|0 |1 is obsolete|| Attachment #105978|0 |1 is obsolete|| Attachment #105980|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 108351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108351=edit Bug 25727: Upgrade the Select2 JS lib to version 4 In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging Test plan: Confirm that there is no visible regression on dropdown list with select2 Like edit a bibliographic records, and the items. Sponsored-by: Orex Digital Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #15 from Jonathan Druart --- Created attachment 108352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108352=edit Bug 25727: Adjust translations Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #13 from Jonathan Druart --- Thanks for the follow-up Owen. I did not do that because I though it was too tight with the select2 classes' names, but if you think it's the way to go, I am with you. However, should not we removed the definition in the staff-global.css then? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #12 from Owen Leonard --- Created attachment 105980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105980=edit Bug 25727: (follow-up) Use CSS specificity rather than !important This patch adds specificty to the CSS which controls the "invalid" appearance of a Select2 dropdown so that the use of "!important" can be avoided. The patch also puts this style into our custom select2 CSS file so that it is located with other Select2 style changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Attachment #105979|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727
--- Comment #9 from Owen Leonard ---
Created attachment 105977
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105977=edit
Bug 25727: Fix default values
The way we defined the default values does not longer work (?)
Using
$.fn.select2.defaults.set
instead of
jQuery.extend($.fn.select2.defaults, {
fixes the problem.
It restores the allowClear setting.
There is a change in the behavior here, the selection opens when the
clear button is clicked. That is coming from a change in Select2
apparently. We may want to hack something to restore the precedent
behaviour.
This patch also removes the redefinition of the width. It seems that the
issue that this code was trying to correct is now fixed.
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #8 from Owen Leonard --- Created attachment 105976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105976=edit Bug 25727: Adjust translations Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Attachment #105822|0 |1 is obsolete|| Attachment #105853|0 |1 is obsolete|| Attachment #105854|0 |1 is obsolete|| Attachment #105855|0 |1 is obsolete|| --- Comment #7 from Owen Leonard --- Created attachment 105975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105975=edit Bug 25727: Upgrade the Select2 JS lib to version 4 In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging Test plan: Confirm that there is no visible regression on dropdown list with select2 Like edit a bibliographic records, and the items. Sponsored-by: Orex Digital Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #11 from Owen Leonard --- Created attachment 105979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105979=edit Bug 25727: (follow-up) Use CSS specificity rather than !important This patch adds specificty to the CSS which controls the "invalid" appearance of a Select2 dropdown so that the use of "!important" can be avoided. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #10 from Owen Leonard --- Created attachment 105978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105978=edit Bug 25727: Fix highlight of a missing field In the previous version of Select2 we had only 1 'a' tag that was visible, next to the invisible select. Now we have a 3 nested span elt, the last one (with a role=combobox attribute) is the one we want to style. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #6 from Jonathan Druart --- (In reply to Owen Leonard from comment #2) Thanks Owen! > I see some issues with this when I compare the behavior in master to the > behavior when this patch is applied: > > - In master when there are no entries in the dropdown it shows a message in > the dropdown, "No matches found." With the new version there is no message. Indeed. There was a translation issue I have "fixed" now, however the behaviour is still the same. I think it is the expected one, but I have not looked at Select2 code. https://select2.org/upgrading/migrating-from-35#renamed-translation-options See the last patch. I found the list there: https://github.com/select2/select2/blob/develop/dist/js/i18n/en.js I think it's better to continue handling the translation on our side. > - Looking at the basic MARC editor, testing a required subfield (in my > test, 952c). Submitting the form causes the HTML to appear above > the Select2 control Fixed. > - The old version let the user select an empty option by clicking an "x" in > the control. The new version includes an empty option just like an HTML > select would. I think both are reasonable but I wonder if this is something > we want to intentionally change. Restored in the patch "Fix default values" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #3 from Jonathan Druart --- Created attachment 105853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105853=edit Bug 25727: Adjust translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727
--- Comment #4 from Jonathan Druart
---
Created attachment 105854
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105854=edit
Bug 25727: Fix default values
The way we defined the default values does not longer work (?)
Using
$.fn.select2.defaults.set
instead of
jQuery.extend($.fn.select2.defaults, {
fixes the problem.
It restores the allowClear setting.
There is a change in the behavior here, the selection opens when the
clear button is clicked. That is coming from a change in Select2
apparently. We may want to hack something to restore the precedent
behaviour.
This patch also removes the redefinition of the width. It seems that the
issue that this code was trying to correct is now fixed.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #5 from Jonathan Druart --- Created attachment 105855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105855=edit Bug 25727: Fix highlight of a missing field In the previous version of Select2 we had only 1 'a' tag that was visible, next to the invisible select. Now we have a 3 nested span elt, the last one (with a role=combobox attribute) is the one we want to style. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard --- I see some issues with this when I compare the behavior in master to the behavior when this patch is applied: - In master when there are no entries in the dropdown it shows a message in the dropdown, "No matches found." With the new version there is no message. - Looking at the basic MARC editor, testing a required subfield (in my test, 952c). Submitting the form causes the HTML to appear above the Select2 control - The old version let the user select an empty option by clicking an "x" in the control. The new version includes an empty option just like an HTML select would. I think both are reasonable but I wonder if this is something we want to intentionally change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Blocks||25728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25728 [Bug 25728] Add the ability to create a new authorised value within the cataloguing module -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 --- Comment #1 from Jonathan Druart --- Created attachment 105822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105822=edit Bug 25727: Upgrade the Select2 JS lib to version 4 In order to benefit from the last feature of Select we should upgrade to the version 4. For instance it adds the ability to dynamically create new entries https://select2.org/tagging Test plan: Confirm that there is no visible regression on dropdown list with select2 Like edit a bibliographic records, and the items. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25727] Update the Select2 JS lib
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25727 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
