[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

--- Comment #17 from Martin Renvoize  ---
Created attachment 110399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110399=edit
Bug 25767: (QA follow-up) receipt -> receive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #110300|0   |1
is obsolete||

--- Comment #16 from Martin Renvoize  ---
Created attachment 110398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110398=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #110299|0   |1
is obsolete||

--- Comment #15 from Martin Renvoize  ---
Created attachment 110397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110397=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

--- Comment #14 from Martin Renvoize  ---
(In reply to Katrin Fischer from comment #13)
> Blocked by dependent bug not ready yet.
> 
> Also a question: I wonder about the method name. As this is not just
> returning an object, but changing data receive would make a bit more sense
> to me than receipt (noun). What do you think?

Well.. in British English at least you can use receipt as both a noun and a
verb.. 

noun
1. a document acknowledging that a person has received money or property in
payment following a sale or other transfer of goods or provision of a service

verb
1. the action of receiving something or the fact of its being received.
2. to mark (a bill) as paid.

But I do see your point and perhaps receive is more in keeping with other terms
in Koha already, and will be more internationally understood.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

--- Comment #13 from Katrin Fischer  ---
Blocked by dependent bug not ready yet.

Also a question: I wonder about the method name. As this is not just returning
an object, but changing data receive would make a bit more sense to me than
receipt (noun). What do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110278|0   |1
is obsolete||

--- Comment #12 from Katrin Fischer  ---
Created attachment 110300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110300=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Katrin Fischer  changed:

   What|Removed |Added

 Attachment #110277|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 110299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110299=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

Signed-off-by: Kathleen Milne 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #10 from Martin Renvoize  ---
Tested in use by Kathleen as part of relying on bug 22569

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107299|0   |1
is obsolete||

--- Comment #8 from Martin Renvoize  ---
Created attachment 110277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110277=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

Signed-off-by: Kathleen Milne 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107300|0   |1
is obsolete||

--- Comment #9 from Martin Renvoize  ---
Created attachment 110278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110278=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

Signed-off-by: Kathleen Milne 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|24446   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-09-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||26481


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26481
[Bug 26481] Add Koha::Item::Transfer->receipt method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107244|0   |1
is obsolete||

--- Comment #6 from Martin Renvoize  ---
Created attachment 107299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107299=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #107245|0   |1
is obsolete||

--- Comment #7 from Martin Renvoize  ---
Created attachment 107300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107300=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|25753   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753
[Bug 25753] Deprecate C4::Circulation::transferbook
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #5 from Martin Renvoize  ---
Test plan
1/ Run the included unit tests and verify they pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105905|0   |1
is obsolete||

--- Comment #3 from Martin Renvoize  ---
Created attachment 107244
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107244=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-07-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105906|0   |1
is obsolete||

--- Comment #4 from Martin Renvoize  ---
Created attachment 107245
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107245=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||25753


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25753
[Bug 25753] Deprecate C4::Circulation::transferbook
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

--- Comment #1 from Martin Renvoize  ---
Created attachment 105905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105905=edit
Bug 25767: Add Koha::Item::Transfer->receipt method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

--- Comment #2 from Martin Renvoize  ---
Created attachment 105906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105906=edit
Bug 25767: Add unit tests for Koha::Item::Transfer->receipt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||24446


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24446
[Bug 24446] Stockrotation: Update to use daterequested in branchtransfers
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 25767] Add Koha::Item::Transfer->receipt method

2020-06-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25767

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||25757


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25757
[Bug 25757] Add a Koha::Item::Transfer->transit method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/