[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo --- Can't backport to 19.05. Test failing. Not sure if it's just a column name that changed or if it's more complex than that. kohadev-koha@c57830f10a86:/kohadevbox/koha$ prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 1/49 DBD::mysql::st execute failed: Unknown column 'item_level_hold' in 'field list' [for Statement "SELECT biblionumber, borrowernumber, itemnumber, priority, reserves.branchcode, reservedate, reservenotes, borrowers.branchcode AS borrowerbranch, itemtype, item_level_hold FROM reserves JOIN borrowers USING (borrowernumber) WHERE biblionumber = ? AND found IS NULL AND priority > 0 AND reservedate <= CURRENT_DATE() AND suspend = 0 ORDER BY priority" with ParamValues: 0=440] at /kohadevbox/koha/C4/HoldsQueue.pm line 292. Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/DBI.pm line 2088. # Looks like your test exited with 11 just after 2. t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 47/49 subtests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00 20.05.01 |20.11.00 20.05.01, 19.11.10 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #14 from Aleisha Amohia --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #13 from Kyle M Hall --- Created attachment 106166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106166=edit Bug 25783: Modify calls to AddReserve to match Koha 19.11.x AddReserve prototype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #12 from Aleisha Amohia --- tests do not pass on 19.11.x $ prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 49/52 # No tests run! # Failed test 'No tests run for subtest "Item level holds info is preserved (Bug 25738)"' # at t/db_dependent/HoldsQueue.t line 1086. DBIx::Class::Row::store_column(): No such column 'itemnumber' on Koha::Schema::Result::Branch at /home/vagrant/kohaclone/Koha/Object.pm line 77 # Looks like your test exited with 255 just after 51. t/db_dependent/HoldsQueue.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/52 subtests Test Summary Report --- t/db_dependent/HoldsQueue.t (Wstat: 65280 Tests: 51 Failed: 1) Failed test: 51 Non-zero exit status: 255 Parse errors: Bad plan. You planned 52 tests but ran 51. Files=1, Tests=51, 6 wallclock secs ( 0.01 usr 0.03 sys + 4.32 cusr 1.08 csys = 5.44 CPU) Result: FAIL please rebase! also, is the name of the subtest incorrect? should it be "Item level holds info is preserved (Bug 25783)" instead? (fixed bug number) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Jonathan Druart changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|20.11.00|20.11.00 20.05.01 released in|| --- Comment #11 from Jonathan Druart --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Andrew Fuerste-Henry changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105983|0 |1 is obsolete|| --- Comment #8 from Andrew Fuerste-Henry --- Created attachment 105992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105992=edit Bug 25783: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kim Peine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105984|0 |1 is obsolete|| --- Comment #9 from Andrew Fuerste-Henry --- Created attachment 105993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105993=edit Bug 25783: Holds Queue treating item-level holds as bib-level The holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. I do not know how to write a reproducable test plan for these issues. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kim Peine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #7 from Tomás Cohen Arazi --- I wrote regression tests on top of master and the problem is there. Added my SO as the patch clearly solves the issue. But I'm not sure why we don't reproduce it in master through the UI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Tomás Cohen Arazi changed: What|Removed |Added Version|19.11 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105982|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 105983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105983=edit Bug 25783: Regression tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 105984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105984=edit Bug 25783: Holds Queue treating item-level holds as bib-level The holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. I do not know how to write a reproducable test plan for these issues. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Kyle M Hall changed: What|Removed |Added Attachment #105974|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall --- Created attachment 105982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105982=edit Bug 25783: Holds Queue treating item-level holds as bib-level The holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. I do not know how to write a reproducable test plan for these issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25786 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Kyle M Hall changed: What|Removed |Added Attachment #105973|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall --- Created attachment 105974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105974=edit Bug 25783: Holds Queue treating item-level holds as bib-level The holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. I do not know how to write a reproducable test plan for these issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #2 from Kyle M Hall --- (In reply to Kyle M Hall from comment #1) > Created attachment 105973 [details] [review] > Bug 25783: Holds Queue treating item-level holds as bib-level > > I discovered two issues. First, the holds queue builder does not honor > the new item_level_hold flag. Instead, it only item_level_request if > in the loop dealing with item level holds. This is incorrect. Item level > holds may be trapped in the local holds priority loop as well. It's > trivial to just pass though the correct item/biblio level hold flag. > > In addition, in bug 23934 I removed the line of code that prevented > local holds priority from working for item level holds. This change > itself was good and correct. However, the code in that loop does not > check to ensure the item matches the requested item! That means it can > match an item level hold with the wrong item! > > I do not know how to write a reproducable test plan for these issues. I'm going to split the second issue out into it's own bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 --- Comment #1 from Kyle M Hall --- Created attachment 105973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105973=edit Bug 25783: Holds Queue treating item-level holds as bib-level I discovered two issues. First, the holds queue builder does not honor the new item_level_hold flag. Instead, it only item_level_request if in the loop dealing with item level holds. This is incorrect. Item level holds may be trapped in the local holds priority loop as well. It's trivial to just pass though the correct item/biblio level hold flag. In addition, in bug 23934 I removed the line of code that prevented local holds priority from working for item level holds. This change itself was good and correct. However, the code in that loop does not check to ensure the item matches the requested item! That means it can match an item level hold with the wrong item! I do not know how to write a reproducable test plan for these issues. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25783] Holds Queue treating item-level holds as bib-level
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 Andrew Fuerste-Henry changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
