[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo --- Missing dependencies for 19.05.x, can't backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Aleisha Amohia changed: What|Removed |Added Version(s)|20.11.00 20.05.01 |20.11.00, 20.05.01, released in||19.11.10 Status|Pushed to stable|Pushed to oldstable --- Comment #12 from Aleisha Amohia --- backported to 19.11.x for 19.11.10 (first patch only) - Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com --- Comment #11 from Nick Clemens --- (In reply to Aleisha Amohia from comment #10) > can backport once the tests are fixed on Bug 25783 Hi Alicia, Kyle fixed the tests on 25783 - can you test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Sarah Cornell changed: What|Removed |Added CC||sbcornell@cityofportsmouth. ||com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz --- Comment #10 from Aleisha Amohia --- can backport once the tests are fixed on Bug 25783 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Jonathan Druart changed: What|Removed |Added Version(s)|20.11.00|20.11.00 20.05.01 released in|| Status|Pushed to master|Pushed to stable --- Comment #9 from Jonathan Druart --- backported to 20.05.x for 20.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| --- Comment #8 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Tomás Cohen Arazi changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com |y.org | Depends on||25783 --- Comment #7 from Tomás Cohen Arazi --- Aleisha: The second patch should not be applied to 19.11. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25783 [Bug 25783] Holds Queue treating item-level holds as bib-level -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 --- Comment #6 from Tomás Cohen Arazi --- Created attachment 106024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106024=edit Bug 25786: AddReserve now takes a hashref Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 --- Comment #5 from Tomás Cohen Arazi --- Created attachment 106023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106023=edit Bug 25786: Holds Queue building may target the wrong item for item level requests that match holds queue priority Bug 23934 removed the limitation that prevented item level holds from getting local holds priority. The problem is the code has never checked if the item level hold matches the given item! This means the wrong item may be requested to fill an item level hold. Test Plan: 1) Create 3 items on a record 2) Place a hold for the 2nd item you created 4) Ensure that hold would be picked up by local holds priority 5) Build the holds queue 6) Note the holds queue is asking for the wrong item! 7) Apply this patch 8) Rebuild the holds queue 9) Holds queue should now be asking for the correct item! Signed-off-by: Kim Peine Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Tomás Cohen Arazi changed: What|Removed |Added Attachment #105994|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Tomás Cohen Arazi changed: What|Removed |Added Attachment #106010|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 --- Comment #4 from Jonathan Druart --- Created attachment 106010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106010=edit Bug 25786: AddReserve now takes a hashref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Jonathan Druart changed: What|Removed |Added Depends on||23934 CC||jonathan.dru...@bugs.koha-c ||ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23934 [Bug 23934] Item level holds not checked for LocalHoldsPriority in Holds Queue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #3 from Jonathan Druart
---
The tests are failing for me
# Failed test 'No tests run for subtest "Test Local Holds Priority - Get
correct item for item level hold"'
# at t/db_dependent/HoldsQueue.t line 1163.
Can't use string ("KpHbPJqfr8") as a HASH ref while "strict refs" in use at
/kohadevbox/koha/C4/Reserves.pm line 176.
# Looks like your test exited with 255 just after 50.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Andrew Fuerste-Henry changed: What|Removed |Added Severity|enhancement |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #105981|0 |1 is obsolete|| --- Comment #2 from Andrew Fuerste-Henry --- Created attachment 105994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105994=edit Bug 25786: Holds Queue building may target the wrong item for item level requests that match holds queue priority Bug 23934 removed the limitation that prevented item level holds from getting local holds priority. The problem is the code has never checked if the item level hold matches the given item! This means the wrong item may be requested to fill an item level hold. Test Plan: 1) Create 3 items on a record 2) Place a hold for the 2nd item you created 4) Ensure that hold would be picked up by local holds priority 5) Build the holds queue 6) Note the holds queue is asking for the wrong item! 7) Apply this patch 8) Rebuild the holds queue 9) Holds queue should now be asking for the correct item! Signed-off-by: Kim Peine -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 --- Comment #1 from Kyle M Hall --- Created attachment 105981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105981=edit Bug 25786: Holds Queue building may target the wrong item for item level requests that match holds queue priority Bug 23934 removed the limitation that prevented item level holds from getting local holds priority. The problem is the code has never checked if the item level hold matches the given item! This means the wrong item may be requested to fill an item level hold. Test Plan: 1) Create 3 items on a record 2) Place a hold for the 2nd item you created 4) Ensure that hold would be picked up by local holds priority 5) Build the holds queue 6) Note the holds queue is asking for the wrong item! 7) Apply this patch 8) Rebuild the holds queue 9) Holds queue should now be asking for the correct item! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=25783 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25786] Holds Queue building may target the wrong item for item level requests that match holds queue priority
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25786 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
