[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds release notes||plugin hooks to allow ||plugins to take action ||after renewal circulation ||events. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #33 from Lucas Gass --- after consideringthis bug for 20.05.x I have decided not to backport this enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #32 from Lucas Gass --- I will backport this but first I will wait until bZ26108 is pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #31 from Jonathan Druart --- Failures reported on bug 26108 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Blocks||26108 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26108 [Bug 26108] Checkins should not require item to have been checked out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Keywords||additional_work_needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #30 from Jonathan Druart --- Also 1. t/db_dependent/Reserves.t .. 2/63 Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 2. t/db_dependent/Circulation/issue.t .. 21/46 Use of uninitialized value $resfound in string eq at /kohadevbox/koha/C4/Circulation.pm line 2127. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 3. # Failed test 'No tests run for subtest "checkin_lost"' # at t/db_dependent/SIP/Transaction.t line 360. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. 4. # Failed test 'bug 22877' # at t/db_dependent/Circulation.t line 2455. # Looks like you planned 8 tests but ran 5. # Looks like you failed 1 test of 5 run. t/db_dependent/Circulation.t .. 31/49 # Failed test 'AddReturn | is_overdue' # at t/db_dependent/Circulation.t line 2669. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #29 from Jonathan Druart --- kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/SIP/Message.t t/db_dependent/SIP/Message.t .. 2/7 # Looks like you planned 29 tests but ran 5. # Failed test 'Checkin V2' # at t/db_dependent/SIP/Message.t line 74. Can't call method "id" on an undefined value at /kohadevbox/koha/C4/Circulation.pm line 2209. The issue may not exist. Please fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #28 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added Blocks||26063 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26063 [Bug 26063] Use Koha::Plugins->call for circulation hooks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #27 from Tomás Cohen Arazi --- I decided to keep the 'payload' parameter so if bug 25938 adds more information we don't change the API. I hope it fulfils your requirement, Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Tomás Cohen Arazi changed: What|Removed |Added Attachment #107251|0 |1 is obsolete|| --- Comment #26 from Tomás Cohen Arazi --- Created attachment 107257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107257=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 107251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107251=edit Bug 25855: (QA follow-up) Simplify payload This patch makes the hook be passed the Koha::Checkout object instead of a hand-crafted list of attributes. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #24 from Jonathan Druart --- At this point I'd privilege robustness and maintainability over extra calls :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #23 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #19) > A couple of questions: > > 1. Why do we have the hook before UpdateStats and logaction? > We could imagine a plugin that want to deal with them, and so get up-to-date > info > > 2. A renewal is identified by an issue_id, why don't we only pass the > issue_id to the plugin? > It could then retrieve the info it wants. > We should limit the number of params we pass, we only need to inform the > plugin "yeah, we've just renewed this!". > It will make the plugins' api more robust and maintainable IMO. Those are valid questions. About the stats calls, I only copied what we already do. The most relevant information is the issue_id and the new date due. My impression was that we could send all the info we already had. In my case I needed the itemnumber and date due so my plugin notified a third party system and no extra call to the DB is required. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #22 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #20) > Additional question: what happens (and what is the expected behaviour) if > the plugin fails? They are eval-ed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #21 from Jonathan Druart --- (In reply to Jonathan Druart from comment #20) > Additional question: what happens (and what is the expected behaviour) if > the plugin fails? Related with patch "Bug 24031: Add safety checks in Koha::Plugins::call" https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105697 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #20 from Jonathan Druart --- Additional question: what happens (and what is the expected behaviour) if the plugin fails? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #19 from Jonathan Druart --- A couple of questions: 1. Why do we have the hook before UpdateStats and logaction? We could imagine a plugin that want to deal with them, and so get up-to-date info 2. A renewal is identified by an issue_id, why don't we only pass the issue_id to the plugin? It could then retrieve the info it wants. We should limit the number of params we pass, we only need to inform the plugin "yeah, we've just renewed this!". It will make the plugins' api more robust and maintainable IMO. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Blocks||25938 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25938 [Bug 25938] Identify the renewal type in the renewal after_circ_action hook -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #18 from Martin Renvoize --- I'll file a bug... it's not a trivial addition and currently, we don thave a clear use case for it.. just a 'nice to have'. Leaving this as PQA :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 --- Comment #17 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #16) > Hmm, One final question actually.. now I've started to look into utilising > the hook for AddIssue. > > Do we need to add a 'type' parameter into the payload to distinguish between > OPAC, Staff, SIP and Autorenewals? It feels like something a plugin may > want to know about and handle distinctly? That's an excellent idea. Are you adding a follow-up here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25855] Add hook to AddRenewal using a new _after_circ_actions method in circulation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25855 Martin Renvoize changed: What|Removed |Added Summary|Add after_circ_hook in |Add hook to AddRenewal |circulation |using a new ||_after_circ_actions method ||in circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
