[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #25 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #24) > (In reply to Christopher Brannon from comment #23) > > (In reply to Andrew Fuerste-Henry from comment #22) > > > Doesn't apply cleanly to 20.05. Please rebase for backport. > > > > Is this going to be backported? > > This isn't going to be backported any further, no. It's in what are now > oldstable and oldoldstable Got it. Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #24 from Andrew Fuerste-Henry --- (In reply to Christopher Brannon from comment #23) > (In reply to Andrew Fuerste-Henry from comment #22) > > Doesn't apply cleanly to 20.05. Please rebase for backport. > > Is this going to be backported? This isn't going to be backported any further, no. It's in what are now oldstable and oldoldstable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Christopher Brannon changed: What|Removed |Added CC||cbran...@cdalibrary.org --- Comment #23 from Christopher Brannon --- (In reply to Andrew Fuerste-Henry from comment #22) > Doesn't apply cleanly to 20.05. Please rebase for backport. Is this going to be backported? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #22 from Andrew Fuerste-Henry --- Doesn't apply cleanly to 20.05. Please rebase for backport. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Fridolin Somers changed: What|Removed |Added Status|Pushed to master|Pushed to stable Version(s)|21.05.00|21.05.00,20.11.05 released in|| CC||fridolin.som...@biblibre.co ||m --- Comment #21 from Fridolin Somers --- Pushed to 20.11.x for 20.11.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #20 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #19 from Martin Renvoize --- Works well, passes QA script.. I added some unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #18 from Martin Renvoize --- Created attachment 119015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119015=edit Bug 25946: (QA follow-up) Add Unit tests Add a unit test for the empty relationship availability. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #17 from Martin Renvoize --- Created attachment 119013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119013=edit Bug 25946: borrowerRelationship can be empty Do not show the empty dropdown with no options if borrowerRelationship is disabled (empty) in the syspref. To reproduce: 1) Go to system preferences and disable borrowerRelationship. 2) Create a new patron or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select different patron to act as guarantor. 4) Observe that there's empty dropdown for the relation type. 5) Apply the patch. 6) Repeat steps above. 7) Observe that dropdown is no longer there. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #16 from Martin Renvoize --- Created attachment 119012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119012=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Martin Renvoize changed: What|Removed |Added Attachment #118997|0 |1 is obsolete|| Attachment #118998|0 |1 is obsolete|| Attachment #118999|0 |1 is obsolete|| --- Comment #15 from Martin Renvoize --- Created attachment 119011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119011=edit Bug 25946: borrowerRelationship can be empty Do not split the config using comma. From syspref description of borrowerRelationship preference: > Guarantors can be the following of those they guarantee: > (input multiple choices separated by |). Leave empty to deactivate. As it doesn't mention comma at all, I removed ',' from split. Of course if comma is actually a viable way to split separate choices, I can obsolete this patch and append to the syspref description that it also can be separated by comma. Signed-off-by: Andrew Fuerste-Henry Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #14 from Andrew Fuerste-Henry --- Created attachment 118999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118999=edit Bug 25946: borrowerRelationship can be empty Do not show the empty dropdown with no options if borrowerRelationship is disabled (empty) in the syspref. To reproduce: 1) Go to system preferences and disable borrowerRelationship. 2) Create a new patron or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select different patron to act as guarantor. 4) Observe that there's empty dropdown for the relation type. 5) Apply the patch. 6) Repeat steps above. 7) Observe that dropdown is no longer there. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #13 from Andrew Fuerste-Henry --- Created attachment 118998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118998=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #118991|0 |1 is obsolete|| Attachment #118992|0 |1 is obsolete|| Attachment #118993|0 |1 is obsolete|| --- Comment #12 from Andrew Fuerste-Henry --- Created attachment 118997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118997=edit Bug 25946: borrowerRelationship can be empty Do not split the config using comma. From syspref description of borrowerRelationship preference: > Guarantors can be the following of those they guarantee: > (input multiple choices separated by |). Leave empty to deactivate. As it doesn't mention comma at all, I removed ',' from split. Of course if comma is actually a viable way to split separate choices, I can obsolete this patch and append to the syspref description that it also can be separated by comma. Signed-off-by: Andrew Fuerste-Henry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #11 from Peter Vashchuk --- Created attachment 118993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118993=edit Bug 25946: borrowerRelationship can be empty Do not show the empty dropdown with no options if borrowerRelationship is disabled (empty) in the syspref. To reproduce: 1) Go to system preferences and disable borrowerRelationship. 2) Create a new patron or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select different patron to act as guarantor. 4) Observe that there's empty dropdown for the relation type. 5) Apply the patch. 6) Repeat steps above. 7) Observe that dropdown is no longer there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #10 from Peter Vashchuk --- Created attachment 118992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118992=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Peter Vashchuk changed: What|Removed |Added Attachment #108048|0 |1 is obsolete|| --- Comment #9 from Peter Vashchuk --- Created attachment 118991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118991=edit Bug 25946: borrowerRelationship can be empty Do not split the config using comma. From syspref description of borrowerRelationship preference: > Guarantors can be the following of those they guarantee: > (input multiple choices separated by |). Leave empty to deactivate. As it doesn't mention comma at all, I removed ',' from split. Of course if comma is actually a viable way to split separate choices, I can obsolete this patch and append to the syspref description that it also can be separated by comma. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Peter Vashchuk changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Katrin Fischer --- Hi Andrew, you write: > When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. I think that's correct. But when I leave the preference empty and try to add a guarantor the pull down still shows with only an empty entry. I feel like we should remove it in this case. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Peter Vashchuk changed: What|Removed |Added Attachment #107469|0 |1 is obsolete|| --- Comment #7 from Peter Vashchuk --- Created attachment 108048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108048=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Peter Vashchuk changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Sally changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #6 from Sally --- Sorry, couldn't get this one to work - it fails at step 7 below: To reproduce (borrowerRelationship can be empty): 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. Invalid relationship passed, '' is not defined. at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Andrew Nugged changed: What|Removed |Added CC||slavashish...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Sally changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #5 from Peter Vashchuk --- Created attachment 107469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107469=edit Bug 25946: borrowerRelationship can be empty When borrowerRelationship is empty in system preferences, Relationship dropdown is not required and we accept empty value. Also fixes bug that didn't let you to pick empty value even when you specified that it should be possible in system preferences but in the end of the string (i.e. "|father|mother" worked, but "father|mother|" don't). To reproduce (borrowerRelationship can be empty): 1) Go to system preferences and make borrowerRelationship empty. 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. Try to save your changes. 4) Observe that relationship field is required in order to save but you can't actually choose anything as it doesn't contain anything. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it allows you to save the form now. To reproduce (can't choose empty value bug): 1) Go to system preferences and set borrowerRelationship exactly to "father|mother|". 2) Create a new patron who is assumed to have a guarantor or modify the existing one. 3) Under "Guarantor Information" click on "Search to add" button. After performing the search, select a user to act as guarantor. 4) Observe that there's no option to leave relationship field empty. 5) Apply the patch. 6) Repeat steps above. 7) Observe that it has empty option that you can choose and save the form. Mentored-by: Andrew Nugged -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Peter Vashchuk changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #4 from Andrew Nugged --- He's in different timezone so I'll take initiative in communication here - yes, we'll (me too to understand and mentoring) take over this today/tomorrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart --- Peter, can you take a look at this one please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |stalkern...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #2 from Owen Leonard --- (In reply to David Roberts from comment #1) > I can't think of a reason why you would want to leave this empty It's not unreasonable to think that a library might not want to or care about storing the relationship information. But the bottom line is that the system preference can be empty so we should expect that it might be empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 25946] borrowerRelationship can no longer be empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25946 --- Comment #1 from David Roberts --- I can't think of a reason why you would want to leave this empty - if the patron has a guarantor then they automatically must have some sort of relationship with the guarantee, even if it isn't a familial one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
