[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Magnus Enger  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20307
 Depends on|20307   |

--- Comment #14 from Magnus Enger  ---
Worked nicely without 20307 for me, so I am taking the liberty of changing that
to a "see also".


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
[Bug 20307] Language overlay for authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Magnus Enger  changed:

   What|Removed |Added

 Attachment #149105|0   |1
is obsolete||

--- Comment #13 from Magnus Enger  ---
Created attachment 150745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150745=edit
Bug 26403: (follow-up) Deleted old SQL files

Signed-off-by: Magnus Enger 
Followed the test plan. Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Magnus Enger  changed:

   What|Removed |Added

 Attachment #149104|0   |1
is obsolete||

--- Comment #12 from Magnus Enger  ---
Created attachment 150744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150744=edit
Bug 26403: "Issue refund" is not fully translatable

This patch moves account debit and credit types, as well as the CASH
payment type, into YAML files under
installer/data/en/mandatory. This should make the debit and credit types
translatable (for new installations only).

To test:
1. Apply patch
2. Update po files
   ./misc/translator/translate update xx-XX
3. View the xx-XX-installer.po file
   -->The default account debit and credit types (and cash payment type)
  should be available to be translated
4. Translate the strings
5. Apply the translations
   ./misc/translator/translate install xx-XX
6. Load the new translated YAML files (with a fresh install, or by deleting
   the values in the db and using ./misc/load_yaml.pl to load the files)
7. In the staff interface, go to Administration > Credit types
   --> They should be translated
8. Go to Administration > Debit types
   --> They should be translated

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-05-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #11 from Magnus Enger  ---
Trying to apply the patches, I get this: 

$ git bz apply 26403
Bug 26403 Depends on bug 20307 (BLOCKED)

As far as I can tell "Bug 20307 - Language overlay for authorized values" is
for getting translateable authorised values in the interface, which would be
another solution to this problem? Or is there a connection between these two
bugs that I am not seeing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #10 from Caroline Cyr La Rose  ---
Created attachment 149105
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149105=edit
Bug 26403: (follow-up) Deleted old SQL files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #9 from Caroline Cyr La Rose  ---
Created attachment 149104
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149104=edit
Bug 26403: "Issue refund" is not fully translatable

This patch moves account debit and credit types, as well as the CASH
payment type, into YAML files under
installer/data/en/mandatory. This should make the debit and credit types
translatable (for new installations only).

To test:
1. Apply patch
2. Update po files
   ./misc/translator/translate update xx-XX
3. View the xx-XX-installer.po file
   -->The default account debit and credit types (and cash payment type)
  should be available to be translated
4. Translate the strings
5. Apply the translations
   ./misc/translator/translate install xx-XX
6. Load the new translated YAML files (with a fresh install, or by deleting
   the values in the db and using ./misc/load_yaml.pl to load the files)
7. In the staff interface, go to Administration > Credit types
   --> They should be translated
8. Go to Administration > Debit types
   --> They should be translated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-04-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #8 from Caroline Cyr La Rose  ---
Created attachment 148940
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148940=edit
YAML file for credit types

I tried to transfer the credit types into a yaml file to put into the /en/
directory. Didn't have time to do the rest (CASH payment type, which is also
untranslated, and account debit types, and remove the sql files).

Let me know if this is OK and I'll be able to continue another day

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2023-03-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #7 from Caroline Cyr La Rose  ---
Is this the bug for account_credit_types and account_debit_types being
installed in English only?

I have to go into every one of my installations and manually change the
database descriptions... My problem is specifically when installing in another
language, not switching between languages.

My hypothesis is that those values are in installer/data/mysql/mandatory rather
than installer/data/mysql/en/mandatory

If they were in /en/, they would show up in the translation files. Does that
make sense? Could we consider moving them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2021-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|23442   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442
[Bug 23442] Add a 'refund' process to accounts
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #6 from Martin Renvoize  ---
I've split this bug in two.. one for the description which is fixable and
leaving this one here for the transaction type which is blocked by AV
translations.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||26418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418
[Bug 26418] The "description" for REFUND accountlines is not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|26418   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418
[Bug 26418] The "description" for REFUND accountlines is not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||26418


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26418
[Bug 26418] The "description" for REFUND accountlines is not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #5 from Katrin Fischer  ---
Created attachment 109816
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109816=edit
Account summary showing English descriptions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #4 from Katrin Fischer  ---
I am not sure why this is BLOCKED? We can at least fix a part of this now and
we should - translations for authorised values doesn't apply to all points here
and it's not around the corner.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #3 from Katrin Fischer  ---
(In reply to Martin Renvoize from comment #2)
> These are not credit types, but rather the 'payment_type' authorized
> values... as such to be translatable we need translatable AV's first or
> to merge payment_types into credit_types.. but I'm still not entirely sure
> about that one.

Hm, it was labelled credit types - so maybe the label is wrong then?

But what you are saying is good for the descriptions in the "history" - we
"just" need to add them to the templates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Status|NEW |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||20307


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
[Bug 20307] Language overlay for authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|26398   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398
[Bug 26398] Credit and Debit types on creating a manual credits and manual
invoices are not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #2 from Martin Renvoize  ---
These are not credit types, but rather the 'payment_type' authorized values...
as such to be translatable we need translatable AV's first or to merge
payment_types into credit_types.. but I'm still not entirely sure about that
one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||14825


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825
[Bug 14825] Accounts Rewrite Omnibus
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe
   |ity.org |.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Martin Renvoize  changed:

   What|Removed |Added

 Depends on||26398


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26398
[Bug 26398] Credit type on creating a manual credit is not translatable
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

--- Comment #1 from Martin Renvoize  ---
(In reply to Katrin Fischer from comment #0)
> The new "issue refund" that is available for payments is not fully
> translatable. This is a big issue.
> 
> To test:
> - Make sure a language with a complete translation is installed
> - Switch to the language
> - Go to any user account
> - Add a manual invoice
> - Pay it off fully or partially
> - Click on "issue refund"
> - Verify the list of "Transaction types" is not translated
> - Check the information in the patron account. It will show:
> 
> Payment from library to patron
> A refund applied to a patrons fine
> 
> - Check in the OPAC - same issue there.
> 
> There is no option to edit the hardcoded credit and debit type descriptions?

The reason one cannot edit the descriptions for these hardcoded types is
precisely for translation reasons.  If it's a system code it should appear in
the translation template and thus the description in the DB will never get
called.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26403] "Issue refund" is not fully translatable

2020-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26403

Katrin Fischer  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/