[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #11 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Jonathan Druart changed: What|Removed |Added Version(s)||20.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 --- Comment #10 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Andrew Isherwood changed: What|Removed |Added Blocks||23971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=23971 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 --- Comment #9 from Tomás Cohen Arazi --- Created attachment 111748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111748=edit Bug 26582: (QA follow-up) Rename closed => is_closed Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Jonathan Druart changed: What|Removed |Added Status|Passed QA |ASSIGNED --- Comment #8 from Jonathan Druart --- "closed" should be "is_closed" (and we need a guideline for this). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Katrin Fischer changed: What|Removed |Added Attachment #111032|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 111528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111528=edit Bug 26582: Unit tests Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Katrin Fischer changed: What|Removed |Added Attachment #111033|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 111529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111529=edit Bug 26582: Add Koha::Acquisition::Basket->close This patch adds two methods to Koha::Acquisition::Basket: - 'closed': that tells if the basket is closed - 'close': that closes the basket It inherits the behaviour from CloseBasket (as it actually makes sense). It improves CloseBasket by wrapping the action inside a transaction. It uses the $orders->update call with no_trigger as there's no trigger to trigger and the update can be done on a single DB call. A new exceptions file is added for basket-related exceptions. The only specific exception that gets added is Koha::Exceptions::Acquisition::Basket::AlreadyClosed To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What|Removed |Added Attachment #111003|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 111032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111032=edit Bug 26582: Unit tests Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize --- Works as expected, tests pass.. QA Script throws a false failure (POD). Signing off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Martin Renvoize changed: What|Removed |Added Attachment #111004|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 111033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111033=edit Bug 26582: Add Koha::Acquisition::Basket->close This patch adds two methods to Koha::Acquisition::Basket: - 'closed': that tells if the basket is closed - 'close': that closes the basket It inherits the behaviour from CloseBasket (as it actually makes sense). It improves CloseBasket by wrapping the action inside a transaction. It uses the $orders->update call with no_trigger as there's no trigger to trigger and the update can be done on a single DB call. A new exceptions file is added for basket-related exceptions. The only specific exception that gets added is Koha::Exceptions::Acquisition::Basket::AlreadyClosed To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Blocks||26584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26584 [Bug 26584] Remove unused C4::Acquisition::CloseBasket function -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added CC||and...@bywatersolutions.com ||, katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Depends on||26515 CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26515 [Bug 26515] Add Koha::Acquisition::Order->cancel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 111003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111003=edit Bug 26582: Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 111004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111004=edit Bug 26582: Add Koha::Acquisition::Basket->close This patch adds two methods to Koha::Acquisition::Basket: - 'closed': that tells if the basket is closed - 'close': that closes the basket It inherits the behaviour from CloseBasket (as it actually makes sense). It improves CloseBasket by wrapping the action inside a transaction. It uses the $orders->update call with no_trigger as there's no trigger to trigger and the update can be done on a single DB call. A new exceptions file is added for basket-related exceptions. The only specific exception that gets added is Koha::Exceptions::Acquisition::Basket::AlreadyClosed To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Basket.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26582] Add Koha::Acquisition::Basket->close
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26582 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
