[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Martin Renvoize changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Martin Renvoize changed: What|Removed |Added Component|Architecture, internals,|System Administration |and plumbing| CC||gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #72 from Fridolin Somers --- Enhancement not pushed to 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #71 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Martin Renvoize changed: What|Removed |Added Text to go in the||This enhancement adds an release notes||"advanced" editor for ||transfer limits that ||displays all to/from ||library combinations in a ||grid and allows them to be ||edited in a manner somewhat ||similar to the transport ||cost matrix editor. CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Martin Renvoize changed: What|Removed |Added Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #116613|0 |1 is obsolete|| --- Comment #70 from Katrin Fischer --- Created attachment 116964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116964=edit Bug 26633: Add advanced editor link on admin home page Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #116612|0 |1 is obsolete|| --- Comment #69 from Katrin Fischer --- Created attachment 116963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116963=edit Bug 26633: (QA follow-up) Add error handling for loading transfer limits table Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113275|0 |1 is obsolete|| --- Comment #68 from Katrin Fischer --- Created attachment 116962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116962=edit Bug 26633: Add ability to bookmark the page you are viewing Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113274|0 |1 is obsolete|| --- Comment #67 from Katrin Fischer --- Created attachment 116961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116961=edit Bug 26633: Add API documentation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113273|0 |1 is obsolete|| --- Comment #66 from Katrin Fischer --- Created attachment 116960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116960=edit Bug 26633: Convert transfer_limit.json to YAML Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113272|0 |1 is obsolete|| --- Comment #65 from Katrin Fischer --- Created attachment 116959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116959=edit Bug 26633: Remove jquery.checkboxes.min.js include No longer exists and not used in this template Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113271|0 |1 is obsolete|| --- Comment #64 from Katrin Fischer --- Created attachment 116958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116958=edit Bug 26633: POD for the exceptions file Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113270|0 |1 is obsolete|| --- Comment #63 from Katrin Fischer --- Created attachment 116957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116957=edit Bug 26633: (QA follow-up) Tests on error condition This patch highlights a problem with the try/catch conditions in the ad() controlled method. Tests are added, and the controller is fixed to reflect the right behaviour. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/transfer_limits.t => SUCCESS: Tests pass! 409 is returned as appropriate! Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113269|0 |1 is obsolete|| --- Comment #62 from Katrin Fischer --- Created attachment 116956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116956=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113268|0 |1 is obsolete|| --- Comment #61 from Katrin Fischer --- Created attachment 116955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116955=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113267|0 |1 is obsolete|| --- Comment #60 from Katrin Fischer --- Created attachment 116954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116954=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113266|0 |1 is obsolete|| --- Comment #59 from Katrin Fischer --- Created attachment 116953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116953=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #113265|0 |1 is obsolete|| --- Comment #58 from Katrin Fischer --- Created attachment 116952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116952=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #57 from Jonathan Druart --- The changes from this merge request must be applied to the qa-test-tools repo: https://gitlab.com/koha-community/qa-test-tools/-/merge_requests/35 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #56 from Katrin Fischer --- Reran the QA tools with the dependency applied, but still get: FAIL api/v1/swagger/paths/transfer_limits.yaml OK git manipulation FAIL yaml_valid YAML Error: Invalid element in map Do I need to install something new or do we need an update to the QA test tools? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What|Removed |Added Depends on||27673 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27673 [Bug 27673] Replace YAML with YAML::XS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #55 from Jonathan Druart --- (In reply to Kyle M Hall from comment #54) > I'm not sure where we handle change requests to the qa test tools, so I've > created a pull request on GitHub: > https://github.com/Koha-Community/qa-test-tools/pull/2 It's https://gitlab.com/koha-community/qa-test-tools IMO we should first switch to YAML::XS in Koha code before adding it to the QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #54 from Kyle M Hall --- I'm not sure where we handle change requests to the qa test tools, so I've created a pull request on GitHub: https://github.com/Koha-Community/qa-test-tools/pull/2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633
--- Comment #53 from Kyle M Hall ---
(In reply to Kyle M Hall from comment #52)
> (In reply to Jonathan Druart from comment #51)
> > How did you check, Kyle?
> >
> > The script is only returning the error from YAML::LoadFile
> >
> > YAML Error: Can't parse double quoted string
> >Code: YAML_PARSE_ERR_BAD_DOUBLE
> >Line: 149
> >Document: 1
> > at /usr/share/perl5/YAML/Loader.pm line 574.
>
> I used yamllint. Looks like I'll have to do some more digging!
So the problem is the YAML module is insufficient for running this test. I
would recommend we switch to YAML::XS. The current YAML module is being
deprecated anyway and is being move to YAML::Old.
root@kohadevbox:koha(bug26633-qa)$ perl -e "use YAML qw(LoadFile);
LoadFile('api/v1/swagger/paths/transfer_limits.yaml');"
YAML Error: Invalid element in map
Code: YAML_LOAD_ERR_BAD_MAP_ELEMENT
Line: 8
Document: 1
at /usr/share/perl5/YAML/Loader.pm line 350.
root@kohadevbox:koha(bug26633-qa)$ perl -e "use YAML::XS qw(LoadFile);
LoadFile('api/v1/swagger/paths/transfer_limits.yaml');"
root@kohadevbox:koha(bug26633-qa)$
Basically, YAML only supports YAML 1.0, where YAML::XS ( and
Mojolicious::Plugin::OpenAPI ) support YAML 1.1.
I would recommend as a first step that QohA::File::YAML be updated to use
YAML::XS as a first step.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #52 from Kyle M Hall --- (In reply to Jonathan Druart from comment #51) > How did you check, Kyle? > > The script is only returning the error from YAML::LoadFile > > YAML Error: Can't parse double quoted string >Code: YAML_PARSE_ERR_BAD_DOUBLE >Line: 149 >Document: 1 > at /usr/share/perl5/YAML/Loader.pm line 574. I used yamllint. Looks like I'll have to do some more digging! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #51 from Jonathan Druart --- How did you check, Kyle? The script is only returning the error from YAML::LoadFile YAML Error: Can't parse double quoted string Code: YAML_PARSE_ERR_BAD_DOUBLE Line: 149 Document: 1 at /usr/share/perl5/YAML/Loader.pm line 574. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #50 from Kyle M Hall --- (In reply to Katrin Fischer from comment #46) > Hi Kyle, > > I have a QA script fail here: > > FAIL api/v1/swagger/paths/transfer_limits.json >FAIL git manipulation > The file has been added and deleted in the same patchset > > FAIL api/v1/swagger/paths/transfer_limits.yaml >OK git manipulation >FAIL yaml_valid > YAML Error: Invalid element in map > > > Can you please check? > > Can you please also fix the last 2 commit messages subjects while you are on > it? Bug : I would have done it, but need your help with the other fail > here :) > > * Commit title does not start with 'Bug X: ' - a6713283b5 > * Commit title does not start with 'Bug X: ' - 20f1ef7e08 I've checked and the YAML is valid, so I think those are false flags from the QA script! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #49 from Kyle M Hall --- Created attachment 116613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116613=edit Bug 26633: Add advanced editor link on admin home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Attachment #113677|0 |1 is obsolete|| Attachment #113961|0 |1 is obsolete|| --- Comment #48 from Kyle M Hall --- Created attachment 116612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116612=edit Bug 26633: (QA follow-up) Add error handling for loading transfer limits table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #47 from Katrin Fischer --- The first fail can be ignored (obv.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #46 from Katrin Fischer --- Hi Kyle, I have a QA script fail here: FAIL api/v1/swagger/paths/transfer_limits.json FAIL git manipulation The file has been added and deleted in the same patchset FAIL api/v1/swagger/paths/transfer_limits.yaml OK git manipulation FAIL yaml_valid YAML Error: Invalid element in map Can you please check? Can you please also fix the last 2 commit messages subjects while you are on it? Bug : I would have done it, but need your help with the other fail here :) * Commit title does not start with 'Bug X: ' - a6713283b5 * Commit title does not start with 'Bug X: ' - 20f1ef7e08 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Nick Clemens changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18861 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #45 from Kyle M Hall --- Created attachment 113961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113961=edit Bug 26633 - Add advanced editor link on admin home page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Attachment #113676|0 |1 is obsolete|| --- Comment #44 from Kyle M Hall --- Created attachment 113677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113677=edit Bug 26633 (QA follow-up) Add error handling for loading transfer limits table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #43 from Kyle M Hall --- Created attachment 113676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113676=edit Bug 26633 (QA follow-up) Add error handling for loading transfer limits table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #42 from Kyle M Hall --- (In reply to Jonathan Druart from comment #30) > (In reply to Kyle M Hall from comment #29) > > (In reply to Jonathan Druart from comment #28) > > > 2. There is no error handling when the page is loaded. I first tried with > > > D11 (which has the REST API broken) and the "loading..." was running > > > forever, the table was loaded but without any checkboxes. > > > Maybe we should not display anything in that case. > > > > I'm not sure why we'd do this here, when we don't do it for any other ajax > > table in Koha. > > I think the other tables (with the checkout list in mind) will raise a > DataTable alert box if the svc script/REST API route does not return > something valid (or 500). > So we have a the interface telling us something went wrong. Ah, I see. I'll see what I can do about that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Andrew Fuerste-Henry changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27018 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #41 from Kyle M Hall --- Created attachment 113275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113275=edit Bug 26633: Add ability to bookmark the page you are viewing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #40 from Kyle M Hall --- Created attachment 113274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113274=edit Bug 26633: Add API documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #37 from Kyle M Hall --- Created attachment 113271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113271=edit Bug 26633: POD for the exceptions file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #39 from Kyle M Hall --- Created attachment 113273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113273=edit Bug 26633: Convert transfer_limit.json to YAML -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #38 from Kyle M Hall --- Created attachment 113272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113272=edit Bug 26633: Remove jquery.checkboxes.min.js include No longer exists and not used in this template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #34 from Kyle M Hall --- Created attachment 113268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113268=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #36 from Kyle M Hall --- Created attachment 113270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113270=edit Bug 26633: (QA follow-up) Tests on error condition This patch highlights a problem with the try/catch conditions in the ad() controlled method. Tests are added, and the controller is fixed to reflect the right behaviour. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/transfer_limits.t => SUCCESS: Tests pass! 409 is returned as appropriate! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Attachment #112923|0 |1 is obsolete|| Attachment #112924|0 |1 is obsolete|| Attachment #112925|0 |1 is obsolete|| Attachment #112926|0 |1 is obsolete|| Attachment #112927|0 |1 is obsolete|| Attachment #112928|0 |1 is obsolete|| Attachment #112929|0 |1 is obsolete|| Attachment #113053|0 |1 is obsolete|| --- Comment #31 from Kyle M Hall --- Created attachment 113265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113265=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #35 from Kyle M Hall --- Created attachment 113269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113269=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #32 from Kyle M Hall --- Created attachment 113266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113266=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #33 from Kyle M Hall --- Created attachment 113267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113267=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #30 from Jonathan Druart --- (In reply to Kyle M Hall from comment #29) > (In reply to Jonathan Druart from comment #28) > > 2. There is no error handling when the page is loaded. I first tried with > > D11 (which has the REST API broken) and the "loading..." was running > > forever, the table was loaded but without any checkboxes. > > Maybe we should not display anything in that case. > > I'm not sure why we'd do this here, when we don't do it for any other ajax > table in Koha. I think the other tables (with the checkout list in mind) will raise a DataTable alert box if the svc script/REST API route does not return something valid (or 500). So we have a the interface telling us something went wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #29 from Kyle M Hall --- (In reply to Jonathan Druart from comment #28) > 1. Please provide documentation for the API I'll see what I can do! > 2. There is no error handling when the page is loaded. I first tried with > D11 (which has the REST API broken) and the "loading..." was running > forever, the table was loaded but without any checkboxes. > Maybe we should not display anything in that case. I'm not sure why we'd do this here, when we don't do it for any other ajax table in Koha. > 4. There is no way to bookmark or share the URL to display a given table. > That would have been useful. Is that something we could implement easily? I'll see what I can do! > 5. > (In reply to Kyle M Hall from comment #0) > > The current transfer limits editor works great for Koha instances with small > > numbers of branches. However, for consortiums with dozens or even hundreds > > of libraries, the editor does not work well or effectively. > > I've added around 30 libraries and it creates a huge table. I am not sure we > are answering the need as the table is not readable easily if you are > starting to scroll. Maybe it would have been useful to have "floating th"'s, > which are always displayed when you scroll. > Not blocker however, but feel free to submit if you think it would be useful. I really like that idea! I'll give it a shot but I might need some help from Lucas or Owen ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #28 from Jonathan Druart --- 1. Please provide documentation for the API 2. There is no error handling when the page is loaded. I first tried with D11 (which has the REST API broken) and the "loading..." was running forever, the table was loaded but without any checkboxes. Maybe we should not display anything in that case. 3. I am a bit concern that there is no "save" or "undo" button. If you click "Check all" or "Uncheck all", you may have lost your work! It's not blocker but worth noting it here. 4. There is no way to bookmark or share the URL to display a given table. That would have been useful. Is that something we could implement easily? 5. (In reply to Kyle M Hall from comment #0) > The current transfer limits editor works great for Koha instances with small > numbers of branches. However, for consortiums with dozens or even hundreds > of libraries, the editor does not work well or effectively. I've added around 30 libraries and it creates a huge table. I am not sure we are answering the need as the table is not readable easily if you are starting to scroll. Maybe it would have been useful to have "floating th"'s, which are always displayed when you scroll. Not blocker however, but feel free to submit if you think it would be useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #27 from Jonathan Druart --- Created attachment 113053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113053=edit Bug 26633: Remove jquery.checkboxes.min.js include No longer exists and not used in this template -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Tomas, can I get your stamp on this one please? Yes, we need them, Kyle? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 112929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112929=edit Bug 26633: POD for the exceptions file Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 112927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112927=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 112925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112925=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 112928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112928=edit Bug 26633: (QA follow-up) Tests on error condition This patch highlights a problem with the try/catch conditions in the ad() controlled method. Tests are added, and the controller is fixed to reflect the right behaviour. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/transfer_limits.t => SUCCESS: Tests pass! 409 is returned as appropriate! Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 112926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112926=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112782|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 112923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112923=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 112924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112924=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112778|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112779|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112780|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Attachment #112781|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #17) > Tomas, can I get your stamp on this one please? I've been tracking this dev closely with Kyle and he responded to my suggestions, on the API part of it. I will review it altogether now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||tomasco...@gmail.com --- Comment #17 from Jonathan Druart --- Tomas, can I get your stamp on this one please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112587|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 112782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112782=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #16 from Katrin Fischer --- Do we need any documentation for the API routes here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112438|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 112781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112781=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112437|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 112780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112780=edit Bug 26633: Fix indirect object notation Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112330|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 112779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112779=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Attachment #112328|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 112778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112778=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #10 from Kyle M Hall --- Created attachment 112587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112587=edit Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #7 from Katrin Fischer --- Created attachment 112437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112437=edit Bug 26633: Fix indirect object notation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #8 from Katrin Fischer --- Created attachment 112438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112438=edit Bug 26633: (QA follow-up) Change label to "collection" as we display the description -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #9 from Katrin Fischer ---
Hi Kyle,
I have posted 2 small follow-ups, but then got stuck on an issue:
Whenever you click any of the buttons ("Uncheck all" , "Check all") a second
time, all the buttons get greyed out and no other action can be performed until
the page is reloaded.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #6 from Lisette Scheer --- Worked great, our consortium will be happy to have this, especially if we have to close again like we did last spring. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Lisette Scheer changed: What|Removed |Added Attachment #111381|0 |1 is obsolete|| --- Comment #5 from Lisette Scheer --- Created attachment 112330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112330=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Lisette Scheer changed: What|Removed |Added Attachment #111380|0 |1 is obsolete|| --- Comment #3 from Lisette Scheer --- Created attachment 112327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112327=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Lisette Scheer changed: What|Removed |Added Attachment #112327|0 |1 is obsolete|| --- Comment #4 from Lisette Scheer --- Created attachment 112328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112328=edit Bug 26633: Add REST API for managing transfer limits Test Plan: 1) prove t/db_dependent/api/v1/transfer_limits.t Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Lisette Scheer changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 --- Comment #2 from Kyle M Hall --- Created attachment 111381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111381=edit Bug 26633: Add advanced editor for transfer limits The current transfer limits editor works great for Koha instances with small numbers of branches. However, for consortiums with dozens or even hundreds of libraries, the editor does not work well or effectively. We should provide an "advanced" editor displays all to/from library combinations in a grid and allows them to be edited in a manner somewhat similar to the transport cost matrix editor. Test Plan: 1) Apply this patch 2) Browse to the transfer limits editor 3) Click the new "Switch to advanced editor" link 4) Select a collection code/item type to edit limits for 5) Test the "Check all" function 6) Test the "Uncheck all" function 7) Test the "Check" column function 8) Test the "Uncheck" column function 9) Test the "Check" row function 10) Test the "Uncheck" row function 11) Test individual checkboxes/table cells -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26633] Add advanced editor for transfer limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26633 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
