[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What|Removed |Added Attachment #112091|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What|Removed |Added Attachment #112083|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What|Removed |Added Attachment #112012|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 David Cook changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #8 from David Cook --- Note that there are a lot of recommended packages that aren't installed when using "--no-install-recommends": Recommended packages: ssl-cert default-mta | mail-transport-agent exim4 | postfix | mail-transport-agent docbook-xml iamerican | ispell-dictionary wamerican | wordlist rabbitmq-server liburi-escape-xs-perl libasync-interrupt-perl libev-perl | libevent-perl libguard-perl libcgi-fast-perl libfreezethaw-perl libclass-xsaccessor-perl libclass-c3-xs-perl libconfig-tiny-perl libdevel-argnames-perl libdate-calc-xs-perl libsql-translator-perl libmoosex-nonmoose-perl gcc libmime-tools-perl libsys-hostname-long-perl libauthen-sasl-perl libdevel-lexalias-perl libglib2.0-data xdg-user-dirs libpod-coverage-perl libtest-pod-perl ghostscript gsfonts libintl-xs-perl javascript-common libjson-xs-perl libnet-idn-encode-perl krb5-locales liblog-dispatch-perl libipc-shareable-perl libmath-random-isaac-xs-perl libev-perl libio-socket-ip-perl libio-socket-socks-perl libmojo-server-fastcgi-perl libdevel-partialdump-perl libgpm2 libgssapi-perl libio-pty-perl libtext-wrapper-perl libfcgi-perl libfcgi-procmanager-perl libmodule-refresh-perl libhijk-perl libhtml-lint-perl libtype-tiny-xs-perl tcpd libwww-form-urlencoded-xs-perl libxml-sax-expat-perl libtie-ixhash-perl libxml-xpathengine-perl | libxml-xpath-perl libterm-readkey-perl bzip2 file xz-utils xauth rename psmisc libserver-starter-perl I think that this probably will have unintended consequences, so I'm thinking it's best to fail this one for now. I think the original idea of using Suggests rather than Recommends might be the safest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #7 from David Cook --- (In reply to Mason James from comment #2) > Created attachment 112083 [details] [review] > Bug 26741: Make rabbitmq-server a 'recommended' package > > to test... > > 1/ apply patch, build new package > > 2/ install package with 'apt install koha-common', observe rabbitmq-server > package is installed > > 3/ install package with 'apt install --no-install-recommends koha-common', > observe rabbitmq-server package is *not* installed My test plan 1. Apply the patch to a Koha git repo 2. Download https://gitlab.com/minusdavid/koha-deb-builder-docker and follow the instructions in the README 3. Run winpty docker run --rm -it debian:stretch 4. Copy the built koha-common*.deb package into the new empty Docker container 5. apt-get update 6. apt-get install wget gnupg 7. wget -q -O- https://debian.koha-community.org/koha/gpg.asc | apt-key add - 8. echo 'deb http://debian.koha-community.org/koha stable main' | tee /etc/apt/sources.list.d/koha.list 9. apt-get update 10. apt install ./ 11. Review "The following NEW packages will be installed" and note rabbitmq-server is included 12. apt install --no-install-recommends ./ 13. Review "The following NEW packages will be installed" and note rabbitmq-server is included -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #6 from David Cook --- Created attachment 112091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112091=edit Bug 26741: Change information field from Recommended to Recommends -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741
--- Comment #5 from David Cook ---
Comment on attachment 112083
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112083
Bug 26741: Make rabbitmq-server a 'recommended' package
Review of attachment 112083:
-->
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=26741=112083)
-
::: debian/koha-common.postinst
@@ +261,5 @@
> +# config rmq, if rmq is installed
> +if dpkg-query -W -f='${db:Status-Abbrev}' rabbitmq-server | grep -q ^.i ;
> then
> +rabbitmq-plugins enable rabbitmq_stomp
> +service rabbitmq-server restart
> +fi
I haven't tested this yet, but why not just do "dpkg -l rabbitmq-server"? The
if/then construct will do the right thing with the exit code.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #4 from David Cook --- dpkg-source: warning: unknown information field 'Recommended' in input data in package's section of control info file dpkg-source: warning: unknown information field 'Recommended' in input data in package's section of control info file That should be Recommends rather than Recommended -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #3 from David Cook --- I'm trying to build on Jessie but getting the following: E: Unable to locate package libemail-stuffer-perl E: Unable to locate package libplack-middleware-logwarn-perl But Jessie is EOL iirc so I guess it's time to update the build box... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What|Removed |Added Attachment #112012|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 --- Comment #2 from Mason James --- Created attachment 112083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112083=edit Bug 26741: Make rabbitmq-server a 'recommended' package to test... 1/ apply patch, build new package 2/ install package with 'apt install koha-common', observe rabbitmq-server package is installed 3/ install package with 'apt install --no-install-recommends koha-common', observe rabbitmq-server package is *not* installed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26741] Make rabbitmq-server a 'recommended' package
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26741 Mason James changed: What|Removed |Added Summary|Make rabbitmq-server|Make rabbitmq-server a |suggested rather than |'recommended' package |required| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
