[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|The new |The new
  release notes|PurgeListShareInvitesOlderT |`PurgeListShareInvitesOlder
   |han system preference   |Than` system preference
   |enables librarians to   |enables librarians to
   |control when unaccepted |control when unaccepted
   |private list share invites  |private list share invites
   |are removed from the|are removed from the
   |database.
  |database.
   |
   |
   |Unaccepted  |Unaccepted
   |private list share invites  |private list share invites
   |will now be removed based   |will now be removed based
   |on the following|on the following
   |prioritised options:
   |prioritised options:
   |
   |
   |-   |-
   |Priority 1. Use DAYS value  |Priority 1. Use DAYS value
   |when the|when the
   |cleanup_database.pl cronjob |cleanup_database.pl cronjob
   |is run with a   |is run with a
   |--list-invites DAYS |--list-invites DAYS
   |parameter specified.
   |parameter specified.
   |
   |
   |-   |-
   |Priority 2. Use the |Priority 2. Use the
   |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT
   |han system preference   |han system preference
   |value.
 |value.
   |
   |
   |- Priority 3. Use a |- Priority 3. Use a
   |default of 14 days, if the  |default of 14 days, if the
   |cleanup_database.pl cronjob |cleanup_database.pl cronjob
   |is run with a   |is run with a
   |--list-invites parameter|--list-invites parameter
   |missing the DAYS value, AND |missing the DAYS value, AND
   |the |the
   |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT
   |han system preference is|han system preference is
   |empty.
 |empty.
   |
   |
   |- Priority 4. Don't |- Priority 4. Don't
   |remove any unaccepted   |remove any unaccepted
   |private list share invites  |private list share invites
   |if the cleanup_database.pl  |if the cleanup_database.pl
   |cronjob is run without the  |cronjob is run without the
   |--list-invites parameter|--list-invites parameter
   |and the |and the
   |PurgeListShareInvitesOlderT |PurgeListShareInvitesOlderT
   |han syspref is empty.   |han syspref is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-05-21 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com, ro...@catalyst.net.nz
  Component|Database|Command-line Utilities

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-02-08 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to stable|Needs documenting
 CC||lu...@bywatersolutions.com

--- Comment #32 from Lucas Gass  ---
Enhancement, no backport for 23.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Fridolin Somers  changed:

   What|Removed |Added

 Version(s)|24.05.00|24.05.00,23.11.03
released in||
 CC||fridolin.som...@biblibre.co
   ||m
 Status|Pushed to master|Pushed to stable

--- Comment #31 from Fridolin Somers  ---
23.11.03 is still young, I choose to backport the enhancement :)

Pushed to 23.11.x for 23.11.03

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||35893


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35893
[Bug 35893] Missing closing  in opac.pref
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #30 from Katrin Fischer  ---
Pushed for 24.05!

Well done everyone, thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Katrin Fischer  changed:

   What|Removed |Added

 Version(s)||24.05.00
released in||
 Status|Passed QA   |Pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2024-01-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #29 from Katrin Fischer  ---
I really like seeing us move settings like this into the system preference/GUI.
It makes it much easier to manage different settings for servers with multiple
instances. Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #28 from Kyle M Hall  ---
Created attachment 159102
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159102=edit
Bug 26831: (follow-up) Tidy cleanup_database.pl

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #27 from Kyle M Hall  ---
Created attachment 159101
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159101=edit
Bug 26831: (follow-up) Tidy code for qa script

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #26 from Kyle M Hall  ---
Created attachment 159100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159100=edit
Bug 26831: (follow-up) Update system preference description

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #25 from Kyle M Hall  ---
Created attachment 159099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159099=edit
Bug 26831: Attempting to clarify prioritising of options

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #24 from Kyle M Hall  ---
Created attachment 159098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159098=edit
Bug 26831: Use new PurgeListShareInvitesOlderThan syspref

Enable librarians in the staff client to control when unaccepted list
invites will be removed from the database.

Test plan:
1. Apply patches

2. Update database
sudo koha-shell 
cd installer/data/mysql
./updatedatabase.pl

3. Confirm the PurgeListShareInvitesOlderThan syspref = 14

4. Run cleanup_database.pl with --list-invites parameter defined:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites 10 -v

5. Confirm the output contains:
"Purging unaccepted list share invites older than 10 days."

6. Set PurgeListShareInvitesOlderThan syspref = 15

7. Run cleanup_database.pl without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl -v

8. Confirm the output contains:
"Purging unaccepted list share invites older than 15 days."

9. Empty PurgeListShareInvitesOlderThan syspref

10. Run cleanup_database without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites -v

13. Confirm the output contains:
"Purging unaccepted list share invites older than 14 days."

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #157711|0   |1
is obsolete||
 Attachment #157712|0   |1
is obsolete||
 Attachment #157713|0   |1
is obsolete||
 Attachment #157714|0   |1
is obsolete||

--- Comment #23 from Kyle M Hall  ---
Created attachment 159097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159097=edit
Bug 26831: Add new system preference PurgeListShareInvitesOlderThan

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-11-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #22 from Alex Buckley  ---
(In reply to David Nind from comment #21)
> (In reply to Alex Buckley from comment #16)
> > Hi David, 
> > 
> > Sorry for my delay, I've just back from a long holiday. I hope you are doing
> > well :)
> > 
> > I've rebased these patches against master. Ready to test again now.
> > 
> > Alex
> 
> Hi Alex.
> 
> Welcome back! I hope you had a great holiday! (I'm doing well, thanks!)
> 
> I've now signed off.
> 
> I've also updated the system preference description, mainly for consistency
> with other system preferences (such as NOTE in capitals, script name in a
> code block) as well as some other wording changes. Feel free to remove if
> you prefer the original description.
> 
> David

Hi David

Thanks so much, yes I did have a very nice holiday around Italy with my parents
it was lovely. That's great to hear you're doing well :)

Thank you for testing and signing off, also appreciate your update to the
system preference description that is much better now!

Kind regards,
Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #21 from David Nind  ---
(In reply to Alex Buckley from comment #16)
> Hi David, 
> 
> Sorry for my delay, I've just back from a long holiday. I hope you are doing
> well :)
> 
> I've rebased these patches against master. Ready to test again now.
> 
> Alex

Hi Alex.

Welcome back! I hope you had a great holiday! (I'm doing well, thanks!)

I've now signed off.

I've also updated the system preference description, mainly for consistency
with other system preferences (such as NOTE in capitals, script name in a code
block) as well as some other wording changes. Feel free to remove if you prefer
the original description.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #20 from David Nind  ---
Created attachment 157714
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157714=edit
Bug 26831: (follow-up) Update system preference description

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

David Nind  changed:

   What|Removed |Added

 Attachment #157686|0   |1
is obsolete||

--- Comment #19 from David Nind  ---
Created attachment 157713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157713=edit
Bug 26831: Attempting to clarify prioritising of options

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

David Nind  changed:

   What|Removed |Added

 Attachment #157685|0   |1
is obsolete||

--- Comment #18 from David Nind  ---
Created attachment 157712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157712=edit
Bug 26831: Use new PurgeListShareInvitesOlderThan syspref

Enable librarians in the staff client to control when unaccepted list
invites will be removed from the database.

Test plan:
1. Apply patches

2. Update database
sudo koha-shell 
cd installer/data/mysql
./updatedatabase.pl

3. Confirm the PurgeListShareInvitesOlderThan syspref = 14

4. Run cleanup_database.pl with --list-invites parameter defined:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites 10 -v

5. Confirm the output contains:
"Purging unaccepted list share invites older than 10 days."

6. Set PurgeListShareInvitesOlderThan syspref = 15

7. Run cleanup_database.pl without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl -v

8. Confirm the output contains:
"Purging unaccepted list share invites older than 15 days."

9. Empty PurgeListShareInvitesOlderThan syspref

10. Run cleanup_database without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites -v

13. Confirm the output contains:
"Purging unaccepted list share invites older than 14 days."

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

David Nind  changed:

   What|Removed |Added

 Attachment #157684|0   |1
is obsolete||

--- Comment #17 from David Nind  ---
Created attachment 157711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157711=edit
Bug 26831: Add new system preference PurgeListShareInvitesOlderThan

Sponsored-by: Catalyst IT, New Zealand
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #16 from Alex Buckley  ---
(In reply to David Nind from comment #12)
> The patches no longer apply 8-(..
> 
> git bz apply 26831
> 
> Bug 26831 - Enable librarians to control when unaccepted private list share
> invites are removed by the cleanup_database.pl cronjob
> 
> 140747 - Bug 26831: Add new system preference PurgeListShareInvitesOlderThan
> 140751 - Bug 26831: Use new PurgeListShareInvitesOlderThan syspref
> 140752 - Bug 26831: Attempting to clarify prioritising of options
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 26831: Add new system preference PurgeListShareInvitesOlderThan
> Using index info to reconstruct a base tree...
> M installer/data/mysql/mandatory/sysprefs.sql
> M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> Falling back to patching base and 3-way merge...
> Auto-merging
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> CONFLICT (content): Merge conflict in
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
> Auto-merging installer/data/mysql/mandatory/sysprefs.sql
> error: Failed to merge in the changes.
> Patch failed at 0001 Bug 26831: Add new system preference
> PurgeListShareInvitesOlderThan

Hi David, 

Sorry for my delay, I've just back from a long holiday. I hope you are doing
well :)

I've rebased these patches against master. Ready to test again now.

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #15 from Alex Buckley  ---
Created attachment 157686
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157686=edit
Bug 26831: Attempting to clarify prioritising of options

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #14 from Alex Buckley  ---
Created attachment 157685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157685=edit
Bug 26831: Use new PurgeListShareInvitesOlderThan syspref

Enable librarians in the staff client to control when unaccepted list
invites will be removed from the database.

Test plan:
1. Apply patches

2. Update database
sudo koha-shell 
cd installer/data/mysql
./updatedatabase.pl

3. Confirm the PurgeListShareInvitesOlderThan syspref = 14

4. Run cleanup_database.pl with --list-invites parameter defined:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites 10 -v

5. Confirm the output contains:
"Purging unaccepted list share invites older than 10 days."

6. Set PurgeListShareInvitesOlderThan syspref = 15

7. Run cleanup_database.pl without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl -v

8. Confirm the output contains:
"Purging unaccepted list share invites older than 15 days."

9. Empty PurgeListShareInvitesOlderThan syspref

10. Run cleanup_database without the --list-invites parameter:
sudo koha-shell 
cd misc/cronjobs
./cleanup_database.pl --list-invites -v

13. Confirm the output contains:
"Purging unaccepted list share invites older than 14 days."

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

--- Comment #13 from Alex Buckley  ---
Created attachment 157684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157684=edit
Bug 26831: Add new system preference PurgeListShareInvitesOlderThan

Sponsored-by: Catalyst IT, New Zealand

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley  changed:

   What|Removed |Added

 Attachment #140752|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley  changed:

   What|Removed |Added

 Attachment #140751|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley  changed:

   What|Removed |Added

 Attachment #140747|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2023-09-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||da...@davidnind.com

--- Comment #12 from David Nind  ---
The patches no longer apply 8-(..

git bz apply 26831

Bug 26831 - Enable librarians to control when unaccepted private list share
invites are removed by the cleanup_database.pl cronjob

140747 - Bug 26831: Add new system preference PurgeListShareInvitesOlderThan
140751 - Bug 26831: Use new PurgeListShareInvitesOlderThan syspref
140752 - Bug 26831: Attempting to clarify prioritising of options

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26831: Add new system preference PurgeListShareInvitesOlderThan
Using index info to reconstruct a base tree...
M   installer/data/mysql/mandatory/sysprefs.sql
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
Auto-merging installer/data/mysql/mandatory/sysprefs.sql
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26831: Add new system preference
PurgeListShareInvitesOlderThan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26831] Enable librarians to control when unaccepted private list share invites are removed by the cleanup_database.pl cronjob

2022-09-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26831

Alex Buckley  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored
Summary|Replace 'list-invites'  |Enable librarians to
   |parameter with system   |control when unaccepted
   |preference in   |private list share invites
   |cleanup_database.pl cronjob |are removed by the
   ||cleanup_database.pl cronjob
  Text to go in the||The new
  release notes||PurgeListShareInvitesOlderT
   ||han system preference
   ||enables librarians to
   ||control when unaccepted
   ||private list share invites
   ||are removed from the
   ||database.
   ||
   ||Unaccepted
   ||private list share invites
   ||will now be removed based
   ||on the following
   ||prioritised options:
   ||
   ||-
   ||Priority 1. Use DAYS value
   ||when the
   ||cleanup_database.pl cronjob
   ||is run with a
   ||--list-invites DAYS
   ||parameter specified.
   ||
   ||-
   ||Priority 2. Use the
   ||PurgeListShareInvitesOlderT
   ||han system preference
   ||value.
   ||
   ||- Priority 3. Use a
   ||default of 14 days, if the
   ||cleanup_database.pl cronjob
   ||is run with a
   ||--list-invites parameter
   ||missing the DAYS value, AND
   ||the
   ||PurgeListShareInvitesOlderT
   ||han system preference is
   ||empty.
   ||
   ||- Priority 4. Don't
   ||remove any unaccepted
   ||private list share invites
   ||if the cleanup_database.pl
   ||cronjob is run without the
   ||--list-invites parameter
   ||and the
   ||PurgeListShareInvitesOlderT
   ||han syspref is empty.
 Status|ASSIGNED|Needs Signoff
   Keywords||Academy, Manual,
   ||release-notes-needed

--- Comment #11 from Alex Buckley  ---
Ready for testing. 

Please feel free to update the release notes if you think you can improve by
clarifying the prioritising of the options for controlling when unaccepted
private list share invites are deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/