[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-06-20 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Thibaud Guillot  changed:

   What|Removed |Added

 Attachment #167794|0   |1
is obsolete||

--- Comment #15 from Thibaud Guillot  ---
Created attachment 167935
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167935=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
OPAC search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind 
Signed-off-by: Thibaud Guillot 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-06-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

 Attachment #165822|0   |1
is obsolete||

--- Comment #14 from Owen Leonard  ---
Created attachment 167794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167794=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
OPAC search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds the
  release notes||slider widget for multiple
   ||cover images on the OPAC
   ||search results page (when
   ||multiple sources enabled),
   ||matching the way covers
   ||display on the detail page.

--- Comment #13 from David Nind  ---
Thanks Owen!

This looks really nice.

David

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Nind  changed:

   What|Removed |Added

 Attachment #165794|0   |1
is obsolete||

--- Comment #12 from David Nind  ---
Created attachment 165822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165822=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
OPAC search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

 Attachment #164669|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 165794
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165794=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
OPAC search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

Sponsored-by: Athens County Public Libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-29 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #10 from David Nind  ---
The patch no longer applies 8-(...

git bz apply 26933

Bug 26933 - Improve handling of multiple covers on catalog search results in
the OPAC

164669 - Bug 26933: Improve handling of multiple covers on catalog search
results in the OPAC

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 26933: Improve handling of multiple covers on catalog search
results in the OPAC
Using index info to reconstruct a base tree...
M   koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
error: Failed to merge in the changes.
Patch failed at 0001 Bug 26933: Improve handling of multiple covers on catalog
search results in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

kch-tr.lhl-consort...@nhs.net  changed:

   What|Removed |Added

 CC||kch-tr.lhl-consortium@nhs.n
   ||et

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

--- Comment #9 from Owen Leonard  ---
(In reply to David Cook from comment #7)

> Prior to the patch, there was this line

Thanks David I totally missed that!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

 Attachment #164630|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 164669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164669=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

- Amazon
- Local cover images (including multiple local cover images)
- Coce (serving up Amazon, Google, and OpenLibrary images)
- OpenLibrary
- Baker & Taylor
- Google
- Custom cover images (the CustomCoverImages preference)

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-11 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

--- Comment #7 from David Cook  ---
(In reply to Owen Leonard from comment #6)
> This patch is incomplete in that custom cover images (the CustomCoverImages
> system preference) will not display in search results. opac-detail.tt has
> access to biblio.custom_cover_image_url, but the same information isn't
> available in search results as far as I can tell.
> 
> I could use help exposing that information to the template.

Prior to the patch, there was this line:

[% SET custom_cover_image_url =
SEARCH_RESULT.biblio_object.custom_cover_image_url %]

I imagine you could bang that into a data attribute or something and then go
over it in the Javascript?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

--- Comment #6 from Owen Leonard  ---
This patch is incomplete in that custom cover images (the CustomCoverImages
system preference) will not display in search results. opac-detail.tt has
access to biblio.custom_cover_image_url, but the same information isn't
available in search results as far as I can tell.

I could use help exposing that information to the template.

I had originally tried to implement this feature by creating a common include
file and common JS file so that both search results and the detail page could
share code. I think that should still be a future change.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

--- Comment #5 from Owen Leonard  ---
Created attachment 164630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164630=edit
Bug 26933: Improve handling of multiple covers on catalog search results in the
OPAC

This patch implements a book cover slider widget for cover images in
search results, matching the way we show covers on the detail page.

To test, apply the page and rebuild the staff client CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Enable multiple cover image services. The patch was developed with these
services available:

 - Amazon
 - Local cover images (including multiple local cover images)
 - Coce (serving up Amazon, Google, and OpenLibrary images)
 - OpenLibrary
 - Baker & Taylor
 - Google

Perform a variet of searches and confirm that cover images are
displaying correctly, whether there be 0, 1, 2, or more covers
available for each.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2024-04-10 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2023-08-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Andreas Roussos  changed:

   What|Removed |Added

 CC||a.rous...@dataly.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2022-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Cook  changed:

   What|Removed |Added

 CC||ssamm...@npelem.com

--- Comment #4 from David Cook  ---
*** Bug 7669 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2022-08-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

--- Comment #3 from David Cook  ---
*** Bug 9991 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2022-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2022-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=28180

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC

2022-07-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933

Owen Leonard  changed:

   What|Removed |Added

Summary|OPAC - Multiple cover image |Improve handling of
   |show in results and details |multiple covers on catalog
   |pages   |search results in the OPAC
 Status|NEW |ASSIGNED
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=25846

--- Comment #2 from Owen Leonard  ---
Since the OPAC detail page has already been upgraded to handle multiple covers
like the staff interface has, I'm re-titling this bug to cover only OPAC search
results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/