[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added Version(s)|22.11.00|22.11.00, 22.05.18 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 wainuiwitikap...@catalyst.net.nz changed: What|Removed |Added CC||wainuiwitikapark@catalyst.n ||et.nz --- Comment #17 from wainuiwitikap...@catalyst.net.nz --- Backported to 22.05 as needed for Bug 34893 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com Status|Pushed to master|RESOLVED Resolution|--- |FIXED --- Comment #16 from Lucas Gass --- Enhancement will not be backported to 22.05.x unless requested -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 David Cook changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31389 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 139294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139294=edit Bug 27342: Fix C4::ILSDI::Services::AuthenticatePatron Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Keywords||release-notes-needed --- Comment #14 from Tomás Cohen Arazi --- This trivial change needs to be cleary documented and advertised on the release notes in case people are using checkpw (e.g. in plugins). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #13 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #12 from Tomás Cohen Arazi --- Created attachment 139196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139196=edit Bug 27342: (QA follow-up) Fix test Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize --- Nice bit of refactoring and all works as expected, no regressions. QA scripts happy and tests passing. Going for a straight QA on this simple pair of patches. Passing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #10 from Martin Renvoize --- Created attachment 138950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138950=edit Bug 27342: (QA follow-up) Remove dbh from new tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Martin Renvoize changed: What|Removed |Added Attachment #132025|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 138949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138949=edit Bug 27342: Remove dbh from C4::Auth We must not pass $dbh but retrieve it when needed instead Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Martin Renvoize changed: What|Removed |Added Attachment #132024|0 |1 is obsolete|| --- Comment #8 from Martin Renvoize --- Created attachment 138948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138948=edit Bug 27342: Improve test for OPAC We don't need to build allowed_scripts_for_private_opac for staff Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #7 from Jonathan Druart --- There is not much here but I think it can go anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #6 from Jonathan Druart --- Created attachment 132025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132025=edit Bug 27342: Remove dbh from C4::Auth We must not pass $dbh but retrieve it when needed instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Jonathan Druart changed: What|Removed |Added Attachment #114874|0 |1 is obsolete|| Attachment #114875|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 132024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132024=edit Bug 27342: Improve test for OPAC We don't need to build allowed_scripts_for_private_opac for staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #4 from Martin Renvoize --- Nice little cleanup here.. clear to read and review.. are you continuing here Jonathan or is this a first bug where you intend to continue on other bugs? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #3 from David Cook --- This looks like it will be tough to test although I think it's worth doing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #2 from Jonathan Druart --- Created attachment 114875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114875=edit Bug 27342: Remove dbh from C4::Auth We must not pass $dbh but retrieve it when needed instead -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27342] Improve readability and improvement of C4::Auth::get_template_and_user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27342 --- Comment #1 from Jonathan Druart --- Created attachment 114874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114874=edit Bug 27342: Improve test for OPAC We don't need to build allowed_scripts_for_private_opac for staff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
