[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #13 from Victor Grousset/tuxayo --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Andrew Fuerste-Henry changed: What|Removed |Added CC||and...@bywatersolutions.com Status|Pushed to stable|Pushed to oldstable Version(s)|21.05.00,20.11.03 |21.05.00,20.11.03,20.05.09 released in|| --- Comment #12 from Andrew Fuerste-Henry --- Pushed to 20.05.x for 20.05.09 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Version(s)|21.05.00|21.05.00,20.11.03 released in|| Status|Pushed to master|Pushed to stable --- Comment #11 from Fridolin Somers --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 --- Comment #10 from Jonathan Druart --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Jonathan Druart changed: What|Removed |Added Version(s)||21.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Katrin Fischer changed: What|Removed |Added Attachment #116292|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 116462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116462=edit Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :) Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Katrin Fischer changed: What|Removed |Added Attachment #116291|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 116461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116461=edit Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 --- Comment #7 from Martin Renvoize --- Oops, thanks for the fix Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 David Nind changed: What|Removed |Added Text to go in the||This fixes the order that release notes||additional patron ||attributes are displayed on ||the patron edit form. They ||are now sorted by the ||attribute code, before this ||they displayed in a random ||order. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 David Nind changed: What|Removed |Added Attachment #116254|0 |1 is obsolete|| --- Comment #6 from David Nind --- Created attachment 116292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116292=edit Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :) Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 David Nind changed: What|Removed |Added Attachment #115238|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 116291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116291=edit Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 --- Comment #4 from Jonathan Druart --- Created attachment 116254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116254=edit Bug 27454: Pass the arrayref Otherwise you mess with the following hash elements :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #3 from David Nind --- Created attachment 116244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116244=edit Bug 27454 - Display of paytron attributes after apply patch Hi Martin. I could replicate the problem, but after applying the patch the display of the additional attributes goes really weird - see screenshot. I created three patron attrributes: PA0, PA1, and PA2. I flushed the cached and restarted all after applying the patch. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Martin Renvoize changed: What|Removed |Added Keywords||Academy Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Martin Renvoize changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 --- Comment #2 from Martin Renvoize --- Created attachment 115238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115238=edit Bug 27454: Add sorting of patron attributes This patch adds sorting on class code for the patrons attributes forms on the memberentry page. Test plan 1) Create a couple of different patron attributes 2) Go to the patron add page 3) Note the order in which the patron attributes load at the bottom of the page. 4) Reload the page and note the order of those attribues may change (if it doesn't, try reloading again.. it's random) 5) Apply the patch 6) Reload the page a few times and confirm the attributes are now ordered. 7) Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27454] Additional patron attributes change sequence on every reload of edit page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27454 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #1 from Martin Renvoize --- I noticed this.. it's due to hash order randomisation I believe.. pretty sure I identified where it could be fixed.. will take a look on Monday -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/