[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Text to go in the||This enhancement adds a release notes||info image to the carredart ||icon set for item types. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED CC||k...@bywatersolutions.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #28 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=27505 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Passed QA Keywords|release-notes-needed| --- Comment #27 from Jonathan Druart --- I am really sorry, I got confused and was confusing! I thought we were adding a new set of icons. I have no idea how I understood that, everything is clear when reading the commit message and bug title: we are only adding a new 'info' icon to the existing "carredart" set. Sorry everybody! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #26 from Aleisha Amohia --- (In reply to Jonathan Druart from comment #25) > (In reply to Jonathan Druart from comment #23) > > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > > d'Art" (museum) > > This is waiting for an answer. Aleisha, maybe? That's the name on the item types icon tab. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #25 from Jonathan Druart --- (In reply to Jonathan Druart from comment #23) > Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré > d'Art" (museum) This is waiting for an answer. Aleisha, maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #24 from Owen Leonard --- I've removed my patch and returned the old ones. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Attachment #123164|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Attachment #123165|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Attachment #123457|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #23 from Jonathan Druart --- So now we have 2 versions, the one from Victoria and the one from Owen. Do we need both? Why is it named "carredart"? Initially it's coming from bug 5640 for "Carré d'Art" (museum) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #22 from Aleisha Amohia --- These icons were designed by a Catalyst Academy student (Victoria, who opened the bug report), and she designed them as part of her contribution to the Academy. They are free to use for Koha's image sets. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Attachment #123164|0 |1 is obsolete|| Attachment #123165|0 |1 is obsolete|| Attachment #123166|0 |1 is obsolete|| --- Comment #21 from Owen Leonard --- Created attachment 123457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123457=edit Bug 27522: Adding new itemtype info image to carredart This patch adds an "info" icon to the carredart icon set. It was created from scratch for Koha based on an earlier patch by Victoria Faafia. Test Plan: 1. Go to Administration > Item Types > Modify Item Type 2. Under carredart you should see an "info" item type icon. Assign it to an item type. 3. Go to Administration -> System preferences and make sure that OpacAdvSearchOptions and AdvancedSearchTypes have item type searches enabled. 4. In the OPAC and staff interface, view the advanced search page and confirm that the new icon appears. Signed-off-by: Sally Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Owen Leonard changed: What|Removed |Added Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added CC||alei...@catalyst.net.nz Status|Passed QA |In Discussion --- Comment #20 from Jonathan Druart --- Can we squash and clarify in the commit message what's happening here? It seems that the icons were part of Koha (bug 5640) but have been removed (inadvertently) and so we are adding them back? But with a modified version because we didn't know what was the license? Aleisha, do you remember the origin of this bug report? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #19 from Owen Leonard --- It was not my intention that both versions of the image be kept in the git history. I should have obsoleted the older patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #18 from Jonathan Druart --- They are binary files, and if we don't know their origin I don't see how it could be useful to keep them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 --- Comment #17 from Katrin Fischer --- I understood it that Owen did a new version of the image from scratch in his 3rd patch, but didn't want the work before to be lost. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed CC||jonathan.druart+koha@gmail. ||com --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > Victoria, Aleisha or someone else - as these don't appear to belong to the > original carredart item set (I believe this came from a library in Nimes - > bug 5640)- where were these new icons taken from? > Do we need to add any license information? I think it would be good to > document the source here or in the commit message. > As they don't perfectly fit the style, maybe we should put them on a > separate tab? > > Sorry if I missed something! Has this been answered? It's not clear to me from where are these icons coming and what is the license. Please clarify. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Attachment #122933|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 27522] Add a new itemtype info image to carredart
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27522 Katrin Fischer changed: What|Removed |Added Summary|Adding new itemtype info|Add a new itemtype info |image to carredart |image to carredart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
