[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #14 from Katrin Fischer --- Just wondering: if they are supposed to be and remain unique, should they not be ids? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Katrin Fischer changed: What|Removed |Added Attachment #121108|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Attachment #121118|0 |1 is obsolete|| --- Comment #13 from Lucas Gass --- Created attachment 121122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121122=edit Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Attachment #121109|0 |1 is obsolete|| --- Comment #12 from Lucas Gass --- Created attachment 121121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121121=edit Bug 28346: (QA follow-up) Correct silly mistake with cancel-action This patch moves the cancel-action class introduced in the previous commit from the font-icon to the button where it should be. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #11 from Lucas Gass --- Created attachment 121120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121120=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. Signed-off-by: Lucas Gass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #10 from Martin Renvoize --- Clearly I was having a bad day when I wrote this patch!.. Two simple follow-ups later, hopefully I've got it this time! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #9 from Martin Renvoize --- Created attachment 121118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121118=edit Bug 28346: (QA follow-up) Correct silly mistake with details-action This patch moves the details-action class introduced in the first commit from the font-icon to the button where it should be. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #8 from Lucas Gass --- (In reply to Martin Renvoize from comment #7) > Did I miss a case... 'details-action' looks like that one to me. Ah, yes I see 'details-action' but it on the icon element, not the button: -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #7 from Martin Renvoize --- Did I miss a case... 'details-action' looks like that one to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #6 from Lucas Gass --- What about the 'Details' button that goes to 'accountline-details.pl?accountlines_id=X'. That one should have a class as well right? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added Attachment #120917|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 121108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121108=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Martin Renvoize --- Good catch, seems I attached the class to the wrong element.. Doh! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #4 from Martin Renvoize --- Created attachment 121109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121109=edit Bug 28346: (QA follow-up) Correct silly mistake with cancel-action This patch moves the cancel-action class introduced in the previous commit from the font-icon to the button where it should be. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Sally changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Sally --- Hi Martin, Just one button missing a unique class, which is the cancel charge button: button type="submit" class="btn btn-default btn-xs" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 --- Comment #1 from Martin Renvoize --- Created attachment 120917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120917=edit Bug 28346: Add classes to account action buttons This patch adds identifiable classes to each action button that may be displayed next to an accountline on the borrower account page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28346] Action buttons should have unique classes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28346 Martin Renvoize changed: What|Removed |Added Blocks||13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
