[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Victor Grousset/tuxayo --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What|Removed |Added Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.12 released in|| Status|Pushed to stable|Pushed to oldstable --- Comment #9 from Fridolin Somers --- Pushed to 20.11.x for 20.11.12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Pushed to master|Pushed to stable Version(s)|21.11.00|21.11.00,21.05.05 released in|| --- Comment #8 from Kyle M Hall --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=28526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Jonathan Druart changed: What|Removed |Added Version(s)||21.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #6 from Jonathan Druart --- Not a big deal as the sub is private and only called once, but it would have good to test for the existence of the key, to avoid a warning. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize --- Super trivial fix, with test coverage and no regressions. Going straight for QA.. Passed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What|Removed |Added Attachment #121055|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize --- Created attachment 127220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127220=edit Bug 28365: (Bug 19873 follow-up) Make it possible to search on value 0 Bug 19873 fixed search with value 0. It works in first page but not in other pages. This patch fixes query_cgi var. Test plan: - create a st-numeric index in zebra conf related to a numeric field i.e: yourindex 1=yourindex 4=109 - fill a field with 0 in several biblio records, - reindex your biblios, - search yourindex=0 and go to second page of results, - should not work, - apply this patch, - test again, - should work Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Martin Renvoize changed: What|Removed |Added Attachment #121054|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize --- Created attachment 127219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127219=edit Bug 28365: Add unit test Run prove t/db_dependent/Search.t Without fix you get error : # Failed test 'buildQuery should keep 0 value in query_cgi' # at t/db_dependent/Search.t line 670. # got: 'idx=su%2Cphr' # expected: 'idx=su%2Cphr=0' This patch also adds a test for query_desc in case it is broken in the future. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 --- Comment #2 from Fridolin Somers --- Created attachment 121055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121055=edit Bug 28365: (Bug 19873 follow-up) Make it possible to search on value 0 Bug 19873 fixed search with value 0. It works in first page but not in other pages. This patch fixes query_cgi var. Test plan: - create a st-numeric index in zebra conf related to a numeric field i.e: yourindex 1=yourindex 4=109 - fill a field with 0 in several biblio records, - reindex your biblios, - search yourindex=0 and go to second page of results, - should not work, - apply this patch, - test again, - should work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 --- Comment #1 from Fridolin Somers --- Created attachment 121054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121054=edit Bug 28365: Add unit test Run prove t/db_dependent/Search.t Without fix you get error : # Failed test 'buildQuery should keep 0 value in query_cgi' # at t/db_dependent/Search.t line 670. # got: 'idx=su%2Cphr' # expected: 'idx=su%2Cphr=0' This patch also adds a test for query_desc in case it is broken in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28365] (Bug 19873 follow-up) Make it possible to search on value 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28365 Fridolin Somers changed: What|Removed |Added Depends on||19873 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19873 [Bug 19873] Make it possible to search on value 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
