[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to stable|RESOLVED Resolution|--- |FIXED --- Comment #11 from Fridolin Somers --- Depends on Bug 21260 not in 20.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Kyle M Hall changed: What|Removed |Added Version(s)|21.11.00|21.11.00,21.05.02 released in|| Status|Pushed to master|Pushed to stable CC||k...@bywatersolutions.com --- Comment #10 from Kyle M Hall --- Pushed to 21.05.x for 21.05.02 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 --- Comment #9 from Jonathan Druart --- Follow-up pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 --- Comment #8 from Jonathan Druart --- Created attachment 122794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122794=edit Bug 28483: Fix t/Search/buildQuery.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 --- Comment #7 from Jonathan Druart --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||21.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
--- Comment #6 from Marcel de Rooy ---
(In reply to Nick Clemens from comment #5)
> (In reply to Marcel de Rooy from comment #3)
> > When seeing this, I wonder right away why not the other one?
> >
> > -my $query= $operands[0];
> > +my $query= $operands[0] // "";
> > my $simple_query = $operands[0];
> >
> > And looking a bit later, I see:
> > for ($query_cgi,$simple_query) {
> > s/"//g;
> > }
> > Shouldnt this trigger a warn too when undefined?
>
> The code sets it undef later, and simple_query is not used between the two
> places
Hmm. Not important but I do not see that it is set to undef later, and if it
is, then it will surely trigger the uninitialized warn that we want to resolve.
If it is not set, then it depends on $operands[0]
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com
|y.org |
--- Comment #5 from Nick Clemens ---
(In reply to Marcel de Rooy from comment #3)
> When seeing this, I wonder right away why not the other one?
>
> -my $query= $operands[0];
> +my $query= $operands[0] // "";
> my $simple_query = $operands[0];
>
> And looking a bit later, I see:
> for ($query_cgi,$simple_query) {
> s/"//g;
> }
> Shouldnt this trigger a warn too when undefined?
The code sets it undef later, and simple_query is not used between the two
places
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Nick Clemens changed: What|Removed |Added Attachment #122313|0 |1 is obsolete|| --- Comment #4 from Nick Clemens --- Created attachment 122740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122740=edit Bug 28483: Remove warnings from Search.t There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #3 from Marcel de Rooy ---
When seeing this, I wonder right away why not the other one?
-my $query= $operands[0];
+my $query= $operands[0] // "";
my $simple_query = $operands[0];
And looking a bit later, I see:
for ($query_cgi,$simple_query) {
s/"//g;
}
Shouldnt this trigger a warn too when undefined?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What|Removed |Added Attachment #122312|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 122313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122313=edit Bug 28483: Remove warnings from Search.t There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 --- Comment #1 from Jonathan Druart --- Created attachment 122312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122312=edit Bug 28483: Avoid useless warnings There are too many warnings about uninitialized variables in Search.pm. This patch deals with that, the same way it is dealt accross the file: by setting an empty string when things are not defined. To test: 1. Run: $ kshell k$ prove t/db_dependent/Search.t => FAIL: Wow, too many warnings. Some related to this bug, some not. 2. Apply this patch 3. Repeat 1 => SUCCESS: No more warnings! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28483] Warnings from Search.t must be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28483 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
