[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #11 from Blou --- Some variation of this issue poped up again, this time with categories. Rereading the comments from the QAs, I see a resistance to putting restrictions on the branchcode (or other auth values, as well), but I see no trace of a solution. Underscores, hyphens, trailing spaces are breaking the search, and it's ok ? I don't see why Koha should accept *everything* for a CODE(!!). Yeah, we want the description to be flexible, in any language, but I don't get it for the code. We don't have to be uberrestrictive, but at least known problems should be avoided. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Eric Bégin changed: What|Removed |Added CC|salman@inlibro.com |eric.be...@inlibro.com, ||philippe.blo...@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #10 from Katrin Fischer --- The initial issue was with search here. If you have A-B and A as branch codes, limiting to A will also bring up A-B. Could be adding a hint that using _ space and - might lead to unexpected search results an alternative? That said, there _IS_ validation on the branchcode in the onboarding tool that is not reflected in the normal GUI - so instead of adding validation here, we could remove it there and add hints in both spots. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun ||ity.org Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Attachment #12|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Attachment #123332|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.druart+koha@gmail. ||com --- Comment #9 from Jonathan Druart --- Why this limitation? I would exclude a list of special characters but not to anything that is not a-Z0-9, "❤" is a valid branchcode and is known (by me, at least) to work perfectly. It will certainly be considered as a regression by users not using Latin alphabet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | Status|Signed Off |Passed QA --- Comment #8 from Nick Clemens --- We cannot edit existing branchcodes, so should nto cause issues for previously entered names, and prevents issues with new ones -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #7 from Nick Clemens --- Created attachment 12 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12=edit Bug 28495: (QA follow-up) Enable the use of underscores in branch codes This patch adds underscores to the list of valid characters in the branch code field. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Nick Clemens changed: What|Removed |Added Attachment #121867|0 |1 is obsolete|| Attachment #123318|0 |1 is obsolete|| --- Comment #6 from Nick Clemens --- Created attachment 123332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123332=edit Bug 28495: Improve validation of library entry form This patch adds validation of the "Library code" field so that entry is limited to letters and numbers. Also changed: Updated the email fields to add the "email" type attribute (see also Bug 27805). To test, apply the patch and go to Administration -> Libraries -> New library. - Try entering various strings in the "Library code" field. If you enter anything other than letters and numbers an error message should be displaed on blur or on submit. - Try submitting the form with no data in the "Library code" and/or "Name" field. The fields should be required. - Test entering various strings in the email-type fields: Email, Ill staff email, Reply-To, and Return-Path. Non-email entries should trigger a message, "Please enter a valid email address." Signed-off-by: Salman Ali Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #5 from Owen Leonard --- Created attachment 123318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123318=edit Bug 28495: (QA follow-up) Enable the use of underscores in branch codes This patch adds underscores to the list of valid characters in the branch code field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #4 from Nick Clemens --- Underscores? I know we have many libraries that have these in existing libraries and may want to continue with their naming pattern. I like preventing problems, but am we can limit this far -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Salman Ali changed: What|Removed |Added Attachment #121737|0 |1 is obsolete|| --- Comment #3 from Salman Ali --- Created attachment 121867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121867=edit Bug 28495: Improve validation of library entry form This patch adds validation of the "Library code" field so that entry is limited to letters and numbers. Also changed: Updated the email fields to add the "email" type attribute (see also Bug 27805). To test, apply the patch and go to Administration -> Libraries -> New library. - Try entering various strings in the "Library code" field. If you enter anything other than letters and numbers an error message should be displaed on blur or on submit. - Try submitting the form with no data in the "Library code" and/or "Name" field. The fields should be required. - Test entering various strings in the email-type fields: Email, Ill staff email, Reply-To, and Return-Path. Non-email entries should trigger a message, "Please enter a valid email address." Signed-off-by: Salman Ali -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #2 from Owen Leonard --- Is this really signed off? It looks like you may have forgotten to attach the signed-off patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Salman Ali changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||salman@inlibro.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 --- Comment #1 from Owen Leonard --- Created attachment 121737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121737=edit Bug 28495: Improve validation of library entry form This patch adds validation of the "Library code" field so that entry is limited to letters and numbers. Also changed: Updated the email fields to add the "email" type attribute (see also Bug 27805). To test, apply the patch and go to Administration -> Libraries -> New library. - Try entering various strings in the "Library code" field. If you enter anything other than letters and numbers an error message should be displaed on blur or on submit. - Try submitting the form with no data in the "Library code" and/or "Name" field. The fields should be required. - Test entering various strings in the email-type fields: Email, Ill staff email, Reply-To, and Return-Path. Non-email entries should trigger a message, "Please enter a valid email address." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28495] Add validation to branchcode upon library creation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28495 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
